Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Show progress rings before widgets have data to show - #1848
Merged
Conversation
David Bennett (dkbennett)
approved these changes
Nov 9, 2023
Felipe G (guimafelipe)
approved these changes
Nov 9, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Widgets should do their best to have a valid template and data as soon as possible. However, it sometimes takes some time for the extension to start up. Instead of showing an error, we should show a ProgressRing.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist