Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Add GitHub Enterprise Server support - #286

Merged
Vineeth Thomas Alex (vineeththomasalex) merged 29 commits into
mainfrom
user/vineeththomasalex/GHES_3
Jan 11, 2024
Merged

Add GitHub Enterprise Server support#286
Vineeth Thomas Alex (vineeththomasalex) merged 29 commits into
mainfrom
user/vineeththomasalex/GHES_3

Conversation

@vineeththomasalex

@vineeththomasalexVineeth Thomas Alex (vineeththomasalex) commented Nov 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of the pull request

This PR contains the following changes:

  • Adds GitHub Enterprise Server (GHES) v3 Support (supported version determined by Octokit)

  • Adds LoginUI page for GHES flow to enter PAT

  • Refactors LoginUIController flow to be more encapsulated into Pages

  • Refactors CredentialVault to allow test configuration

  • Adds Unit Tests for DeveloperID components

  • Adds Functional tests for restoring and using saved credentials for repository query

  • Catches (and logs) a crash during Startup due to bad saved credentials

  • Also, enables multi-user support for widgets (requires Widget UI update in a follow-up PR)

References and relevant issues

microsoft/devhome#825
#235

LoginUI flow for GHES

Untitled video - Made with Clipchamp
Not uploading gif of 2nd page since it has personal info. Please try it out yourself.

Validation steps performed

Ran old and new tests, and manually ran through login flow, widget and setup flow.

PR checklist

  • Closes #xxx
  • [X ] Tests added - Currently fails due to lack of Env variables. Looking into this.
  • Documentation updated

@vineeththomasalexVineeth Thomas Alex (vineeththomasalex) added the Area-Account-Sign-In Related to authenticating your GitHub account or anything related to sign-in label Nov 27, 2023
@krschauKristen Schau (krschau) removed this from the DHGE v0.7 milestone Nov 27, 2023
AmelBawa-msft
AmirMS (AmelBawa-msft) reviewed Jan 10, 2024
View reviewed changes
Comment threadsrc/GitHubExtension/Client/GithubClientProvider.cs Outdated
vineeththomasalex
Vineeth Thomas Alex (vineeththomasalex) commented Jan 10, 2024
View reviewed changes
Comment threadsrc/GitHubExtension/Client/Validation.cs Outdated
vineeththomasalex
Vineeth Thomas Alex (vineeththomasalex) commented Jan 10, 2024
View reviewed changes
Comment threadsrc/GitHubExtension/DeveloperId/CredentialVault.cs Outdated
vineeththomasalex
Vineeth Thomas Alex (vineeththomasalex) commented Jan 10, 2024
View reviewed changes
Comment threadsrc/GitHubExtension/DeveloperId/CredentialVault.cs Outdated
vineeththomasalex
Vineeth Thomas Alex (vineeththomasalex) commented Jan 10, 2024
View reviewed changes
Comment threadsrc/GitHubExtension/DeveloperId/DeveloperIdProvider.cs Outdated
AmelBawa-msft
AmirMS (AmelBawa-msft) approved these changes Jan 10, 2024
View reviewed changes
Comment threadsrc/GitHubExtension/Client/Validation.cs Outdated
Comment threadsrc/GitHubExtension/DeveloperId/CredentialVault.cs Outdated
vineeththomasalex
Vineeth Thomas Alex (vineeththomasalex) commented Jan 10, 2024
View reviewed changes
Comment threadsrc/GitHubExtension/DeveloperId/LoginUIController.cs Outdated
@vineeththomasalexVineeth Thomas Alex (vineeththomasalex) linked an issue Jan 11, 2024 that may be closed by this pull request
Extension requires too much OAuth permissions #235
Closed
@vineeththomasalex
Vineeth Thomas Alex (vineeththomasalex) dismissed jamespik’s stale reviewJanuary 11, 2024 21:51

Received permission to dismiss review from Jamespik

Closed
@vineeththomasalexVineeth Thomas Alex (vineeththomasalex) linked an issue Jan 11, 2024 that may be closed by this pull request
Dev Home GitHub extension should support Enterprise accounts microsoft/devhome#825
Closed
Eric Johnson (EricJohnson327) pushed a commit that referenced this pull request Jan 18, 2024
@vineeththomasalex
Add GitHub Enterprise Server support (#286)
b324a85
* Explicitly disallow multiple accounts on GitHub extension
* Fix constructor bug
* Tested GHES
* Stashing
* Basic flow works
* Validation added
* Minor updates
* Minor Widget update
* SearchManager minor update
* Fixed LoginUI
* Created separate states for pages
* Added CredentialVault Tests
* Added LoginUI tests
* Added some tests
* Reverted Widget updates
* Fixed tests
* Revert changes to allow multi-user for tests
* PR Comments 1
* PR comments 2
* Ignore some tests in pipeline
* PR Comments 3
* PR Comments 4
* Minor update
* PR comments 6
* PR Comments 7
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krschauKristen Schau (krschau)Awaiting requested review from krschau
@guimafelipeFelipe G (guimafelipe)Awaiting requested review from guimafelipe
@EricJohnson327Eric Johnson (EricJohnson327)Awaiting requested review from EricJohnson327
@bbonabyBranden Bonaby (bbonaby)Awaiting requested review from bbonaby
@jamespikjamespikAwaiting requested review from jamespik
4 more reviewers
@dhoehnaDarren Hoehna (dhoehna)dhoehna left review comments
@dkbennettDavid Bennett (dkbennett)dkbennett approved these changes
@AmelBawa-msftAmirMS (AmelBawa-msft)AmelBawa-msft approved these changes
@ssparachssparachssparach approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vineeththomasalexVineeth Thomas Alex (vineeththomasalex)

Labels

Area-Account-Sign-InRelated to authenticating your GitHub account or anything related to sign-in

Projects

None yet

Milestone

DHGE v0.10

Development

Successfully merging this pull request may close these issues.

Extension requires too much OAuth permissions Dev Home GitHub extension should support Enterprise accounts

8 participants

@vineeththomasalex@dhoehna@bogdan-arsene@dkbennett@jamespik@AmelBawa-msft@ssparach@krschau