Uh oh!
There was an error while loading. Please reload this page.
Update to 2.0 SDK - #25
Merged
Merged
Conversation
Signed-off-by: Darren Stahl <darst@microsoft.com>
Darren Stahl (darstahl)force-pushed
the
AppveyorInstall
branch
2 times, most recently
from
January 10, 2018 01:28
283cb35 to
0faf59cCompareDarren Stahl (darstahl)
commented
Jan 10, 2018
Author
Justin (@jterry75)Stefan J. Wernli (@swernli) PTAL this fixes CI |
Justin (jterry75)
commented
Jan 10, 2018
Contributor
Nice @darrenstahlmsft - Only feedback I have is that I led you astray. You will want to still call |
Darren Stahl (darstahl)force-pushed
the
AppveyorInstall
branch
2 times, most recently
from
January 10, 2018 21:13
8a6f506 to
bcf1d89CompareDarren Stahl (darstahl)
commented
Jan 10, 2018
Author
Added samples to the SLN file and added back the |
Signed-off-by: Darren Stahl <darst@microsoft.com>
Darren Stahl (darstahl)force-pushed
the
AppveyorInstall
branch
from
January 10, 2018 21:27
bcf1d89 to
dbcefefCompareDarren Stahl (darstahl)
commented
Jan 10, 2018
Author
Also pushed a fix to the build warning by adding a reference to |
Justin (jterry75)
commented
Jan 10, 2018
Contributor
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating dotnet installer to use the ps1 install script and updating the SDK to 2.0.
This fixes CI issues found in #24
Signed-off-by: Darren Stahl darst@microsoft.com