Uh oh!
There was an error while loading. Please reload this page.
Cascade terminate/purge support in GrpcDurableTaskClient - #262
Conversation
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
There was a problem hiding this comment.
As we now have multiple parameters for terminate, I recommend we do the following:
- Add
TerminateInstanceOptions - Make the current
abstractmethodvirtual. Default implementation will call one of the new methods we add. - Add
TerminateInstanceOptionsacceptingvirtualmethods - Update our clients to override the new options-receiving method.
/// add xmldocpublicrecordTerminateInstanceOptions{publicobject?Output{get;init;}publicboolRecursive{get;init;}}new methods:
publicvirtualTaskTerminateInstanceAsync(stringinstanceId,TerminateInstanceOptions?options,CancellationTokencancellation)=>thrownewNotSupportedException($"{this.GetType()} does not support orchestration termination.");// this is the formerly abstract methodpublicvirtualTaskTerminateInstanceAsync(stringinstanceId,object?output=null,CancellationTokencancellation=default){TerminateInstanceOptions?options=outputisnull?null:new(){Output=output};returnthis.TerminateInstanceAsync(instanceId,options,cancellation);}Uh oh!
There was an error while loading. Please reload this page.
I am okay with this change. Just should the new |
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
70e9c1a to
e2f9bc1CompareSigned-off-by: Shivam Kumar <shivamkm07@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Shivam Kumar (shivamkm07)
commented
Jan 31, 2024
Jacob Viau (@jviau) Pushed the suggested changes. Please review. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
Jacob Viau (jviau)
left a comment
There was a problem hiding this comment.
Only a few small comments of recursive default behavior.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Shivam Kumar <shivamkm07@gmail.com>
This PR adds support to recursively terminate/purge sub-orchestrations in GrpcDurableTaskClient. It also sets the recursive behavior to be false by default.
Closes: #260