Skip to content

Implement suspend and resume client APIs - #104

Merged
kaibocai (kaibocai) merged 10 commits into
mainfrom
kaibocai/issue96
Feb 1, 2023
Merged

Implement suspend and resume client APIs#104
kaibocai (kaibocai) merged 10 commits into
mainfrom
kaibocai/issue96

Conversation

@kaibocai

@kaibocaikaibocai (kaibocai) commented Jan 20, 2023

Copy link
Copy Markdown
Member

Issue describing the changes in this PR

resolves#96

Pull request checklist

  • My changes do not require documentation changes
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@kaibocaikaibocai (kaibocai) changed the title Kaibocai/issue96Implement suspend and resume client APIsJan 20, 2023
@kaibocai

Copy link
Copy Markdown
MemberAuthor

Integration tests passed on local on latest durabletask-sidecar.
Added two integration tests, one is testing suspend instance, one is testing suspend and resume instance. Please let me know if they are sufficient. Thank you.

@cgillum

Copy link
Copy Markdown
Member

kaibocai (@kaibocai) great! So the next step for me is to update the sidecar container used by the CI. Can you also open an issue that tracks updating this documentation? https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-instance-management?tabs=java#suspend-and-resume-instances-preview

@kaibocai

Copy link
Copy Markdown
MemberAuthor

Create issue #105 to track document update

Comment threadclient/src/test/java/com/microsoft/durabletask/IntegrationTests.java Outdated
Comment threadclient/src/test/java/com/microsoft/durabletask/IntegrationTests.java Outdated
Comment threadclient/src/test/java/com/microsoft/durabletask/IntegrationTests.java Outdated
@kaibocai

kaibocai (kaibocai) commented Feb 1, 2023

Copy link
Copy Markdown
MemberAuthor

Hi Chris Gillum (@cgillum) , I have updated the unit tests (combine redundant tests and add one for testing termination). I found an issue in sidecar for method waitForInstanceCompletion, I raised a PR at https://github.com/microsoft/durabletask-sidecar/pull/19 can you take a look? Thank you.

@cgillumChris Gillum (cgillum) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple small suggestions before merging.

Comment threadclient/src/test/java/com/microsoft/durabletask/IntegrationTests.java Outdated
@kaibocai

kaibocai (kaibocai) commented Feb 1, 2023

Copy link
Copy Markdown
MemberAuthor

Updated the sidecar, all tests pass. Merging this PR!

@kanupriya15025

Copy link
Copy Markdown

kaibocai (@kaibocai)Chris Gillum (@cgillum)

  1. Can we also have a ticket to return the HTTP endpoints for suspend and resume in the HTTP Response we get after submitting an orchestrator?
  2. Also, the documentation is still not complete here : https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-instance-management?tabs=java#suspend-and-resume-instances-preview

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suspend and Resume client APIs

3 participants

@kaibocai@cgillum@kanupriya15025