Skip to content

Implement waitForCompletionOrCreateCheckStatusResponse - #115

Merged
kaibocai (kaibocai) merged 6 commits into
mainfrom
kaibocai/issue64
Feb 23, 2023
Merged

Implement waitForCompletionOrCreateCheckStatusResponse#115
kaibocai (kaibocai) merged 6 commits into
mainfrom
kaibocai/issue64

Conversation

@kaibocai

@kaibocaikaibocai (kaibocai) commented Feb 23, 2023

Copy link
Copy Markdown
Member

Issue describing the changes in this PR

resolves#64

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes are added to the CHANGELOG.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Still need to

  1. update document
  2. have E2E tests.

@kaibocaikaibocai (kaibocai) changed the title implement waitForCompletionOrCreateCheckStatusResponseImplement waitForCompletionOrCreateCheckStatusResponseFeb 23, 2023
cgillum
Chris Gillum (cgillum) approved these changes Feb 23, 2023
View reviewed changes

@cgillumChris Gillum (cgillum) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple JavaDoc nits but otherwise go ahead and merge when you're ready.

Comment threadazurefunctions/src/main/java/com/microsoft/durabletask/azurefunctions/DurableClientContext.java Outdated
Comment threadazurefunctions/src/main/java/com/microsoft/durabletask/azurefunctions/DurableClientContext.java Outdated
@kaibocaikaibocai (kaibocai) mentioned this pull request Feb 23, 2023
Open
4 tasks
@kaibocai
kaibocai (kaibocai) deleted the kaibocai/issue64 branch February 23, 2023 22:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgillumChris Gillum (cgillum)cgillum approved these changes
@shreyas-gopalakrishnaShreyas Gopalakrishna (shreyas-gopalakrishna)Awaiting requested review from shreyas-gopalakrishna

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add waitForCompletionOrCreateCheckStatusResponse client API

2 participants

@kaibocai@cgillum