Skip to content

React Native 0.66 Update - #1809

Merged
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom
nabil-k:66-update
Jul 14, 2022
Merged

React Native 0.66 Update#1809
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom
nabil-k:66-update

Conversation

@nabil-k

@nabil-kNabil Khalil (nabil-k) commented Jun 30, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

This PR is based on the changes from #1511

Platform Status

  • Win32: Good, no known issues at the moment.
  • Windows: Good, no known issues at the moment.
    • It actually runs better than it's RN 0.64 counterpart. On RN 0.64 when switching pages you would get a render error that says Cannot redefine non-configurable property. However, after updating everything to RN 0.66, I haven't gotten that error at all.
  • MacOs: Good, no known issues at the moment.
  • iOS: Good, no known issues at the moment.
  • Android: Good, no known issues at the moment.

Description of Changes

These are just changes I've made to get further through the build process. This is just to help everyone be aware of some changes that have occurred between RN 0.64 and RN 0.66.

General

packages/utils/adapters/src/adapters
For RN 0.66 Typescript, two new props on TextProps have been added called onPressIn and onPressOut.

Windows

packages/theming/theming-utils/src/getCurrentAppearance.windows.ts
Removed !AppTheme.isAvailable, causes a type error.

Win32

packages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts
Removed declaring TurboModuleRegistry in a react native module.

Verification

(how the change was tested, including both manual and automated tests)

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

Saad Najmi (Saadnajmi)and others added 23 commits March 11, 2022 11:53
@Saadnajmi
Update rnx-kit configurations
999917e
@Saadnajmi
yarn rnx-dep-check --write
2049874
@Saadnajmi
Remove workspace resolutions
86b8404
@Saadnajmi
Update React / React Native / React Native macOS/Windows/Win32 depend…
5509437
…encies
@Saadnajmi
Fix yarn build fallout
4a4f8e3
@Saadnajmi
Fix test fallout
6bd8f5f
@Saadnajmi
Update podfile locks
5f353e2
@Saadnajmi
Remove unnecessary dependency
821306c
@Saadnajmi
Change files
50af282
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
43f9d82
…native into 66-update
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
31d12be
…nto 66-update
@Saadnajmi
Remove alpha cli resolution
bc9bd2d
@Saadnajmi
rnx-dep-check --write
6c04e9c
@Saadnajmi
update lock
c0cb342
@Saadnajmi
update rex
0a6b31b
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
2af2dfe
…native into 66-update
@Saadnajmi
update lock
7a31b11
@Saadnajmi
update ios podfile
6bef378
@Saadnajmi
update macos podfile
570be15
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
e3420ad
…nto 66-update
@nabil-k
upgrade RN types to version 0.66
aefc1c4
@nabil-k
updated some components to 0.66 and renamed TurboModuleRegistry in ge…
a1348e0
…tThemingModule
@nabil-k
resolved type errors
70929e5
@nabil-k
Nabil Khalil (nabil-k) requested a review from a team as a code ownerJune 30, 2022 02:00
@samuelfreiberg

Samuel Freiberg (samuelfreiberg) commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

"This is not meant to be merged as it currently stands." I think we should make this a Draft PR if it's not meant to be merged and there's a lot of work left (just so the intent is clear).

@nabil-k
Nabil Khalil (nabil-k) marked this pull request as draft June 30, 2022 04:13
Saadnajmi
Saad Najmi (Saadnajmi) reviewed Jun 30, 2022
View reviewed changes
Comment threadapps/android/package.json Outdated
Comment threadpackage.json Outdated
Comment threadpackages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts Outdated
Comment threadpackages/utils/adapters/src/adapters.android.ts Outdated
@Saadnajmi

Saad Najmi (Saadnajmi) commented Jun 30, 2022

Copy link
Copy Markdown
Collaborator

If you're feeling fancy, you could update it so that every package.json has an rnx-kit config and future version upgrades are a simple one-line rnx-dep-check --write. Totally not required though :)

@SaadnajmiSaad Najmi (Saadnajmi) mentioned this pull request Jun 30, 2022
Closed
10 tasks
@nabil-k

Nabil Khalil (nabil-k) commented Jul 12, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Ruriko Araki (@rurikoaraki) Yeah I think we should, I tested the onPressIn/Out prop and it works on all platform. I've added it, thanks!

rurikoaraki
Ruriko Araki (rurikoaraki) reviewed Jul 12, 2022
View reviewed changes
Comment threadapps/fluent-tester/src/FluentTester/FluentTester.tsx Outdated
rurikoaraki
Ruriko Araki (rurikoaraki) reviewed Jul 12, 2022
View reviewed changes
Comment threadpackage.json
@Saadnajmi

Saad Najmi (Saadnajmi) commented Jul 12, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Minor note:
I think the test apps still specify "react-test-renderer": "17.0.1". That should probably be "17.0.2"

@nabil-k
Nabil Khalil (nabil-k) marked this pull request as ready for review July 12, 2022 22:03
@nabil-k
Nabil Khalil (nabil-k) marked this pull request as draft July 12, 2022 22:30
@nabil-k
Nabil Khalil (nabil-k) marked this pull request as ready for review July 12, 2022 23:12
@nabil-k

Nabil Khalil (nabil-k) commented Jul 12, 2022

Copy link
Copy Markdown
ContributorAuthor

This PR causes this issue where Shadow is unable to pass the Jest tests due to an error "Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules"

@nabil-k
Nabil Khalil (nabil-k) marked this pull request as draft July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k) marked this pull request as draft July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k) marked this pull request as ready for review July 13, 2022 20:34
@Dewsk

Andrew Dewar (Dewsk) commented Jul 13, 2022

Copy link
Copy Markdown
Collaborator

Nabil - great job here! We're really close to being ready to merge and this was a large cross-platform ask. I think we have some cool stories to tell about it and I've been really impressed with how diligently you've worked through all the tricky platform unique issues.

Dewsk
Andrew Dewar (Dewsk) approved these changes Jul 13, 2022
View reviewed changes

@DewskAndrew Dewar (Dewsk) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to merge this!

@rurikoaraki

Ruriko Araki (rurikoaraki) commented Jul 14, 2022

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelinesBot commented Jul 14, 2022

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Dewsk
Andrew Dewar (Dewsk) merged commit 155145b into microsoft:masterJul 14, 2022
This was referenced Jul 14, 2022
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DewskAndrew Dewar (Dewsk)Dewsk approved these changes
@rurikoarakiRuriko Araki (rurikoaraki)rurikoaraki approved these changes
@SaadnajmiSaad Najmi (Saadnajmi)Saadnajmi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nabil-k@samuelfreiberg@Saadnajmi@rurikoaraki@Dewsk
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
React Native 0.66 Update by nabil-k · Pull Request #1809 · microsoft/fluentui-react-native · GitHub
Skip to content
React Native 0.66 Update - #1809
Merged
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Jul 14, 2022
Merged
React Native 0.66 Update#1809
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Conversation
@nabil-k
@nabil-kNabil Khalil (nabil-k)
commented
Jun 30, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Platforms Impacted
  •  iOS
  •  macOS
  •  win32 (Office)
  •  windows
  •  android
This PR is based on the changes from #1511
Platform Status
  • Win32: Good, no known issues at the moment.
  • Windows: Good, no known issues at the moment.

    • It actually runs better than it's RN 0.64 counterpart. On RN 0.64 when switching pages you would get a render error that says Cannot redefine non-configurable property. However, after updating everything to RN 0.66, I haven't gotten that error at all.
  • MacOs: Good, no known issues at the moment.
  • iOS: Good, no known issues at the moment.
  • Android: Good, no known issues at the moment.
Description of Changes
These are just changes I've made to get further through the build process. This is just to help everyone be aware of some changes that have occurred between RN 0.64 and RN 0.66.
General
packages/utils/adapters/src/adapters

For RN 0.66 Typescript, two new props on TextProps have been added called onPressIn and onPressOut.
Windows
packages/theming/theming-utils/src/getCurrentAppearance.windows.ts

Removed !AppTheme.isAvailable, causes a type error.
Win32
packages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts

Removed declaring TurboModuleRegistry in a react native module.
Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered (when applicable):
  •  Automated Tests
  •  Documentation and examples
  •  Keyboard Accessibility
  •  Voiceover
  •  Internationalization and Right-to-left Layouts
Saad Najmi (Saadnajmi)and others
added 23 commits
March 11, 2022 11:53
@Saadnajmi
Update rnx-kit configurations
999917e
@Saadnajmi
yarn rnx-dep-check --write
2049874
@Saadnajmi
Remove workspace resolutions
86b8404
@Saadnajmi
Update React / React Native / React Native macOS/Windows/Win32 depend…
5509437
…encies
@Saadnajmi
Fix yarn build fallout
4a4f8e3
@Saadnajmi
Fix test fallout
6bd8f5f
@Saadnajmi
Update podfile locks
5f353e2
@Saadnajmi
Remove unnecessary dependency
821306c
@Saadnajmi
Change files
50af282
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
43f9d82
…native into 66-update
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
31d12be
…nto 66-update
@Saadnajmi
Remove alpha cli resolution
bc9bd2d
@Saadnajmi
rnx-dep-check --write
6c04e9c
@Saadnajmi
update lock
c0cb342
@Saadnajmi
update rex
0a6b31b
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
2af2dfe
…native into 66-update
@Saadnajmi
update lock
7a31b11
@Saadnajmi
update ios podfile
6bef378
@Saadnajmi
update macos podfile
570be15
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
e3420ad
…nto 66-update
@nabil-k
upgrade RN types to version 0.66
aefc1c4
@nabil-k
updated some components to 0.66 and renamed TurboModuleRegistry in ge…
a1348e0
…tThemingModule
@nabil-k
resolved type errors
70929e5
@nabil-k
Nabil Khalil (nabil-k)
requested a review
from a team
as a code ownerJune 30, 2022 02:00
@samuelfreiberg
Samuel Freiberg (samuelfreiberg)
commented
Jun 30, 2022

Copy link


Copy Markdown

Contributor
"This is not meant to be merged as it currently stands." I think we should make this a Draft PR if it's not meant to be merged and there's a lot of work left (just so the intent is clear).
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
June 30, 2022 04:13
Saadnajmi
Saad Najmi (Saadnajmi)
reviewed
Jun 30, 2022
View reviewed changes
Comment threadapps/android/package.json
Outdated

Comment threadpackage.json
Outdated

Comment threadpackages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts
Outdated

Comment threadpackages/utils/adapters/src/adapters.android.ts
Outdated

@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jun 30, 2022

Copy link


Copy Markdown

Collaborator
If you're feeling fancy, you could update it so that every package.json has an rnx-kit config and future version upgrades are a simple one-line rnx-dep-check --write. Totally not required though :)
@SaadnajmiSaad Najmi (Saadnajmi)
mentioned this pull request
Jun 30, 2022
 Closed

10 tasks
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Ruriko Araki (@rurikoaraki) Yeah I think we should, I tested the onPressIn/Out prop and it works on all platform. I've added it, thanks!
rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadapps/fluent-tester/src/FluentTester/FluentTester.tsx
Outdated

rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadpackage.json
@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
Minor note:

I think the test apps still specify "react-test-renderer": "17.0.1". That should probably be "17.0.2"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 22:03
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 12, 2022 22:30
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 23:12
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This PR causes this issue where Shadow is unable to pass the Jest tests due to an error "Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 13, 2022 20:34
@Dewsk
Andrew Dewar (Dewsk)
commented
Jul 13, 2022

Copy link


Copy Markdown

Collaborator
Nabil - great job here! We're really close to being ready to merge and this was a large cross-platform ask. I think we have some cool stories to tell about it and I've been really impressed with how diligently you've worked through all the tricky platform unique issues.
Dewsk
Andrew Dewar (Dewsk)
approved these changes
Jul 13, 2022
View reviewed changes
@DewskAndrew Dewar (Dewsk)
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to merge this!
@rurikoaraki
Ruriko Araki (rurikoaraki)
commented
Jul 14, 2022

Copy link


Copy Markdown

Collaborator
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 14, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@Dewsk
Andrew Dewar (Dewsk)
merged commit 155145b
into
microsoft:masterJul 14, 2022

This was referenced Jul 14, 2022

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@DewskAndrew Dewar (Dewsk)Dewsk approved these changes
@rurikoarakiRuriko Araki (rurikoaraki)rurikoaraki approved these changes
@SaadnajmiSaad Najmi (Saadnajmi)Saadnajmi approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@nabil-k@samuelfreiberg@Saadnajmi@rurikoaraki@Dewsk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
React Native 0.66 Update by nabil-k · Pull Request #1809 · microsoft/fluentui-react-native · GitHub
Skip to content
React Native 0.66 Update - #1809
Merged
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Jul 14, 2022
Merged
React Native 0.66 Update#1809
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Conversation
@nabil-k
@nabil-kNabil Khalil (nabil-k)
commented
Jun 30, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Platforms Impacted
  •  iOS
  •  macOS
  •  win32 (Office)
  •  windows
  •  android
This PR is based on the changes from #1511
Platform Status
  • Win32: Good, no known issues at the moment.
  • Windows: Good, no known issues at the moment.

    • It actually runs better than it's RN 0.64 counterpart. On RN 0.64 when switching pages you would get a render error that says Cannot redefine non-configurable property. However, after updating everything to RN 0.66, I haven't gotten that error at all.
  • MacOs: Good, no known issues at the moment.
  • iOS: Good, no known issues at the moment.
  • Android: Good, no known issues at the moment.
Description of Changes
These are just changes I've made to get further through the build process. This is just to help everyone be aware of some changes that have occurred between RN 0.64 and RN 0.66.
General
packages/utils/adapters/src/adapters

For RN 0.66 Typescript, two new props on TextProps have been added called onPressIn and onPressOut.
Windows
packages/theming/theming-utils/src/getCurrentAppearance.windows.ts

Removed !AppTheme.isAvailable, causes a type error.
Win32
packages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts

Removed declaring TurboModuleRegistry in a react native module.
Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered (when applicable):
  •  Automated Tests
  •  Documentation and examples
  •  Keyboard Accessibility
  •  Voiceover
  •  Internationalization and Right-to-left Layouts
Saad Najmi (Saadnajmi)and others
added 23 commits
March 11, 2022 11:53
@Saadnajmi
Update rnx-kit configurations
999917e
@Saadnajmi
yarn rnx-dep-check --write
2049874
@Saadnajmi
Remove workspace resolutions
86b8404
@Saadnajmi
Update React / React Native / React Native macOS/Windows/Win32 depend…
5509437
…encies
@Saadnajmi
Fix yarn build fallout
4a4f8e3
@Saadnajmi
Fix test fallout
6bd8f5f
@Saadnajmi
Update podfile locks
5f353e2
@Saadnajmi
Remove unnecessary dependency
821306c
@Saadnajmi
Change files
50af282
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
43f9d82
…native into 66-update
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
31d12be
…nto 66-update
@Saadnajmi
Remove alpha cli resolution
bc9bd2d
@Saadnajmi
rnx-dep-check --write
6c04e9c
@Saadnajmi
update lock
c0cb342
@Saadnajmi
update rex
0a6b31b
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
2af2dfe
…native into 66-update
@Saadnajmi
update lock
7a31b11
@Saadnajmi
update ios podfile
6bef378
@Saadnajmi
update macos podfile
570be15
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
e3420ad
…nto 66-update
@nabil-k
upgrade RN types to version 0.66
aefc1c4
@nabil-k
updated some components to 0.66 and renamed TurboModuleRegistry in ge…
a1348e0
…tThemingModule
@nabil-k
resolved type errors
70929e5
@nabil-k
Nabil Khalil (nabil-k)
requested a review
from a team
as a code ownerJune 30, 2022 02:00
@samuelfreiberg
Samuel Freiberg (samuelfreiberg)
commented
Jun 30, 2022

Copy link


Copy Markdown

Contributor
"This is not meant to be merged as it currently stands." I think we should make this a Draft PR if it's not meant to be merged and there's a lot of work left (just so the intent is clear).
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
June 30, 2022 04:13
Saadnajmi
Saad Najmi (Saadnajmi)
reviewed
Jun 30, 2022
View reviewed changes
Comment threadapps/android/package.json
Outdated

Comment threadpackage.json
Outdated

Comment threadpackages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts
Outdated

Comment threadpackages/utils/adapters/src/adapters.android.ts
Outdated

@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jun 30, 2022

Copy link


Copy Markdown

Collaborator
If you're feeling fancy, you could update it so that every package.json has an rnx-kit config and future version upgrades are a simple one-line rnx-dep-check --write. Totally not required though :)
@SaadnajmiSaad Najmi (Saadnajmi)
mentioned this pull request
Jun 30, 2022
 Closed

10 tasks
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Ruriko Araki (@rurikoaraki) Yeah I think we should, I tested the onPressIn/Out prop and it works on all platform. I've added it, thanks!
rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadapps/fluent-tester/src/FluentTester/FluentTester.tsx
Outdated

rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadpackage.json
@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
Minor note:

I think the test apps still specify "react-test-renderer": "17.0.1". That should probably be "17.0.2"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 22:03
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 12, 2022 22:30
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 23:12
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This PR causes this issue where Shadow is unable to pass the Jest tests due to an error "Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 13, 2022 20:34
@Dewsk
Andrew Dewar (Dewsk)
commented
Jul 13, 2022

Copy link


Copy Markdown

Collaborator
Nabil - great job here! We're really close to being ready to merge and this was a large cross-platform ask. I think we have some cool stories to tell about it and I've been really impressed with how diligently you've worked through all the tricky platform unique issues.
Dewsk
Andrew Dewar (Dewsk)
approved these changes
Jul 13, 2022
View reviewed changes
@DewskAndrew Dewar (Dewsk)
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to merge this!
@rurikoaraki
Ruriko Araki (rurikoaraki)
commented
Jul 14, 2022

Copy link


Copy Markdown

Collaborator
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 14, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@Dewsk
Andrew Dewar (Dewsk)
merged commit 155145b
into
microsoft:masterJul 14, 2022

This was referenced Jul 14, 2022

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@DewskAndrew Dewar (Dewsk)Dewsk approved these changes
@rurikoarakiRuriko Araki (rurikoaraki)rurikoaraki approved these changes
@SaadnajmiSaad Najmi (Saadnajmi)Saadnajmi approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@nabil-k@samuelfreiberg@Saadnajmi@rurikoaraki@Dewsk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
React Native 0.66 Update by nabil-k · Pull Request #1809 · microsoft/fluentui-react-native · GitHub
Skip to content
React Native 0.66 Update - #1809
Merged
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Jul 14, 2022
Merged
React Native 0.66 Update#1809
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Conversation
@nabil-k
@nabil-kNabil Khalil (nabil-k)
commented
Jun 30, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Platforms Impacted
  •  iOS
  •  macOS
  •  win32 (Office)
  •  windows
  •  android
This PR is based on the changes from #1511
Platform Status
  • Win32: Good, no known issues at the moment.
  • Windows: Good, no known issues at the moment.

    • It actually runs better than it's RN 0.64 counterpart. On RN 0.64 when switching pages you would get a render error that says Cannot redefine non-configurable property. However, after updating everything to RN 0.66, I haven't gotten that error at all.
  • MacOs: Good, no known issues at the moment.
  • iOS: Good, no known issues at the moment.
  • Android: Good, no known issues at the moment.
Description of Changes
These are just changes I've made to get further through the build process. This is just to help everyone be aware of some changes that have occurred between RN 0.64 and RN 0.66.
General
packages/utils/adapters/src/adapters

For RN 0.66 Typescript, two new props on TextProps have been added called onPressIn and onPressOut.
Windows
packages/theming/theming-utils/src/getCurrentAppearance.windows.ts

Removed !AppTheme.isAvailable, causes a type error.
Win32
packages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts

Removed declaring TurboModuleRegistry in a react native module.
Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered (when applicable):
  •  Automated Tests
  •  Documentation and examples
  •  Keyboard Accessibility
  •  Voiceover
  •  Internationalization and Right-to-left Layouts
Saad Najmi (Saadnajmi)and others
added 23 commits
March 11, 2022 11:53
@Saadnajmi
Update rnx-kit configurations
999917e
@Saadnajmi
yarn rnx-dep-check --write
2049874
@Saadnajmi
Remove workspace resolutions
86b8404
@Saadnajmi
Update React / React Native / React Native macOS/Windows/Win32 depend…
5509437
…encies
@Saadnajmi
Fix yarn build fallout
4a4f8e3
@Saadnajmi
Fix test fallout
6bd8f5f
@Saadnajmi
Update podfile locks
5f353e2
@Saadnajmi
Remove unnecessary dependency
821306c
@Saadnajmi
Change files
50af282
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
43f9d82
…native into 66-update
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
31d12be
…nto 66-update
@Saadnajmi
Remove alpha cli resolution
bc9bd2d
@Saadnajmi
rnx-dep-check --write
6c04e9c
@Saadnajmi
update lock
c0cb342
@Saadnajmi
update rex
0a6b31b
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
2af2dfe
…native into 66-update
@Saadnajmi
update lock
7a31b11
@Saadnajmi
update ios podfile
6bef378
@Saadnajmi
update macos podfile
570be15
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
e3420ad
…nto 66-update
@nabil-k
upgrade RN types to version 0.66
aefc1c4
@nabil-k
updated some components to 0.66 and renamed TurboModuleRegistry in ge…
a1348e0
…tThemingModule
@nabil-k
resolved type errors
70929e5
@nabil-k
Nabil Khalil (nabil-k)
requested a review
from a team
as a code ownerJune 30, 2022 02:00
@samuelfreiberg
Samuel Freiberg (samuelfreiberg)
commented
Jun 30, 2022

Copy link


Copy Markdown

Contributor
"This is not meant to be merged as it currently stands." I think we should make this a Draft PR if it's not meant to be merged and there's a lot of work left (just so the intent is clear).
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
June 30, 2022 04:13
Saadnajmi
Saad Najmi (Saadnajmi)
reviewed
Jun 30, 2022
View reviewed changes
Comment threadapps/android/package.json
Outdated

Comment threadpackage.json
Outdated

Comment threadpackages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts
Outdated

Comment threadpackages/utils/adapters/src/adapters.android.ts
Outdated

@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jun 30, 2022

Copy link


Copy Markdown

Collaborator
If you're feeling fancy, you could update it so that every package.json has an rnx-kit config and future version upgrades are a simple one-line rnx-dep-check --write. Totally not required though :)
@SaadnajmiSaad Najmi (Saadnajmi)
mentioned this pull request
Jun 30, 2022
 Closed

10 tasks
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Ruriko Araki (@rurikoaraki) Yeah I think we should, I tested the onPressIn/Out prop and it works on all platform. I've added it, thanks!
rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadapps/fluent-tester/src/FluentTester/FluentTester.tsx
Outdated

rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadpackage.json
@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
Minor note:

I think the test apps still specify "react-test-renderer": "17.0.1". That should probably be "17.0.2"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 22:03
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 12, 2022 22:30
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 23:12
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This PR causes this issue where Shadow is unable to pass the Jest tests due to an error "Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 13, 2022 20:34
@Dewsk
Andrew Dewar (Dewsk)
commented
Jul 13, 2022

Copy link


Copy Markdown

Collaborator
Nabil - great job here! We're really close to being ready to merge and this was a large cross-platform ask. I think we have some cool stories to tell about it and I've been really impressed with how diligently you've worked through all the tricky platform unique issues.
Dewsk
Andrew Dewar (Dewsk)
approved these changes
Jul 13, 2022
View reviewed changes
@DewskAndrew Dewar (Dewsk)
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to merge this!
@rurikoaraki
Ruriko Araki (rurikoaraki)
commented
Jul 14, 2022

Copy link


Copy Markdown

Collaborator
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 14, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@Dewsk
Andrew Dewar (Dewsk)
merged commit 155145b
into
microsoft:masterJul 14, 2022

This was referenced Jul 14, 2022

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@DewskAndrew Dewar (Dewsk)Dewsk approved these changes
@rurikoarakiRuriko Araki (rurikoaraki)rurikoaraki approved these changes
@SaadnajmiSaad Najmi (Saadnajmi)Saadnajmi approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@nabil-k@samuelfreiberg@Saadnajmi@rurikoaraki@Dewsk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
React Native 0.66 Update by nabil-k · Pull Request #1809 · microsoft/fluentui-react-native · GitHub
Skip to content
React Native 0.66 Update - #1809
Merged
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Jul 14, 2022
Merged
React Native 0.66 Update#1809
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Conversation
@nabil-k
@nabil-kNabil Khalil (nabil-k)
commented
Jun 30, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Platforms Impacted
  •  iOS
  •  macOS
  •  win32 (Office)
  •  windows
  •  android
This PR is based on the changes from #1511
Platform Status
  • Win32: Good, no known issues at the moment.
  • Windows: Good, no known issues at the moment.

    • It actually runs better than it's RN 0.64 counterpart. On RN 0.64 when switching pages you would get a render error that says Cannot redefine non-configurable property. However, after updating everything to RN 0.66, I haven't gotten that error at all.
  • MacOs: Good, no known issues at the moment.
  • iOS: Good, no known issues at the moment.
  • Android: Good, no known issues at the moment.
Description of Changes
These are just changes I've made to get further through the build process. This is just to help everyone be aware of some changes that have occurred between RN 0.64 and RN 0.66.
General
packages/utils/adapters/src/adapters

For RN 0.66 Typescript, two new props on TextProps have been added called onPressIn and onPressOut.
Windows
packages/theming/theming-utils/src/getCurrentAppearance.windows.ts

Removed !AppTheme.isAvailable, causes a type error.
Win32
packages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts

Removed declaring TurboModuleRegistry in a react native module.
Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered (when applicable):
  •  Automated Tests
  •  Documentation and examples
  •  Keyboard Accessibility
  •  Voiceover
  •  Internationalization and Right-to-left Layouts
Saad Najmi (Saadnajmi)and others
added 23 commits
March 11, 2022 11:53
@Saadnajmi
Update rnx-kit configurations
999917e
@Saadnajmi
yarn rnx-dep-check --write
2049874
@Saadnajmi
Remove workspace resolutions
86b8404
@Saadnajmi
Update React / React Native / React Native macOS/Windows/Win32 depend…
5509437
…encies
@Saadnajmi
Fix yarn build fallout
4a4f8e3
@Saadnajmi
Fix test fallout
6bd8f5f
@Saadnajmi
Update podfile locks
5f353e2
@Saadnajmi
Remove unnecessary dependency
821306c
@Saadnajmi
Change files
50af282
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
43f9d82
…native into 66-update
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
31d12be
…nto 66-update
@Saadnajmi
Remove alpha cli resolution
bc9bd2d
@Saadnajmi
rnx-dep-check --write
6c04e9c
@Saadnajmi
update lock
c0cb342
@Saadnajmi
update rex
0a6b31b
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
2af2dfe
…native into 66-update
@Saadnajmi
update lock
7a31b11
@Saadnajmi
update ios podfile
6bef378
@Saadnajmi
update macos podfile
570be15
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
e3420ad
…nto 66-update
@nabil-k
upgrade RN types to version 0.66
aefc1c4
@nabil-k
updated some components to 0.66 and renamed TurboModuleRegistry in ge…
a1348e0
…tThemingModule
@nabil-k
resolved type errors
70929e5
@nabil-k
Nabil Khalil (nabil-k)
requested a review
from a team
as a code ownerJune 30, 2022 02:00
@samuelfreiberg
Samuel Freiberg (samuelfreiberg)
commented
Jun 30, 2022

Copy link


Copy Markdown

Contributor
"This is not meant to be merged as it currently stands." I think we should make this a Draft PR if it's not meant to be merged and there's a lot of work left (just so the intent is clear).
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
June 30, 2022 04:13
Saadnajmi
Saad Najmi (Saadnajmi)
reviewed
Jun 30, 2022
View reviewed changes
Comment threadapps/android/package.json
Outdated

Comment threadpackage.json
Outdated

Comment threadpackages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts
Outdated

Comment threadpackages/utils/adapters/src/adapters.android.ts
Outdated

@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jun 30, 2022

Copy link


Copy Markdown

Collaborator
If you're feeling fancy, you could update it so that every package.json has an rnx-kit config and future version upgrades are a simple one-line rnx-dep-check --write. Totally not required though :)
@SaadnajmiSaad Najmi (Saadnajmi)
mentioned this pull request
Jun 30, 2022
 Closed

10 tasks
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Ruriko Araki (@rurikoaraki) Yeah I think we should, I tested the onPressIn/Out prop and it works on all platform. I've added it, thanks!
rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadapps/fluent-tester/src/FluentTester/FluentTester.tsx
Outdated

rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadpackage.json
@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
Minor note:

I think the test apps still specify "react-test-renderer": "17.0.1". That should probably be "17.0.2"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 22:03
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 12, 2022 22:30
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 23:12
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This PR causes this issue where Shadow is unable to pass the Jest tests due to an error "Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 13, 2022 20:34
@Dewsk
Andrew Dewar (Dewsk)
commented
Jul 13, 2022

Copy link


Copy Markdown

Collaborator
Nabil - great job here! We're really close to being ready to merge and this was a large cross-platform ask. I think we have some cool stories to tell about it and I've been really impressed with how diligently you've worked through all the tricky platform unique issues.
Dewsk
Andrew Dewar (Dewsk)
approved these changes
Jul 13, 2022
View reviewed changes
@DewskAndrew Dewar (Dewsk)
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to merge this!
@rurikoaraki
Ruriko Araki (rurikoaraki)
commented
Jul 14, 2022

Copy link


Copy Markdown

Collaborator
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 14, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@Dewsk
Andrew Dewar (Dewsk)
merged commit 155145b
into
microsoft:masterJul 14, 2022

This was referenced Jul 14, 2022

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@DewskAndrew Dewar (Dewsk)Dewsk approved these changes
@rurikoarakiRuriko Araki (rurikoaraki)rurikoaraki approved these changes
@SaadnajmiSaad Najmi (Saadnajmi)Saadnajmi approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@nabil-k@samuelfreiberg@Saadnajmi@rurikoaraki@Dewsk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
React Native 0.66 Update by nabil-k · Pull Request #1809 · microsoft/fluentui-react-native · GitHub
Skip to content
React Native 0.66 Update - #1809
Merged
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Jul 14, 2022
Merged
React Native 0.66 Update#1809
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Conversation
@nabil-k
@nabil-kNabil Khalil (nabil-k)
commented
Jun 30, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Platforms Impacted
  •  iOS
  •  macOS
  •  win32 (Office)
  •  windows
  •  android
This PR is based on the changes from #1511
Platform Status
  • Win32: Good, no known issues at the moment.
  • Windows: Good, no known issues at the moment.

    • It actually runs better than it's RN 0.64 counterpart. On RN 0.64 when switching pages you would get a render error that says Cannot redefine non-configurable property. However, after updating everything to RN 0.66, I haven't gotten that error at all.
  • MacOs: Good, no known issues at the moment.
  • iOS: Good, no known issues at the moment.
  • Android: Good, no known issues at the moment.
Description of Changes
These are just changes I've made to get further through the build process. This is just to help everyone be aware of some changes that have occurred between RN 0.64 and RN 0.66.
General
packages/utils/adapters/src/adapters

For RN 0.66 Typescript, two new props on TextProps have been added called onPressIn and onPressOut.
Windows
packages/theming/theming-utils/src/getCurrentAppearance.windows.ts

Removed !AppTheme.isAvailable, causes a type error.
Win32
packages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts

Removed declaring TurboModuleRegistry in a react native module.
Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered (when applicable):
  •  Automated Tests
  •  Documentation and examples
  •  Keyboard Accessibility
  •  Voiceover
  •  Internationalization and Right-to-left Layouts
Saad Najmi (Saadnajmi)and others
added 23 commits
March 11, 2022 11:53
@Saadnajmi
Update rnx-kit configurations
999917e
@Saadnajmi
yarn rnx-dep-check --write
2049874
@Saadnajmi
Remove workspace resolutions
86b8404
@Saadnajmi
Update React / React Native / React Native macOS/Windows/Win32 depend…
5509437
…encies
@Saadnajmi
Fix yarn build fallout
4a4f8e3
@Saadnajmi
Fix test fallout
6bd8f5f
@Saadnajmi
Update podfile locks
5f353e2
@Saadnajmi
Remove unnecessary dependency
821306c
@Saadnajmi
Change files
50af282
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
43f9d82
…native into 66-update
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
31d12be
…nto 66-update
@Saadnajmi
Remove alpha cli resolution
bc9bd2d
@Saadnajmi
rnx-dep-check --write
6c04e9c
@Saadnajmi
update lock
c0cb342
@Saadnajmi
update rex
0a6b31b
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
2af2dfe
…native into 66-update
@Saadnajmi
update lock
7a31b11
@Saadnajmi
update ios podfile
6bef378
@Saadnajmi
update macos podfile
570be15
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
e3420ad
…nto 66-update
@nabil-k
upgrade RN types to version 0.66
aefc1c4
@nabil-k
updated some components to 0.66 and renamed TurboModuleRegistry in ge…
a1348e0
…tThemingModule
@nabil-k
resolved type errors
70929e5
@nabil-k
Nabil Khalil (nabil-k)
requested a review
from a team
as a code ownerJune 30, 2022 02:00
@samuelfreiberg
Samuel Freiberg (samuelfreiberg)
commented
Jun 30, 2022

Copy link


Copy Markdown

Contributor
"This is not meant to be merged as it currently stands." I think we should make this a Draft PR if it's not meant to be merged and there's a lot of work left (just so the intent is clear).
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
June 30, 2022 04:13
Saadnajmi
Saad Najmi (Saadnajmi)
reviewed
Jun 30, 2022
View reviewed changes
Comment threadapps/android/package.json
Outdated

Comment threadpackage.json
Outdated

Comment threadpackages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts
Outdated

Comment threadpackages/utils/adapters/src/adapters.android.ts
Outdated

@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jun 30, 2022

Copy link


Copy Markdown

Collaborator
If you're feeling fancy, you could update it so that every package.json has an rnx-kit config and future version upgrades are a simple one-line rnx-dep-check --write. Totally not required though :)
@SaadnajmiSaad Najmi (Saadnajmi)
mentioned this pull request
Jun 30, 2022
 Closed

10 tasks
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Ruriko Araki (@rurikoaraki) Yeah I think we should, I tested the onPressIn/Out prop and it works on all platform. I've added it, thanks!
rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadapps/fluent-tester/src/FluentTester/FluentTester.tsx
Outdated

rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadpackage.json
@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
Minor note:

I think the test apps still specify "react-test-renderer": "17.0.1". That should probably be "17.0.2"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 22:03
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 12, 2022 22:30
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 23:12
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This PR causes this issue where Shadow is unable to pass the Jest tests due to an error "Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 13, 2022 20:34
@Dewsk
Andrew Dewar (Dewsk)
commented
Jul 13, 2022

Copy link


Copy Markdown

Collaborator
Nabil - great job here! We're really close to being ready to merge and this was a large cross-platform ask. I think we have some cool stories to tell about it and I've been really impressed with how diligently you've worked through all the tricky platform unique issues.
Dewsk
Andrew Dewar (Dewsk)
approved these changes
Jul 13, 2022
View reviewed changes
@DewskAndrew Dewar (Dewsk)
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to merge this!
@rurikoaraki
Ruriko Araki (rurikoaraki)
commented
Jul 14, 2022

Copy link


Copy Markdown

Collaborator
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 14, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@Dewsk
Andrew Dewar (Dewsk)
merged commit 155145b
into
microsoft:masterJul 14, 2022

This was referenced Jul 14, 2022

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@DewskAndrew Dewar (Dewsk)Dewsk approved these changes
@rurikoarakiRuriko Araki (rurikoaraki)rurikoaraki approved these changes
@SaadnajmiSaad Najmi (Saadnajmi)Saadnajmi approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@nabil-k@samuelfreiberg@Saadnajmi@rurikoaraki@Dewsk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
React Native 0.66 Update by nabil-k · Pull Request #1809 · microsoft/fluentui-react-native · GitHub
Skip to content
React Native 0.66 Update - #1809
Merged
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Jul 14, 2022
Merged
React Native 0.66 Update#1809
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Conversation
@nabil-k
@nabil-kNabil Khalil (nabil-k)
commented
Jun 30, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Platforms Impacted
  •  iOS
  •  macOS
  •  win32 (Office)
  •  windows
  •  android
This PR is based on the changes from #1511
Platform Status
  • Win32: Good, no known issues at the moment.
  • Windows: Good, no known issues at the moment.

    • It actually runs better than it's RN 0.64 counterpart. On RN 0.64 when switching pages you would get a render error that says Cannot redefine non-configurable property. However, after updating everything to RN 0.66, I haven't gotten that error at all.
  • MacOs: Good, no known issues at the moment.
  • iOS: Good, no known issues at the moment.
  • Android: Good, no known issues at the moment.
Description of Changes
These are just changes I've made to get further through the build process. This is just to help everyone be aware of some changes that have occurred between RN 0.64 and RN 0.66.
General
packages/utils/adapters/src/adapters

For RN 0.66 Typescript, two new props on TextProps have been added called onPressIn and onPressOut.
Windows
packages/theming/theming-utils/src/getCurrentAppearance.windows.ts

Removed !AppTheme.isAvailable, causes a type error.
Win32
packages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts

Removed declaring TurboModuleRegistry in a react native module.
Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered (when applicable):
  •  Automated Tests
  •  Documentation and examples
  •  Keyboard Accessibility
  •  Voiceover
  •  Internationalization and Right-to-left Layouts
Saad Najmi (Saadnajmi)and others
added 23 commits
March 11, 2022 11:53
@Saadnajmi
Update rnx-kit configurations
999917e
@Saadnajmi
yarn rnx-dep-check --write
2049874
@Saadnajmi
Remove workspace resolutions
86b8404
@Saadnajmi
Update React / React Native / React Native macOS/Windows/Win32 depend…
5509437
…encies
@Saadnajmi
Fix yarn build fallout
4a4f8e3
@Saadnajmi
Fix test fallout
6bd8f5f
@Saadnajmi
Update podfile locks
5f353e2
@Saadnajmi
Remove unnecessary dependency
821306c
@Saadnajmi
Change files
50af282
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
43f9d82
…native into 66-update
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
31d12be
…nto 66-update
@Saadnajmi
Remove alpha cli resolution
bc9bd2d
@Saadnajmi
rnx-dep-check --write
6c04e9c
@Saadnajmi
update lock
c0cb342
@Saadnajmi
update rex
0a6b31b
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
2af2dfe
…native into 66-update
@Saadnajmi
update lock
7a31b11
@Saadnajmi
update ios podfile
6bef378
@Saadnajmi
update macos podfile
570be15
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
e3420ad
…nto 66-update
@nabil-k
upgrade RN types to version 0.66
aefc1c4
@nabil-k
updated some components to 0.66 and renamed TurboModuleRegistry in ge…
a1348e0
…tThemingModule
@nabil-k
resolved type errors
70929e5
@nabil-k
Nabil Khalil (nabil-k)
requested a review
from a team
as a code ownerJune 30, 2022 02:00
@samuelfreiberg
Samuel Freiberg (samuelfreiberg)
commented
Jun 30, 2022

Copy link


Copy Markdown

Contributor
"This is not meant to be merged as it currently stands." I think we should make this a Draft PR if it's not meant to be merged and there's a lot of work left (just so the intent is clear).
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
June 30, 2022 04:13
Saadnajmi
Saad Najmi (Saadnajmi)
reviewed
Jun 30, 2022
View reviewed changes
Comment threadapps/android/package.json
Outdated

Comment threadpackage.json
Outdated

Comment threadpackages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts
Outdated

Comment threadpackages/utils/adapters/src/adapters.android.ts
Outdated

@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jun 30, 2022

Copy link


Copy Markdown

Collaborator
If you're feeling fancy, you could update it so that every package.json has an rnx-kit config and future version upgrades are a simple one-line rnx-dep-check --write. Totally not required though :)
@SaadnajmiSaad Najmi (Saadnajmi)
mentioned this pull request
Jun 30, 2022
 Closed

10 tasks
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Ruriko Araki (@rurikoaraki) Yeah I think we should, I tested the onPressIn/Out prop and it works on all platform. I've added it, thanks!
rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadapps/fluent-tester/src/FluentTester/FluentTester.tsx
Outdated

rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadpackage.json
@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
Minor note:

I think the test apps still specify "react-test-renderer": "17.0.1". That should probably be "17.0.2"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 22:03
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 12, 2022 22:30
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 23:12
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This PR causes this issue where Shadow is unable to pass the Jest tests due to an error "Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 13, 2022 20:34
@Dewsk
Andrew Dewar (Dewsk)
commented
Jul 13, 2022

Copy link


Copy Markdown

Collaborator
Nabil - great job here! We're really close to being ready to merge and this was a large cross-platform ask. I think we have some cool stories to tell about it and I've been really impressed with how diligently you've worked through all the tricky platform unique issues.
Dewsk
Andrew Dewar (Dewsk)
approved these changes
Jul 13, 2022
View reviewed changes
@DewskAndrew Dewar (Dewsk)
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to merge this!
@rurikoaraki
Ruriko Araki (rurikoaraki)
commented
Jul 14, 2022

Copy link


Copy Markdown

Collaborator
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 14, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@Dewsk
Andrew Dewar (Dewsk)
merged commit 155145b
into
microsoft:masterJul 14, 2022

This was referenced Jul 14, 2022

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@DewskAndrew Dewar (Dewsk)Dewsk approved these changes
@rurikoarakiRuriko Araki (rurikoaraki)rurikoaraki approved these changes
@SaadnajmiSaad Najmi (Saadnajmi)Saadnajmi approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@nabil-k@samuelfreiberg@Saadnajmi@rurikoaraki@Dewsk

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
React Native 0.66 Update by nabil-k · Pull Request #1809 · microsoft/fluentui-react-native · GitHub
Skip to content
React Native 0.66 Update - #1809
Merged
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Jul 14, 2022
Merged
React Native 0.66 Update#1809
Andrew Dewar (Dewsk) merged 66 commits into
microsoft:masterfrom 
nabil-k:66-update
Conversation
@nabil-k
@nabil-kNabil Khalil (nabil-k)
commented
Jun 30, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
Platforms Impacted
  •  iOS
  •  macOS
  •  win32 (Office)
  •  windows
  •  android
This PR is based on the changes from #1511
Platform Status
  • Win32: Good, no known issues at the moment.
  • Windows: Good, no known issues at the moment.

    • It actually runs better than it's RN 0.64 counterpart. On RN 0.64 when switching pages you would get a render error that says Cannot redefine non-configurable property. However, after updating everything to RN 0.66, I haven't gotten that error at all.
  • MacOs: Good, no known issues at the moment.
  • iOS: Good, no known issues at the moment.
  • Android: Good, no known issues at the moment.
Description of Changes
These are just changes I've made to get further through the build process. This is just to help everyone be aware of some changes that have occurred between RN 0.64 and RN 0.66.
General
packages/utils/adapters/src/adapters

For RN 0.66 Typescript, two new props on TextProps have been added called onPressIn and onPressOut.
Windows
packages/theming/theming-utils/src/getCurrentAppearance.windows.ts

Removed !AppTheme.isAvailable, causes a type error.
Win32
packages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts

Removed declaring TurboModuleRegistry in a react native module.
Verification
(how the change was tested, including both manual and automated tests)
Pull request checklist
This PR has considered (when applicable):
  •  Automated Tests
  •  Documentation and examples
  •  Keyboard Accessibility
  •  Voiceover
  •  Internationalization and Right-to-left Layouts
Saad Najmi (Saadnajmi)and others
added 23 commits
March 11, 2022 11:53
@Saadnajmi
Update rnx-kit configurations
999917e
@Saadnajmi
yarn rnx-dep-check --write
2049874
@Saadnajmi
Remove workspace resolutions
86b8404
@Saadnajmi
Update React / React Native / React Native macOS/Windows/Win32 depend…
5509437
…encies
@Saadnajmi
Fix yarn build fallout
4a4f8e3
@Saadnajmi
Fix test fallout
6bd8f5f
@Saadnajmi
Update podfile locks
5f353e2
@Saadnajmi
Remove unnecessary dependency
821306c
@Saadnajmi
Change files
50af282
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
43f9d82
…native into 66-update
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
31d12be
…nto 66-update
@Saadnajmi
Remove alpha cli resolution
bc9bd2d
@Saadnajmi
rnx-dep-check --write
6c04e9c
@Saadnajmi
update lock
c0cb342
@Saadnajmi
update rex
0a6b31b
@Saadnajmi
Merge branch 'master' ofhttps://github.com/microsoft/fluentui-react-…
2af2dfe
…native into 66-update
@Saadnajmi
update lock
7a31b11
@Saadnajmi
update ios podfile
6bef378
@Saadnajmi
update macos podfile
570be15
@Saadnajmi
Merge branch 'master' of github.com:microsoft/fluentui-react-native i…
e3420ad
…nto 66-update
@nabil-k
upgrade RN types to version 0.66
aefc1c4
@nabil-k
updated some components to 0.66 and renamed TurboModuleRegistry in ge…
a1348e0
…tThemingModule
@nabil-k
resolved type errors
70929e5
@nabil-k
Nabil Khalil (nabil-k)
requested a review
from a team
as a code ownerJune 30, 2022 02:00
@samuelfreiberg
Samuel Freiberg (samuelfreiberg)
commented
Jun 30, 2022

Copy link


Copy Markdown

Contributor
"This is not meant to be merged as it currently stands." I think we should make this a Draft PR if it's not meant to be merged and there's a lot of work left (just so the intent is clear).
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
June 30, 2022 04:13
Saadnajmi
Saad Najmi (Saadnajmi)
reviewed
Jun 30, 2022
View reviewed changes
Comment threadapps/android/package.json
Outdated

Comment threadpackage.json
Outdated

Comment threadpackages/theming/win32-theme/src/NativeModule/getThemingModule.native.ts
Outdated

Comment threadpackages/utils/adapters/src/adapters.android.ts
Outdated

@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jun 30, 2022

Copy link


Copy Markdown

Collaborator
If you're feeling fancy, you could update it so that every package.json has an rnx-kit config and future version upgrades are a simple one-line rnx-dep-check --write. Totally not required though :)
@SaadnajmiSaad Najmi (Saadnajmi)
mentioned this pull request
Jun 30, 2022
 Closed

10 tasks
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Ruriko Araki (@rurikoaraki) Yeah I think we should, I tested the onPressIn/Out prop and it works on all platform. I've added it, thanks!
rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadapps/fluent-tester/src/FluentTester/FluentTester.tsx
Outdated

rurikoaraki
Ruriko Araki (rurikoaraki)
reviewed
Jul 12, 2022
View reviewed changes
Comment threadpackage.json
@Saadnajmi
Saad Najmi (Saadnajmi)
commented
Jul 12, 2022•

edited

Loading

Copy link


Copy Markdown

Collaborator
Minor note:

I think the test apps still specify "react-test-renderer": "17.0.1". That should probably be "17.0.2"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 22:03
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 12, 2022 22:30
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 12, 2022 23:12
@nabil-k
Nabil Khalil (nabil-k)
commented
Jul 12, 2022

Copy link


Copy Markdown

ContributorAuthor
This PR causes this issue where Shadow is unable to pass the Jest tests due to an error "Invariant Violation: __fbBatchedBridgeConfig is not set, cannot invoke native modules"
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as draft
July 13, 2022 16:28
@nabil-k
Nabil Khalil (nabil-k)
marked this pull request as ready for review
July 13, 2022 20:34
@Dewsk
Andrew Dewar (Dewsk)
commented
Jul 13, 2022

Copy link


Copy Markdown

Collaborator
Nabil - great job here! We're really close to being ready to merge and this was a large cross-platform ask. I think we have some cool stories to tell about it and I've been really impressed with how diligently you've worked through all the tricky platform unique issues.
Dewsk
Andrew Dewar (Dewsk)
approved these changes
Jul 13, 2022
View reviewed changes
@DewskAndrew Dewar (Dewsk)
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are good to merge this!
@rurikoaraki
Ruriko Araki (rurikoaraki)
commented
Jul 14, 2022

Copy link


Copy Markdown

Collaborator
/azp run
@azure-pipelines
azure-pipelinesBot
commented
Jul 14, 2022

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).
@Dewsk
Andrew Dewar (Dewsk)
merged commit 155145b
into
microsoft:masterJul 14, 2022

This was referenced Jul 14, 2022

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@DewskAndrew Dewar (Dewsk)Dewsk approved these changes
@rurikoarakiRuriko Araki (rurikoaraki)rurikoaraki approved these changes
@SaadnajmiSaad Najmi (Saadnajmi)Saadnajmi approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@nabil-k@samuelfreiberg@Saadnajmi@rurikoaraki@Dewsk