test: migrate all v9 libraries to use new conformance setup which improves test execution by approx 46% - #27669
Merged
Martin Hochel (Hotell) merged 1 commit intoApr 27, 2023
Conversation
11 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b44ffc3:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 839 | 850 | 5000 | |
| Button | mount | 452 | 440 | 5000 | |
| Field | mount | 1466 | 1515 | 5000 | |
| FluentProvider | mount | 1078 | 1103 | 5000 | |
| FluentProviderWithTheme | mount | 131 | 143 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 131 | 121 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 123 | 134 | 10 | |
| InfoButton | mount | 26 | 29 | 5000 | |
| MakeStyles | mount | 1344 | 1308 | 50000 | |
| Persona | mount | 2479 | 2433 | 5000 | |
| SpinButton | mount | 1943 | 1877 | 5000 |
Asset size changesUnable to find bundle size details for Baseline commit: 232c4b3 Possible causes
Recommendations
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ChatWithPopoverPerf.default | 265 | 232 | 1.14:1 |
| AvatarMinimalPerf.default | 144 | 131 | 1.1:1 |
| LoaderMinimalPerf.default | 256 | 236 | 1.08:1 |
| PortalMinimalPerf.default | 122 | 113 | 1.08:1 |
| TreeWith60ListItems.default | 120 | 113 | 1.06:1 |
| CarouselMinimalPerf.default | 349 | 333 | 1.05:1 |
| ListMinimalPerf.default | 393 | 379 | 1.04:1 |
| SegmentMinimalPerf.default | 260 | 250 | 1.04:1 |
| ToolbarMinimalPerf.default | 686 | 658 | 1.04:1 |
| ButtonSlotsPerf.default | 407 | 395 | 1.03:1 |
| CardMinimalPerf.default | 386 | 375 | 1.03:1 |
| CheckboxMinimalPerf.default | 1600 | 1553 | 1.03:1 |
| DividerMinimalPerf.default | 261 | 253 | 1.03:1 |
| InputMinimalPerf.default | 732 | 711 | 1.03:1 |
| LayoutMinimalPerf.default | 272 | 264 | 1.03:1 |
| MenuMinimalPerf.default | 625 | 609 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1279 | 1242 | 1.03:1 |
| AttachmentMinimalPerf.default | 99 | 97 | 1.02:1 |
| AttachmentSlotsPerf.default | 839 | 822 | 1.02:1 |
| HeaderSlotsPerf.default | 575 | 562 | 1.02:1 |
| RadioGroupMinimalPerf.default | 337 | 330 | 1.02:1 |
| TextAreaMinimalPerf.default | 348 | 340 | 1.02:1 |
| TooltipMinimalPerf.default | 1663 | 1630 | 1.02:1 |
| AnimationMinimalPerf.default | 373 | 368 | 1.01:1 |
| ChatMinimalPerf.default | 539 | 533 | 1.01:1 |
| EmbedMinimalPerf.default | 2414 | 2383 | 1.01:1 |
| GridMinimalPerf.default | 250 | 247 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 915 | 903 | 1.01:1 |
| PopupMinimalPerf.default | 454 | 451 | 1.01:1 |
| ProviderMergeThemesPerf.default | 978 | 971 | 1.01:1 |
| ProviderMinimalPerf.default | 276 | 273 | 1.01:1 |
| ReactionMinimalPerf.default | 269 | 267 | 1.01:1 |
| SkeletonMinimalPerf.default | 257 | 254 | 1.01:1 |
| StatusMinimalPerf.default | 504 | 501 | 1.01:1 |
| TableManyItemsPerf.default | 1442 | 1425 | 1.01:1 |
| TreeMinimalPerf.default | 600 | 595 | 1.01:1 |
| AccordionMinimalPerf.default | 105 | 105 | 1:1 |
| DatepickerMinimalPerf.default | 4852 | 4873 | 1:1 |
| DialogMinimalPerf.default | 575 | 575 | 1:1 |
| HeaderMinimalPerf.default | 261 | 262 | 1:1 |
| LabelMinimalPerf.default | 278 | 278 | 1:1 |
| ListCommonPerf.default | 486 | 486 | 1:1 |
| ListNestedPerf.default | 410 | 410 | 1:1 |
| RosterPerf.default | 1839 | 1839 | 1:1 |
| SliderMinimalPerf.default | 916 | 914 | 1:1 |
| IconMinimalPerf.default | 460 | 459 | 1:1 |
| TableMinimalPerf.default | 300 | 299 | 1:1 |
| CustomToolbarPrototype.default | 1918 | 1915 | 1:1 |
| ButtonOverridesMissPerf.default | 827 | 835 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 194 | 196 | 0.99:1 |
| DropdownManyItemsPerf.default | 493 | 496 | 0.99:1 |
| DropdownMinimalPerf.default | 1819 | 1832 | 0.99:1 |
| FormMinimalPerf.default | 281 | 284 | 0.99:1 |
| SplitButtonMinimalPerf.default | 3028 | 3047 | 0.99:1 |
| VideoMinimalPerf.default | 517 | 521 | 0.99:1 |
| BoxMinimalPerf.default | 252 | 256 | 0.98:1 |
| FlexMinimalPerf.default | 203 | 207 | 0.98:1 |
| ImageMinimalPerf.default | 281 | 288 | 0.98:1 |
| ListWith60ListItems.default | 464 | 474 | 0.98:1 |
| TextMinimalPerf.default | 248 | 254 | 0.98:1 |
| ButtonMinimalPerf.default | 106 | 109 | 0.97:1 |
| RefMinimalPerf.default | 136 | 144 | 0.94:1 |
| AlertMinimalPerf.default | 189 | 204 | 0.93:1 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 815 | 858 | 5000 | |
| Breadcrumb | mount | 2288 | 2254 | 1000 | |
| Checkbox | mount | 2134 | 2201 | 5000 | |
| CheckboxBase | mount | 1886 | 2020 | 5000 | |
| ChoiceGroup | mount | 3684 | 3791 | 5000 | |
| ComboBox | mount | 865 | 859 | 1000 | |
| CommandBar | mount | 8212 | 8213 | 1000 | |
| ContextualMenu | mount | 18051 | 18309 | 1000 | |
| DefaultButton | mount | 1063 | 1062 | 5000 | |
| DetailsRow | mount | 2896 | 3065 | 5000 | |
| DetailsRowFast | mount | 2880 | 2941 | 5000 | |
| DetailsRowNoStyles | mount | 2749 | 2877 | 5000 | |
| Dialog | mount | 3384 | 3571 | 1000 | |
| DocumentCardTitle | mount | 313 | 317 | 1000 | |
| Dropdown | mount | 2569 | 2562 | 5000 | |
| FocusTrapZone | mount | 1515 | 1529 | 5000 | |
| FocusZone | mount | 1467 | 1460 | 5000 | |
| GroupedList | mount | 49819 | 57661 | 2 | |
| GroupedList | virtual-rerender | 21954 | 24059 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 73994 | 74859 | 2 | |
| GroupedListV2 | mount | 333 | 329 | 2 | |
| GroupedListV2 | virtual-rerender | 304 | 302 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 332 | 322 | 2 | |
| IconButton | mount | 1433 | 1408 | 5000 | |
| Label | mount | 463 | 495 | 5000 | |
| Layer | mount | 3729 | 3654 | 5000 | |
| Link | mount | 538 | 538 | 5000 | |
| MenuButton | mount | 1243 | 1245 | 5000 | |
| MessageBar | mount | 27703 | 28017 | 5000 | |
| Nav | mount | 2559 | 2527 | 1000 | |
| OverflowSet | mount | 989 | 1133 | 5000 | |
| Panel | mount | 2264 | 2242 | 1000 | |
| Persona | mount | 970 | 973 | 1000 | |
| Pivot | mount | 1218 | 1218 | 1000 | |
| PrimaryButton | mount | 1101 | 1125 | 5000 | |
| Rating | mount | 5766 | 5828 | 5000 | |
| SearchBox | mount | 1165 | 1145 | 5000 | |
| Shimmer | mount | 2391 | 2463 | 5000 | |
| Slider | mount | 1741 | 1857 | 5000 | |
| SpinButton | mount | 3843 | 3734 | 5000 | |
| Spinner | mount | 524 | 545 | 5000 | |
| SplitButton | mount | 2423 | 2442 | 5000 | |
| Stack | mount | 534 | 532 | 5000 | |
| StackWithIntrinsicChildren | mount | 1155 | 1151 | 5000 | |
| StackWithTextChildren | mount | 3325 | 3460 | 5000 | |
| SwatchColorPicker | mount | 8148 | 8225 | 5000 | |
| TagPicker | mount | 1975 | 1974 | 5000 | |
| Text | mount | 515 | 494 | 5000 | |
| TextField | mount | 1225 | 1185 | 5000 | |
| ThemeProvider | mount | 1129 | 1180 | 5000 | |
| ThemeProvider | virtual-rerender | 806 | 787 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1745 | 1731 | 5000 | |
| Toggle | mount | 785 | 799 | 5000 | |
| buttonNative | mount | 290 | 286 | 5000 |
This was referenced Apr 25, 2023
…roves test execution by approx 46%
Martin Hochel (Hotell)
force-pushed
the
hotell/build/faster-ci/conformance-tests-fix-3
branch
from
April 26, 2023 12:33
f6d4175 to
b44ffc3
Compare
Martin Hochel (Hotell)
marked this pull request as ready for review
April 26, 2023 15:59
Sean Monahan (spmonahan)
approved these changes
Apr 26, 2023
ling1726
approved these changes
Apr 26, 2023
Micah Godbolt (micahgodbolt)
approved these changes
Apr 26, 2023
Makoto Morimoto (khmakoto)
approved these changes
Apr 26, 2023
Tristan Watanabe (TristanWatanabe)
approved these changes
Apr 26, 2023
Ben Howell (behowell)
approved these changes
Apr 26, 2023
Tudor Popa (tudorpopams)
approved these changes
Apr 27, 2023
Martin Hochel (Hotell)
deleted the
hotell/build/faster-ci/conformance-tests-fix-3
branch
April 27, 2023 09:46
Marcos Moura (marcosmoura)
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 27, 2023
* master: chore: enforce files naming to use .styles.ts [cxe-prg files] (microsoft#27707) chore: migrate to NodeJS v16 (microsoft#27711) remove react-avatar-context package (microsoft#27709) test: migrate all v9 libraries to use new conformance setup which improves test execution by approx 46% (microsoft#27669) chore: Add caret to react-datepicker-compat dependencies (microsoft#27671) test(fluentui/react): fix initial global leaks that were causing OOM issues (microsoft#27661) chore(react-utilities): simplifies useControllableState hook internals (microsoft#27702) chore: enforce files naming to use .styles.ts (microsoft#27698) feat: adds lazy loading example (microsoft#27587) feat: react-combobox space conditionally inserts character when freeform is true (microsoft#27025) chore(react-tree): updates useOpenItemsState internals (microsoft#27697) feat(tools): add conformance setup migration to migrate-converged-pkg generator (microsoft#27668) test: use `isolatedModules` for all ts-jest configs to lower memory footprint on CI (microsoft#27670) chore: bump @griffel/eslint-plugin & enable @griffel/hook-naming (microsoft#27687) feat(react-tree): makes useFlatTree generic (microsoft#27682) Enable export to codepen for charting library (microsoft#27539) Overflow: added useOverflowCount to exports (microsoft#27678) fix: Menu should not steal focus on re-render (microsoft#27688) feat(react-conformance): add new TS config api to be able to specify configName and configDir (microsoft#27664)
Marcos Moura (marcosmoura)
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Apr 27, 2023
* feat/drawer-components: (28 commits) docs: update API feat: add style overrides for upcoming drawer components feat: add support to override drawer styles fix: prevent elements from stretching chore: upgrade devcontainer node version to 16 (microsoft#27716) fix: rename styles file to use the newer naming conventions test: add cypress tests for scroll positions chore: enforce files naming to use .styles.ts [cxe-prg files] (microsoft#27707) feat: add support to override drawer body styles chore: migrate to NodeJS v16 (microsoft#27711) remove react-avatar-context package (microsoft#27709) test: migrate all v9 libraries to use new conformance setup which improves test execution by approx 46% (microsoft#27669) chore: Add caret to react-datepicker-compat dependencies (microsoft#27671) test(fluentui/react): fix initial global leaks that were causing OOM issues (microsoft#27661) chore(react-utilities): simplifies useControllableState hook internals (microsoft#27702) chore: enforce files naming to use .styles.ts (microsoft#27698) feat: adds lazy loading example (microsoft#27587) feat: react-combobox space conditionally inserts character when freeform is true (microsoft#27025) chore(react-tree): updates useOpenItemsState internals (microsoft#27697) feat(tools): add conformance setup migration to migrate-converged-pkg generator (microsoft#27668) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
All v9 packages use new conformance API. packages were migrated automatically via
nx workspace-generator migrate-converged-pkg --allRelated Issue(s)