Uh oh!
There was an error while loading. Please reload this page.
fix: Forward headless Toaster default options - #36633
Merged
Dmytro Kirpa (dmytrokirpa) merged 3 commits intoAug 27, 2026
Merged
Conversation
Forward Toaster-level defaults to the shared toast state, including limit and timer behavior. Add regression coverage for limiting rendered toasts and propagating default options.
📊 Bundle size report
Unchanged fixtures
|
Pull request demo site: URL |
Dmytro Kirpa (dmytrokirpa)
marked this pull request as ready for review
August 26, 2026 09:45
Dmytro Kirpa (dmytrokirpa)
requested review from
Martin Hochel (Hotell), Paul Mardling (PaulGMardling) and Victor Genaev (mainframev)
and
a balanced review from CopilotAugust 26, 2026 09:45
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes headless Toaster option forwarding to align with shared toast state behavior.
Changes:
- Forwards shared defaults and
limitwhile keepingoffsetrender-only. - Adds regression tests for limits and default options.
- Adds a patch change file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
useToaster.tsx | Forwards Toaster defaults correctly. |
Toaster.test.tsx | Tests limits and option propagation. |
| Change file | Records the patch release. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Paul Mardling (PaulGMardling)
approved these changes
Aug 26, 2026
Paul Mardling (PaulGMardling)
left a comment
Contributor
There was a problem hiding this comment.
Looks good, simple fix
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Dmytro Kirpa (dmytrokirpa)
requested review from
Martin Hochel (Hotell) and Victor Genaev (mainframev)
and removed request for
Martin Hochel (Hotell) and Victor Genaev (mainframev)August 26, 2026 14:37
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The headless
Toasteraccepted shared default options in its public props, but did not forwardlimit,position,timeout,pauseOnWindowBlur, orpriorityto toast state. It also forcedpauseOnHovertotrueand passed render-onlyoffsetinto toast state.New Behavior
The headless
Toasterforwards all shared toast defaults to the underlying state hook, includinglimit, and respects the configuredpauseOnHovervalue.offsetremains render-only.Regression tests cover limiting rendered toasts and propagating Toaster-level defaults to dispatched toasts.
Related Issue(s)
Validation
yarn nx run react-headless-components-preview:test --runTestsByPath src/components/Toast/Toaster/Toaster.test.tsx --runInBand(10/10 tests passed)yarn nx run react-headless-components-preview:lintyarn beachball check