Skip to content

Fix all go installations in the CI to the same version - #1557

Merged
Kathryn Baldauf (katiewasnothere) merged 3 commits into
release/0.9from
kabaldau/golang_fixed_release_0.9
Oct 31, 2022
Merged

Fix all go installations in the CI to the same version#1557
Kathryn Baldauf (katiewasnothere) merged 3 commits into
release/0.9from
kabaldau/golang_fixed_release_0.9

Conversation

@katiewasnothere

@katiewasnothereKathryn Baldauf (katiewasnothere) commented Oct 31, 2022

Copy link
Copy Markdown

Addresses CI build break in #1554 that was caused by the pipeline automatically choosing golang 1.19. Instead, use golang 1.18.x.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

@katiewasnothere

Copy link
Copy Markdown
Author

Kevin Parsons (@kevpar) PTAL

@kevpar

Copy link
Copy Markdown
Member

1.17 is out of support, can we set this to at least 1.18?

Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@katiewasnothere

Copy link
Copy Markdown
Author

Kevin Parsons (@kevpar) Updated to 1.18.x

Kathryn Baldauf added 2 commits October 31, 2022 15:23
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@katiewasnothere

Copy link
Copy Markdown
Author

Kevin Parsons (@kevpar) PTAL when you can, finally got the linter to work :P

@kevparKevin Parsons (kevpar) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katiewasnothere
Kathryn Baldauf (katiewasnothere) deleted the kabaldau/golang_fixed_release_0.9 branch October 31, 2022 23:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@katiewasnothere@kevpar