Uh oh!
There was an error while loading. Please reload this page.
Add logic to cleanup the oci bundle root dir on container delete - #1597
Merged
Kathryn Baldauf (katiewasnothere) merged 1 commit intoJan 17, 2023
Conversation
Kathryn Baldauf (katiewasnothere)
requested a review
from a team
as a code ownerDecember 5, 2022 20:58
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
Kathryn Baldauf (katiewasnothere)force-pushed
the
kabaldau/cleanup_shared_scratch_root_dir
branch
from
December 5, 2022 21:03
59e6f21 to
b74c09eCompareMaksim An (anmaxvl)
approved these changes
Dec 12, 2022
Hamza El-Saawy (helsaawy)
approved these changes
Jan 12, 2023
Kathryn Baldauf (katiewasnothere)
deleted the
kabaldau/cleanup_shared_scratch_root_dir
branch
January 17, 2023 19:39
Kathryn Baldauf (katiewasnothere) pushed a commit
to katiewasnothere/hcsshim
that referenced
this pull request
Feb 10, 2023
Prince Pereira (princepereira) pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
…up_shared_scratch_root_dir Add logic to cleanup the oci bundle root dir on container delete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a shared scratch scenario where the scratch directory is cleaned up on container delete, but since the container's root directory is in a different location, the root directory is never cleaned up. Be sure to clean up both the scratch and root directories regardless of whether shared scratch is set.
Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com