Remove open-coding of ParentLayerPathsFlag

[Paul "TBBle" Hampson (TBBle)]

containerd/mount.Mount provides an API for this now, although in one case we have to create an instance of that from the protobuf-marshelled types.Mount.

Something I stumbled across while poking at the containerd image store support for Windows in moby.

[Paul "TBBle" Hampson (TBBle)]

What is test-windows (windows-2022)'s "Test repo" step doing, that sometimes it passes in 3 minutes, but usually it runs for half an hour with no logs and then gets a runner-disconnection error? It's been happening on-and-off for a few weeks, and no particular changes jumped out at me in the commit log. (Although apparently such failure is considered a CI pass usually, so maybe it's been happening for longer than that.)

[Hamza El-Saawy (helsaawy)]

What is test-windows (windows-2022)'s "Test repo" step doing, that sometimes it passes in 3 minutes, but usually it runs for half an hour with no logs and then gets a runner-disconnection error? It's been happening on-and-off for a few weeks, and no particular changes jumped out at me in the commit log. (Although apparently such failure is considered a CI pass usually, so maybe it's been happening for longer than that.)

It's running the repo tests; from what I was able to track down, GitHub is improperly enabling CIMFS in the runners, causing our tests (https://github.com/microsoft/hcsshim/blob/main/pkg/cimfs/cim_test.go) to crash the VM.

[Amit Barve (ambarve)]

What is test-windows (windows-2022)'s "Test repo" step doing, that sometimes it passes in 3 minutes, but usually it runs for half an hour with no logs and then gets a runner-disconnection error? It's been happening on-and-off for a few weeks, and no particular changes jumped out at me in the commit log. (Although apparently such failure is considered a CI pass usually, so maybe it's been happening for longer than that.)

It's running the repo tests; from what I was able to track down, GitHub is improperly enabling CIMFS in the runners, causing our tests (https://github.com/microsoft/hcsshim/blob/main/pkg/cimfs/cim_test.go) to crash the VM.

I wouldn't say Github is improperly enabling CIMFS. The host OS version that Github uses for test runners doesn't have full CIMFS support so running tests on those is causing the crash. I will update the tests to not run on these versions.