Uh oh!
There was an error while loading. Please reload this page.
added LCOW Builder to generate final HCS document from annotations and options - #2616
Merged
Harsh Rawat (rawahars) merged 2 commits intoMar 10, 2026
Merged
Conversation
Harsh Rawat (rawahars)force-pushed
the
lcow_sandbox_spec
branch
4 times, most recently
from
March 7, 2026 08:42
6414010 to
363b159CompareJustin (jterry75)
approved these changes
Mar 9, 2026
Harsh Rawat (rawahars)force-pushed
the
lcow_sandbox_spec
branch
2 times, most recently
from
March 10, 2026 19:19
8daf903 to
010ce3fCompareSigned-off-by: Harsh Rawat <harshrawat@microsoft.com>
Harsh Rawat (rawahars)force-pushed
the
lcow_sandbox_spec
branch
from
March 10, 2026 19:32
010ce3f to
9fa8f1bCompareJustin (jterry75)
approved these changes
Mar 10, 2026
Hamza El-Saawy (helsaawy)
approved these changes
Mar 10, 2026
This commit adds a lcow builder for `containerd-shim-lcow-v1` shim. This package encapsulates the business logic to parse the annotations + devices + runhcs options into the final HCS document which will be used by the shim to create UVMs via HCS. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
Harsh Rawat (rawahars)force-pushed
the
lcow_sandbox_spec
branch
from
March 10, 2026 20:53
9fa8f1b to
06e10d9CompareJustin (jterry75)
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces the
LCOW Builderadding functionality for parsing and generating the final HCS document for LCOW scenarios. The changes provide detailed logic for handling cpu options, memory options, boot options, confidential computing settings, and device configurations, all driven by annotations and runtime options.This package consolidates the LCOW logic present in old shim from various sources into a single package.
The HCS document generated from this package can be used to create an LCOW. No additional parsing would be required in the shim.
Note: This PR can only be merged after #2612
Documentation:
Introduced a comprehensive package-level doc comment in
doc.godescribing the purpose, entry points, and configuration areas handled by thelcowpackage.Testing
Added unit tests for the parsing logic testing.