Uh oh!
There was an error while loading. Please reload this page.
Adding exported functions for few of the windows errors. - #26
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands hcn’s Windows error-classification helpers by adding additional exported predicates for common HCN HRESULTs and introduces a unit test to validate these predicates (including behavior through fmt.Errorf("%w", ...) wrapping).
Changes:
- Add new
ErrorCodeconstants for additional HCN error codes (network/endpoint/port not found, invalid IP). - Add new exported
Is*helper functions that classifyHcnErrorinstances by those codes. - Add a Windows-only unit test covering the helper predicates (including wrapped errors).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
hcn/hcnerrors.go | Adds new HCN error-code constants and new exported Is* helper predicates. |
hcn/hcnerrors_unit_test.go | Adds Windows-only unit tests for the new (and existing) error-classification helpers, including wrapped-error cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6fb6547 to
3d3a0a0CompareThere was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
3d3a0a0 to
c71d4b7CompareThere was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
c71d4b7 to
c4f3a72Comparec4f3a72 to
f508ba8ComparePrince Pereira (princepereira)
commented
Mar 12, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Uh oh!
There was an error while loading. Please reload this page.
Prince Pereira (@princepereira) I've opened a new pull request, #27, to work on those changes. Once the pull request is ready, I'll request review from you. |
c87230d to
4a3ae11Compare89cd4d9 to
d5983c1Compared5983c1 to
a463f57CompareUh oh!
There was an error while loading. Please reload this page.
Added exported functions to validate few of the windows errors.