During the review of #30 , menuet correctly observed there is existing code that violated Core Guidelines E.14. That should have been caught before it was checked in. Upon further logic inspection, it looks like that the Reader constructor was detecting too late an erroneous condition. Move that detection earlier, at the very minimum, at the site of the Reader object construction.
During the review of #30 , menuet correctly observed there is existing code that violated Core Guidelines E.14. That should have been caught before it was checked in. Upon further logic inspection, it looks like that the
Readerconstructor was detecting too late an erroneous condition. Move that detection earlier, at the very minimum, at the site of theReaderobject construction.