Skip to content

Macro guard #include of standard library - #104

Closed
David Hunter (davidhunter22) wants to merge 2 commits into
microsoft:mainfrom
davidhunter22:guard_includes
Closed

David Hunter (davidhunter22) wants to merge 2 commits into
microsoft:mainfrom
davidhunter22:guard_includes

Conversation

@davidhunter22

Copy link
Copy Markdown
Contributor

Fixers #102 part 2

@GabrielDosReis

Copy link
Copy Markdown
Collaborator

As discussed in the referenced issue (why was it closed?), the direction of this patch is not on strategy.

We want to move to consuming std module, but not in dual mode with other standard headers that are conditionally included.

This project, by its nature, is at the tip of compilers and is not aiming for all sorts of backward compatibility at this stage of development. When we switch to consuming std module, it is for good.

@GabrielDosReis

Copy link
Copy Markdown
Collaborator

David Hunter (@davidhunter22) -
I am rejecting this PR because it is not on strategy as I explained in a previous comment.
Thanks for looking into the matter though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants