Skip to content

Add a return code to main - #64

Merged
Gabriel Dos Reis (GabrielDosReis) merged 2 commits into
microsoft:mainfrom
aytey:exit_status
Mar 27, 2024
Merged

Gabriel Dos Reis (GabrielDosReis) merged 2 commits into
microsoft:mainfrom
aytey:exit_status

Conversation

@aytey

Copy link
Copy Markdown
Contributor

This PR adds a return code to ifc-printer such that you get a non-zero return code if there's an exception.

Signed-off-by: Andrew V. Teylu andrew.teylu@vector.com

Comment thread src/ifc-printer/main.cxx Outdated
@GabrielDosReis

Copy link
Copy Markdown
Collaborator

Andrew Teylu (@aytey) - the CI build checks all successfully completed. But the PR cannot be merged without you completing the license/cla part.

@aytey

Andrew Teylu (aytey) commented Mar 13, 2024

Copy link
Copy Markdown
Contributor Author

Andrew Teylu (@aytey) - the CI build checks all successfully completed. But the PR cannot be merged without you completing the license/cla part.

I expected CLA bot to turn up TBH:

ifc/README.md

Lines 33 to 35 in 77c1c39

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to grant us the right to use your contribution. For details, visit https://cla.opensource.microsoft.com.
When you submit a pull request, a CLA bot will automatically determine whether you need to provide a CLA and decorate the PR (Pull Request) appropriately (e.g., status check, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.

How do I sign the CLA if the bot doesn't appear? 🙈

@GabrielDosReis

Copy link
Copy Markdown
Collaborator

Andrew Teylu (@aytey) - the CI build checks all successfully completed. But the PR cannot be merged without you completing the license/cla part.

I expected CLA bot to turn up TBH:

ifc/README.md

Lines 33 to 35 in 77c1c39

This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to grant us the right to use your contribution. For details, visit https://cla.opensource.microsoft.com.
When you submit a pull request, a CLA bot will automatically determine whether you need to provide a CLA and decorate the PR (Pull Request) appropriately (e.g., status check, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repos using our CLA.

How do I sign the CLA if the bot doesn't appear? 🙈

Weird. Can you verify you're not in situations like this: cla-assistant/cla-assistant#550

Can you log in the CLA assistant at https://cla-assistant.io/ and check for your CLA status with the microsoft orgqnization?

@aytey

Copy link
Copy Markdown
Contributor Author

Can you log in the CLA assistant at https://cla-assistant.io/ and check for your CLA status with the microsoft orgqnization?

I have no CLA with Microsoft there; I don't even know how to request to sign a CLA for microsoft/ifc. If I try to add one, I can add one for my fork of ifc, but not this actual repo.

@aytey

Copy link
Copy Markdown
Contributor Author

Well, who knows ... I asked that repo for help: cla-assistant/cla-assistant#1052

@GabrielDosReis

Copy link
Copy Markdown
Collaborator

Well, who knows ... I asked that repo for help: cla-assistant/cla-assistant#1052

Thanks for reaching out to them.

Sorry for the trouble :-(

@aytey

Copy link
Copy Markdown
Contributor Author

Sorry for the trouble :-(

Welcome to open source ... s'all good :)

@aytey

Copy link
Copy Markdown
Contributor Author

Gabriel Dos Reis (@GabrielDosReis): is there something we can do here? The https://github.com/cla-assistant/cla-assistant repo seems pretty dormant from maintainers, and it seems other people are reporting the same issue as I have here:

There's even an open PR to resolve that but no actions from the maintainers.

Signed-off-by: Andrew V. Teylu <andrew.teylu@vector.com>
Signed-off-by: Andrew V. Teylu <andrew.teylu@vector.com>
@aytey

Copy link
Copy Markdown
Contributor Author

A ha! A force-push kicked it into life!!! 😄

@GabrielDosReis

Copy link
Copy Markdown
Collaborator

A ha! A force-push kicked it into life!!! 😄

Amazing.

@GabrielDosReis

Copy link
Copy Markdown
Collaborator

A ha! A force-push kicked it into life!!! 😄

Amazing.

I accidentally closed the PR when I meant to "resolve" the comment. I reopened it. The PR was successfully merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants