Debugger should use proper decompiled classes URIs

[fbricon]

following eclipse-jdtls/eclipse.jdt.ls#3666, this code:

java-debug/com.microsoft.java.debug.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/JdtSourceLookUpProvider.java

Lines 468 to 478 in 26b05eb

	private static String getFileURI(IClassFile classFile) {
	String packageName = classFile.getParent().getElementName();
	String jarName = classFile.getParent().getParent().getElementName();
	try {
	return new URI(JDT_SCHEME, "contents", PATH_SEPARATOR + jarName + PATH_SEPARATOR + packageName
	+ PATH_SEPARATOR + classFile.getElementName(), classFile.getHandleIdentifier(), null)
	.toASCIIString();
	} catch (URISyntaxException e) {
	return null;
	}
	}

should be replaced by return JDTUtils.toUri(classFile);

I think it should be the proper fix for redhat-developer/vscode-java#4356

cc Changyong Gong (@chagong)

[github-actions]

Hi Fred Bricon (@fbricon), I'm an AI Support assistant here to help with your issue. While the team reviews your request, I wanted to provide some possible tips and documentation that might help you in the meantime.

Solution

• Replace the custom URI logic in JdtSourceLookUpProvider.java (lines 468–478) with:

  return JDTUtils.toUri(classFile);

  This matches the approach in eclipse-jdtls PR feat: have class URIs use their original source name eclipse-jdtls/eclipse.jdt.ls#3666 and fixes The filename of the class(with source code included) should not end with .class on debugging scene redhat-developer/vscode-java#4356.

Other references with high confidence

• Breakpoint support in decompiled classes
  Investigate the debugger with decompiler support vscode-java-debug#48 – investigation into enabling breakpoints in decompiled code.
  Investigate the debugger with decompiler support vscode-java-debug#48 (comment)

• DAP conformance for jdt:// URIs
  Java-Debug is not always conforming the Debugger Adapter Protocol #444 – recommends using sourceReference > 0 instead of embedding jdt:// URIs directly in the path for non-file sources.
  Java-Debug is not always conforming the Debugger Adapter Protocol #444

Other references with low confidence

• Use jar:file:/… URIs when possible
  eclipse-jdtls#2465 – discussion on preferring jar:file: over jdt:// for archive entries.
  Use jar:file:/... URIs when possible instead of jdt:/... ones eclipse-jdtls/eclipse.jdt.ls#2465 (comment)

• jdt FileSystemNotFoundException
  eclipse-jdtls#2644 – notes that no jdt provider is installed and shows sourceContentProvider resolving classfile via non-Paths.get() calls.
  java.nio.file.FileSystemNotFoundException: Provider "jdt" not installed eclipse-jdtls/eclipse.jdt.ls#2644 (comment)

• References in decompiled classes may fail
  eclipse-jdtls#3083 – investigates corner cases where references in decompiled bytecode don’t resolve.
  References within decompiled classes may fail to resolve eclipse-jdtls/eclipse.jdt.ls#3083

The team will respond to your issue shortly. I hope these suggestions are helpful in the meantime. If this comment helped you, please give it a 👍. If the suggestion was not helpful or incorrect, please give it a 👎. Your feedback helps us improve!

[wenytang-ms]

shipped the pre-release for vscode java to fix this issue.