Uh oh!
There was an error while loading. Please reload this page.
Improve ResolveMainClassHandler.resolveMainClassUnderPaths - #596
Merged
Conversation
Snjeza (snjeza)
requested review from
Sheng Chen (jdneo) and Jinbo Wang (testforstephen)
as code ownersJuly 20, 2025 19:39
There was a problem hiding this comment.
Pull Request Overview
This PR improves the ResolveMainClassHandler.resolveMainClassUnderPaths method to provide more targeted main class resolution by filtering projects based on provided paths instead of searching all Java projects.
- Adds conditional logic to filter Java projects when specific paths are provided
- Removes
REFERENCED_PROJECTSflag from search scope to focus only on source files - Imports
JavaCoreutility for creating IJavaProject instances
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Snjeza (snjeza)
commented
Aug 6, 2025
ContributorAuthor
I have updated the PR. |
wenyt (wenytang-ms)
approved these changes
Aug 13, 2025
wenyt (wenytang-ms)
requested a review
from Changyong Gong (chagong)
as a code ownerAugust 13, 2025 07:12
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#595