Uh oh!
There was an error while loading. Please reload this page.
fix: fixes typing issues discovered from github api generation - #402
Merged
Conversation
Andrew Omondi (andrueastman)
marked this pull request as ready for review
November 8, 2024 09:08
Andrew Omondi (andrueastman)
enabled auto-merge
November 8, 2024 09:08
Shem Ogumbe (shemogumbe)
approved these changes
Nov 9, 2024
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to microsoft/kiota#5729
Fixes failures in integration tests due to mypy failures in incorrect typing information for the following methods,
send_collection_of_primitive_asyncfromRequestAdaptershould have thetypeas the parameter type for ResponseTypeset_content_from_parsableto target parsable so thatset_content_from_scalarcan target scalarsget_collection_of_primitive_valuesas well as the derived implementationsget_collection_of_object_valuesas well as the derived implementations