Skip to content

feat: drop support for python 3.8 - #433

Merged
Andrew Omondi (andrueastman) merged 6 commits into
mainfrom
andrueastman/python38drop
Jan 10, 2025
Merged

feat: drop support for python 3.8#433
Andrew Omondi (andrueastman) merged 6 commits into
mainfrom
andrueastman/python38drop

Conversation

@andrueastman

@andrueastmanAndrew Omondi (andrueastman) commented Jan 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#349

This PR drops support for python 3.8 in the kiota libraries.

In summary, the changes include

  • Dropping using of collection type hint aliases such as Dict, Set and List from typing.
  • Updates projects requirements to include python 3.9+ and drop 3.8
  • Updates validation client to use non deprecated hints via Update validation project with typing updates #434

@sonarqubecloud

sonarqubecloudBot commented Jan 8, 2025

Copy link
Copy Markdown

Quality Gate FailedQuality Gate failed

Failed conditions
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

This was referenced Jan 9, 2025
Merged
Merged
@andrueastmanAndrew Omondi (andrueastman) changed the title [WIP] feat: drop support for python 3.8feat: drop support for python 3.8Jan 9, 2025
@andrueastman
Andrew Omondi (andrueastman) marked this pull request as ready for review January 9, 2025 08:30
@andrueastmanAndrew Omondi (andrueastman) mentioned this pull request Jan 9, 2025
Closed
3 tasks
baywet
Vincent Biret (baywet) approved these changes Jan 9, 2025
View reviewed changes

@baywetVincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also taking the time to clean up the imports of typings to BCL, I had not anticipated that.

@andrueastman
Andrew Omondi (andrueastman) deleted the andrueastman/python38drop branch January 10, 2025 06:42
@andrueastmanAndrew Omondi (andrueastman) added the release-please:force-run used to force releases with RP label Jan 13, 2025
@release-pleaserelease-pleaseBot removed the release-please:force-run used to force releases with RP label Jan 13, 2025
@baywetVincent Biret (baywet) mentioned this pull request Mar 13, 2025
Merged
This was referenced Sep 8, 2025
Merged
Closed
@baywetVincent Biret (baywet) mentioned this pull request Apr 2, 2026
Closed
CopilotAI mentioned this pull request Apr 2, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywetVincent Biret (baywet)baywet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Kiota
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

drop support for python 3.8

2 participants

@andrueastman@baywet