Skip to content

Fix warning/deprecated msg indentation in help text - #167

Merged
Jiashuo Li (jiasli) merged 5 commits into
microsoft:masterfrom
atbagga:patch-3
Feb 17, 2020
Merged

Jiashuo Li (jiasli) merged 5 commits into
microsoft:masterfrom
atbagga:patch-3

Conversation

@atbagga

@atbagga Atul Bagga (atbagga) commented Oct 17, 2019

Copy link
Copy Markdown
Contributor

Fixes #164

  • Before the fix:
    image

  • After the fix:
    image

@atbagga

Copy link
Copy Markdown
Contributor Author

Tosin Adewale (@adewaleo) Travis Prescott (@tjprescott) Can you please take a look at this fix?

Also the build failures seem unrelated to the change.

@adewaleo

Copy link
Copy Markdown
Contributor

Atul Bagga (@atbagga) we no longer work on the CLI team. Please reach out to Yong Zhang (@yonzhan)

cc: Feiyue Yu (@qwordy) Zunli Hu (@Juliehzl)

@yonzhan

Copy link
Copy Markdown
Collaborator

Jiashuo Li (@jiasli) please take a look at this PR.

@yonzhan

Copy link
Copy Markdown
Collaborator

We will plan it after Ignite.

Comment thread knack/help.py Outdated
@qwordy

Copy link
Copy Markdown

The Travis CI build failed.

@qwordy

Copy link
Copy Markdown

/azp run

@azure-pipelines

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 167 in repo microsoft/knack

@qwordy

Copy link
Copy Markdown

I don't have permission to rerun CI.

@qwordy

Copy link
Copy Markdown

And it seems I don't have write access. So my approval is not sufficient.

Review required
At least 1 approving review is required by reviewers with write access. 

@atbagga

Copy link
Copy Markdown
Contributor Author

Thanks Feiyue Yu (@qwordy)

Can you also check why is the CI broken? Seems unrelated to my change.

@atbagga

Copy link
Copy Markdown
Contributor Author

Jiashuo Li (@jiasli) Yong Zhang (@yonzhan) CI seems to be broken for Knack.

I tried a PR with just readme changes and yet it failed - #168

@jiasli

Copy link
Copy Markdown
Contributor

Atul Bagga (@atbagga) , do you mind fix the test to pass the CI? https://travis-ci.org/microsoft/knack/jobs/648761811#L274

@atbagga

Copy link
Copy Markdown
Contributor Author

Atul Bagga (@atbagga) , do you mind fix the test to pass the CI? https://travis-ci.org/microsoft/knack/jobs/648761811#L274

Done!! Jiashuo Li (@jiasli)

@jiasli

Copy link
Copy Markdown
Contributor

Harold Ran (@haroldrandom) , is it safe to merge to master?

@haroldrandom Harold Ran (haroldrandom) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@haroldrandom

Copy link
Copy Markdown

Harold Ran (@haroldrandom) , is it safe to merge to master?

Look so. Please go ahead.

@jiasli
Jiashuo Li (jiasli) merged commit 4dcea7c into microsoft:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marking command for preview - the preview message should be in the new line and not continue in the long summary

7 participants