Support Python 3.10 - #250
Merged
Merged
Conversation
| pylint==2.7.2 | ||
| pytest==6.2.2 | ||
| pylint==2.11.1 | ||
| pytest==6.2.5 |
Contributor
Author
There was a problem hiding this comment.
Old pytest fails in Python 3.10: pytest-dev/pytest#8546 (comment)
=============================================== short test summary info ===============================================
ERROR tests/test_cli_scenarios.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_command_registration.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_command_with_configured_defaults.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_completion.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_config.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_deprecation.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_experimental.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_help.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_introspection.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_log.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_output.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_parser.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_preview.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_prompting.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_query.py - TypeError: required field "lineno" missing from alias
ERROR tests/test_util.py - TypeError: required field "lineno" missing from alias
Jiashuo Li (jiasli)
marked this pull request as ready for review
October 26, 2021 04:08
| def set(self, config): | ||
| ensure_dir(self.config_dir) | ||
| with open(self.config_path, 'w') as configfile: | ||
| with open(self.config_path, 'w', encoding=CONFIG_FILE_ENCODING) as configfile: |
Contributor
Author
There was a problem hiding this comment.
pylint warns:
knack\config.py:225:13: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
See https://pylint.pycqa.org/en/latest/technical_reference/features.html#stdlib-checker-messages
| Pygments==2.8.1 | ||
| pylint==2.7.2 | ||
| pytest==6.2.2 | ||
| pylint==2.11.1 |
Contributor
Author
There was a problem hiding this comment.
New pylint is more strict on grammar. We need to fix these additional check failures.
6 tasks
Jiashuo Li (jiasli)
requested review from
Zhiyi Huang (calvinhzy) and
Yishi Wang (evelyn-ys)
October 26, 2021 06:24
| # R1717 consider-using-dict-comprehension | ||
| disable=W0511,C0111,C0103,C0415,I0011,R0913,R0903,R0401,R0205,R1717,useless-suppression | ||
| disable=W0511,C0111,C0103,C0415,I0011,R0913,R0903,R0401,R0205,R1717,useless-suppression, | ||
| consider-using-f-string |
Contributor
Author
There was a problem hiding this comment.
There are countless places where str.format is used. We should allow it.
Yishi Wang (evelyn-ys)
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting Python 3.10 in Knack is the prerequisite for