Mark Python 3.12 support - #279
Merged
Merged
Conversation
4 tasks
Contributor
|
Jiashuo Li (@jiasli) Yong Zhang (@yonzhan) AllyW sorry for mentioning directly, but can someone review this? It's a simple and small PR. |
Contributor
|
We will work on Python 3.12 support together with Azure/azure-cli#27673. |
Contributor
|
I think this can be merged independently, I don't understand, are these projects coupled? Or don't you trust the tests enough that you can't merge before you run Azure CLI tests with Knack on Python 3.12? |
Comment on lines
+35
to
+37
| Python312: | ||
| python.version: '3.12' | ||
| tox_env: 'py312' |
Contributor
There was a problem hiding this comment.
Could you also update L60 to use 3.12?
Merged
Yishi Wang (evelyn-ys)
approved these changes
Jul 12, 2024
Hang (bebound)
approved these changes
Jul 12, 2024
Jiashuo Li (jiasli)
approved these changes
Jul 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've run the tests locally and all pass