Uh oh!
There was an error while loading. Please reload this page.
Support section related Windows syscalls - #1001
Merged
Merged
Conversation
Implement NtOpenSection as a host-grounded resolve-and-reject path for the empty KnownDlls namespace. Reuse object-manager name resolution, zero the output handle on non-AV rejects, and let the Windows loader fall back to file-based mapping. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Explain that LiteBox currently rejects simultaneous pagefile section views because PageManager lacks shared anonymous backing, and document the single-concurrent-view workaround that preserves unmap/remap contents via section-owned backing storage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Drop the NtMapViewOfSection comment that only restated the branch below without documenting a LiteBox-specific invariant or guest-visible behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the standalone markdown note with a concise Rust doc comment on the pagefile section backing that explains the no-shared-mapping limitation and unmap/remap workaround. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove section.rs comments that only restated Wine/ReactOS branch structure and kept the comments that anchor host-observed status behavior or LiteBox-specific limitations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reject NtMapViewOfSection pagefile views whose requested protection is incompatible with the section's create-time protection, matching host and ReactOS behavior. Allow compatible PAGE_NOACCESS and copy views while still requiring SECTION_MAP_READ for PAGE_NOACCESS. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the section-owned Vec backing and pagefile flush machinery to avoid guest-controlled kernel memory amplification. Pagefile sections now commit only guest view pages, reject concurrent and post-unmap remaps with STATUS_NOT_SUPPORTED, and keep map-failure rollback paths retryable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Pagefile backing doc-comment now records that the second-concurrent-view and remap-after-unmap rejects are one deferred capability (shared write-through backing), not two unrelated limitations. Doc-only; no behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Weiteng Chen (CvvT)
marked this pull request as ready for review
July 2, 2026 20:16
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
NtOpenSection,NtCreateSection,NtQuerySection,NtMapViewOfSectionandNtUnmapViewOfSection.Note LiteBox lacks shared anonymous backing, so a pagefile section is only allowed to be mapped once. For image section, it can be mapped multiple times by copying without copy-on-write mapping support.