Uh oh!
There was an error while loading. Please reload this page.
Make Linux eventfd broker-backed - #1005
Merged
Weidong Cui (wdcui) merged 5 commits intoJul 6, 2026
Merged
Conversation
Rename the broker-backed eventfd counter variant from LocalCore to BrokerBacked and extend the no-broker fallback test to cover blocking eventfds as well as nonblocking ones. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the shim-local Linux eventfd implementation so eventfd creation now requires broker control. Update non-broker shim and runner tests to use other fd types or expect eventfd creation failure, while keeping broker-backed eventfd coverage in the broker runner test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move the eventfd sendfile in_fd errno coverage into the broker-backed eventfd integration test now that non-broker eventfd creation is unavailable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add broker-backed eventfd coverage for EFD_CLOEXEC and F_SETFD clearing after non-broker fcntl tests stopped creating eventfds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move the Node runner coverage into the broker integration test because Node's libuv initialization uses eventfd, which now requires broker control. Reuse the existing broker host setup instead of creating another BrokerCore in the same test process. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Jul 4, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the Linux eventfd syscall path use the broker-backed EventCounter implementation and removes the shim-local Linux eventfd fallback. Non-broker Linux shim and runner tests now either expect eventfd creation to fail without broker control or use pipes for non-eventfd-specific fd coverage. Broker-backed Linux eventfd coverage remains in the broker runner integration test, including blocking/nonblocking behavior, poll/epoll readiness, sendfile in_fd errno behavior, and EFD_CLOEXEC/FD_CLOEXEC handling.