Uh oh!
There was an error while loading. Please reload this page.
Introduce object manager to Windows shim - #1015
Merged
Merged
Conversation
Model \\Windows\\SharedSection as a CSR shared section and initialize mapped views with the same static server data shape used by the PEB CSR pointers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the synthetic CSR shared section in the section namespace so repeated opens upgrade the same section object and share the single-view latch. Add a regression test for the named-section collision path and document the remaining no-shared-backing limitation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep synthesized CSR shared sections alive for the process lifetime so reopen/remap cannot reinitialize the persistent server-data region. Preserve the existing weak namespace cache for ordinary sections and add regression coverage for close/reopen and remap rejection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Capture the current second-copy CSR mapping limitation and the deferred base/session-name aliasing behavior near the relevant section code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Point the deferred CSR section fix at moving the load-time PEB CSR region onto the SectionObject backing before mapping views, rather than implying it is only a map-view change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Weiteng Chen (CvvT)
marked this pull request as ready for review
July 9, 2026 01:01
Uh oh!
There was an error while loading. Please reload this page.
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR wires the Windows CSR shared section through the shim as a real named section object and maps it during process load. Due to the lack of shared mapping support, it is not actually shared even within one process.
It also consolidates Windows named-object handling into a single object-manager namespace. Directory, symbolic link, event, and section objects now live under one namespace tree, with typed object leaves and shared resolution logic. This lets paths like \Windows\SharedSection behave as an object-manager shortcut to \Sessions\0\Windows\SharedSection while keeping a TODO for multi-session resolution.