Uh oh!
There was an error while loading. Please reload this page.
Enable concurrent mappings of shared normal-world/VTL0 physical pages - #1028
Merged
Conversation
Sangho Lee (sangho2)
marked this pull request as ready for review
July 14, 2026 22:04
Sangho Lee (sangho2)force-pushed
the
sanghle/lvbs/shared_phys_ptr
branch
3 times, most recently
from
July 14, 2026 22:53
b7841e8 to
1b82cafCompareWeidong Cui (wdcui)
approved these changes
Jul 15, 2026
Weidong Cui (wdcui)
left a comment
Member
There was a problem hiding this comment.
Overall, LGTM. I left one comment below and shared the issues found by GPT-5.6 offline.
Uh oh!
There was an error while loading. Please reload this page.
Sangho Lee (sangho2)
commented
Jul 17, 2026
ContributorAuthor
Merge PR #1031 first. |
Sangho Lee (sangho2)force-pushed
the
sanghle/lvbs/shared_phys_ptr
branch
from
July 17, 2026 19:40
7930202 to
bc6cda5CompareSangho Lee (sangho2)
enabled auto-merge
July 17, 2026 19:43
🤖 SemverChecks 🤖 Click for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables concurrent mappings of shared normal-world (VTL0) physical pages. Currently, our physical pointer abstraction uses direct/identity maps for contiguous physical pages, rejecting concurrent mappings. PR #979 bypasses this problem through over-serialization. Instead, this PR solves it by making the physical pointer abstraction always use
vmap, returning private virtual addresses for shared physical pages.