Uh oh!
There was an error while loading. Please reload this page.
Windows shim support for NtConnectPort - #1034
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pin bitflags before its incompatible 2.11 API change and remove a newly denied Clippy lint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep NtConnectPort connect info on the client read-only mapping while backing the Windows shared section and PEB CSR server field with a distinct initialized region. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use a local macro for the repeated typed raw-FD removal and visitor dispatch pattern. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the initialized shared-section allocation with process-environment construction, write the server base from load_program, and read only required PEB fields for connect info. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reuse the initialized client CSR region for the named Windows shared section until distinct virtual mappings of shared backing are supported. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Seed the CSR API port as a permanent Port object and resolve NtConnectPort names through the namespace with exact canonical-path matching. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Make fatal unsupported-syscall termination explicit while retaining the existing diagnostic text used by runner tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the synthetic test-task CSR allocation out of the production shim module. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Include the syscall stub, caller, and four Windows ABI arguments when an unsupported syscall terminates the guest. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Factor common pagefile view validation, allocation, and bookkeeping across NtMapViewOfSection and NtConnectPort, and remove the redundant CSR-size cap. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Report zero server DLL names because no name list is modeled, while documenting the unpopulated static-data slots separately from the four-slot table capacity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the branch-local bitflags downgrade so Cargo.lock matches the ulitebox base. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Weiteng Chen (CvvT)
marked this pull request as ready for review
July 17, 2026 00:23
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the CSR
NtConnectPortstartup handshake so Windows guests can connect to\Windows\ApiPort, receive CSR connection data, and map their client section.CSR client and CSRSS bases currently alias one mapping; distinct virtual mappings over shared backing remain TODO. Also, only BASESRV static-data slot 1 is populated; CSRSRV (0), CONSRV (2), USERSRV (3) remain TODO.