Skip to content
This repository was archived by the owner on Jun 15, 2026. It is now read-only.

Support Moniker - #63

Merged
Sheng Chen (jdneo) merged 18 commits into
microsoft:masterfrom
CsCherrYY:moniker
Sep 4, 2020
Merged

Support Moniker#63
Sheng Chen (jdneo) merged 18 commits into
microsoft:masterfrom
CsCherrYY:moniker

Conversation

@CsCherrYY

@CsCherrYYShi Chen (CsCherrYY) commented Jul 26, 2020

Copy link
Copy Markdown
Contributor

This PR is to support monikers and packageInfomation in LSIF-Java. For more information, Please see
https://microsoft.github.io/language-server-protocol/specifications/lsif/0.5.0/specification/

jdneo
Sheng Chen (jdneo) suggested changes Aug 13, 2020
View reviewed changes
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
@CsCherrYY
Apply changes
de62e4d
1. Merge PackageInformation Maps in Repository
2. Use `org.apache.maven.scm.provider.ScmUrlUtils` to resolve scm
3. Support Both Java8- and Java9+
4. Rename `project` moniker to `group` moniker
5. Rewrite some codes
jdneo
Sheng Chen (jdneo) suggested changes Aug 19, 2020
View reviewed changes
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
@CsCherrYY
Apply changes
726779c
1. handle together for different JDK distributions
2. Use `IMaven.readProject` to get effective pom information
jdneo
Sheng Chen (jdneo) suggested changes Aug 24, 2020
View reviewed changes
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java Outdated
Comment thread...ft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/protocol/PackageInformation.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
@CsCherrYY
Apply changes
00b55ac
1. Remove useless `ProjectBuildTool` and unified all the manager to `maven`
2. Rewrite logic of finding pom and export monikers of maven project.
3. other fix
jdneo
Sheng Chen (jdneo) reviewed Aug 26, 2020
View reviewed changes
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
@CsCherrYY
Apply changes
61e466d
1. Use binding to get modifiers
2. Resolve visibility of enum
3. clean and enhance codes
jdneo
Sheng Chen (jdneo) suggested changes Aug 31, 2020
View reviewed changes
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/ASTUtil.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Repository.java
@CsCherrYY
Apply comments
85c6686
1. Remove bindingsRecovery
2. Divides read and write in packageinformation
3. Fix Enum modifier bug
4. Fix an NPE bug when the connection of a scm is null
jdneo
Sheng Chen (jdneo) reviewed Aug 31, 2020
View reviewed changes
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java
@CsCherrYY
Apply changes
57b1db5
1. Adjust assignment of monikerKind
2. Resolve comments
jdneo
Sheng Chen (jdneo) suggested changes Sep 1, 2020
View reviewed changes
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
@CsCherrYY
Apply changes
1dece7c
1. Extract a method to initialize manager
2. Extract a method to resolve a SimpleName/SimpleType
3. apply other comments
@CsCherrYY
Update LsifVisitor.java
baa070e
Rewrite resolve logics
jdneo
Sheng Chen (jdneo) suggested changes Sep 2, 2020
View reviewed changes
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment thread...microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/visitors/LsifVisitor.java Outdated
Comment threadcom.microsoft.java.lsif.core/src/com/microsoft/java/lsif/core/internal/indexer/Indexer.java Outdated
@CsCherrYY
Apply changes
cfed442
1. Move `resolveMoniker` to SymbolData.java
2. NULL check once have gotten values
jdneo
Sheng Chen (jdneo) approved these changes Sep 4, 2020
View reviewed changes

@jdneoSheng Chen (jdneo) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo
Sheng Chen (jdneo) merged commit 4b47502 into microsoft:masterSep 4, 2020
@jdneoSheng Chen (jdneo) added this to the 0.4.0 milestone Sep 8, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jdneoSheng Chen (jdneo)jdneo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@CsCherrYY@jdneo