Skip to content

Refine decision event logic - #559

Merged
Jinyu-W merged 9 commits into
v0.3from
refine_decision_event_type
Aug 31, 2022
Merged

Refine decision event logic#559
Jinyu-W merged 9 commits into
v0.3from
refine_decision_event_type

Conversation

@lihuoran

Copy link
Copy Markdown
Contributor

Description

  • Add DecisionEventPayload and ActionPayload as the base class for payloads of decision events & action events.
  • Add related type check during running.
  • Rename related variables under simulator/.
  • Refine the action handling logic. Modify Env and related BEs.

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.7
    • 3.8
    • 3.9
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

Comment threadexamples/cim/rl/env_sampler.py
Comment threadmaro/simulator/core.py
Comment threadmaro/simulator/core.py
Comment threadmaro/simulator/scenarios/cim/business_engine.py Outdated
Comment threadmaro/simulator/scenarios/citi_bike/business_engine.py Outdated
Comment threadmaro/simulator/scenarios/citi_bike/business_engine.py Outdated
Comment threadtests/cim/test_cim_scenario.py
Comment threadmaro/common.py Outdated
Comment threadmaro/common.py Outdated
Comment threadmaro/event_buffer/event_buffer.py Outdated
Comment threadmaro/simulator/core.py Outdated
Comment threadmaro/simulator/core.py Outdated
@codecov

codecovBot commented Aug 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #559 (f96c4d2) into v0.3 (8022cd9) will increase coverage by 0.40%.
The diff coverage is 84.21%.

@@ Coverage Diff @@## v0.3 #559 +/- ##
==========================================
+ Coverage 78.90% 79.30% +0.40% 
==========================================
Files 85 86 +1 Lines 5455 5464 +9 ==========================================
+ Hits 4304 4333 +29 + Misses 1151 1131 -20 
FlagCoverage Δ
unittests79.30% <84.21%> (+0.40%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted FilesCoverage Δ
...o/simulator/scenarios/citi_bike/business_engine.py75.00% <42.85%> (ø)
maro/simulator/core.py85.40% <68.75%> (-0.73%)⬇️
...mulator/scenarios/vm_scheduling/business_engine.py78.72% <90.00%> (+0.09%)⬆️
maro/common.py100.00% <100.00%> (ø)
maro/event_buffer/event_buffer.py100.00% <100.00%> (ø)
maro/simulator/scenarios/cim/business_engine.py93.63% <100.00%> (-0.02%)⬇️
maro/simulator/scenarios/cim/common.py96.49% <100.00%> (+1.84%)⬆️
maro/simulator/scenarios/citi_bike/common.py65.45% <100.00%> (+0.63%)⬆️
maro/simulator/scenarios/vm_scheduling/common.py82.60% <100.00%> (+0.38%)⬆️
maro/simulator/utils/common.py88.88% <100.00%> (-1.59%)⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Jinyu-W
Jinyu-W merged commit 9fd91ff into v0.3Aug 31, 2022
@Jinyu-W
Jinyu-W deleted the refine_decision_event_type branch August 31, 2022 07:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lihuoran@Jinyu-W