Skip to content

RL benchmark on GYM - #575

Merged
Jinyu-W merged 23 commits into
v0.3from
rl_benchmark_debug
Feb 6, 2023
Merged

RL benchmark on GYM#575
Jinyu-W merged 23 commits into
v0.3from
rl_benchmark_debug

Conversation

@lihuoran

Copy link
Copy Markdown
Contributor

Description

Linked issue(s)/Pull request(s)

Type of Change

  • Non-breaking bug fix
  • Breaking bug fix
  • New feature
  • Test
  • Doc update
  • Docker update

Related Component

  • Simulation toolkit
  • RL toolkit
  • Distributed toolkit

Has Been Tested

  • OS:
    • Windows
    • Mac OS
    • Linux
  • Python version:
    • 3.7
    • 3.8
    • 3.9
  • Key information snapshot(s):

Needs Follow Up Actions

  • New release package
  • New docker image

Checklist

  • Add/update the related comments
  • Add/update the related tests
  • Add/update the related documentations
  • Update the dependent downstream modules usage

@codecov

codecovBot commented Jan 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #575 (b4db842) into v0.3 (eb6324c) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## v0.3 #575 +/- ##
=======================================
Coverage 79.30% 79.30% =======================================
Files 86 86 Lines 5464 5464 =======================================
Hits 4333 4333 Misses 1131 1131 
FlagCoverage Δ
unittests79.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lihuoran
Huoran Li (lihuoran) marked this pull request as ready for review January 28, 2023 03:11
Comment threadtests/rl/algorithms/ac.py Outdated
Comment threadtests/rl/algorithms/ac.py Outdated
Comment threadtests/rl/algorithms/sac.py Outdated
Comment threadtests/rl/algorithms/sac.py Outdated
Comment threadtests/rl/gym_wrapper/config.py
Comment threadtests/rl/gym_wrapper/rl_component_bundle.py Outdated
Comment threadtests/rl/gym_wrapper/rl_component_bundle.py
Comment threadtests/rl/gym_wrapper/simulator/business_engine.py Outdated
Comment threadtests/rl/gym_wrapper/simulator/business_engine.py Outdated
Comment threadtests/rl/gym_wrapper/simulator/business_engine.py Outdated
@Jinyu-W

Copy link
Copy Markdown
Contributor

How about add a md file under tests/rl to list the performance of these algorithms?

@Jinyu-W

Copy link
Copy Markdown
Contributor

How about add a md file under tests/rl to list the performance of these algorithms?

  • file added in PR 576, waiting for more details and experiment result
  • some comments resolved in PR 576 also

@Jinyu-W

Copy link
Copy Markdown
Contributor

PR 573 closed

Jinyu-W
Jinyu-W previously approved these changes Feb 6, 2023
@Jinyu-W
Jinyu-W merged commit 214383f into v0.3Feb 6, 2023
@Jinyu-W
Jinyu-W deleted the rl_benchmark_debug branch February 6, 2023 05:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lihuoran@Jinyu-W