Skip to content

[Bug] Monaco "vs" theme for SQL language does not meet minimum color contrast issue threshold for .mtk4 and mtk18 #5461

Description

@shubhamPPrakash

Reproducible in vscode.dev or in VS Code Desktop?

  • Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

Monaco Editor Playground Link

https://microsoft.github.io/monaco-editor/playground.html?source=v0.55.1#XQAAAAJoAQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscwzblk-_1uhs0-3YGTBOsVJ4S4FwfCDQb5-2uUHXTVAefbVSd9IzaZ_vv9VR9KugsKiiNFGo32AmK1qWwDpnVOw0wveTSJD_3iO4BKLEw9tppV76hyOiRWV1v9unOkf_vqEKcuw4cacr8Pfxvkt3UCKw3aCszRSkppL-1wKEuMbjhVRIe7vr73CAQ6_q7-YsWc1rjqrkR1l8IJtiT0vbyr2iClBxBIOEv_As8KnDEPRwUloUrBImqABZ6_1NiMOAB46XoPH_m2CVfKgDDZpKg3SC1X8X1QAnOk5Yy4BI7lp4Mq59qUoNYOO-L70fuIqgfkJ__lDLFl

Monaco Editor Playground Code

const value = /* set from `myEditor.getModel()`: */ `SELECT * FROM DB
WHERE ENV = 'TEST'
AND IS_VERIFIED IS TRUE

`;

// Hover on each property to see its docs!
const myEditor = monaco.editor.create(document.getElementById("container"), {
	value,
	language: "sql",
	automaticLayout: true,
});

Reproduction Steps

Open Monaco Playground
Set the language as sql
Write the sql query which includes 'SOME TEXT' and IS
Use some Accessibility tool for testing the contrast ratio like AXE-CORE

Image

Actual (Problematic) Behavior

The contrast ration for some token with classes such .mtk4 and .mtk18 will have contrast ratio below WCAG 2 AA minimum contrast ratio threshold which is 4.5:1

Expected Behavior

The Contrast ration for all token should be more than 4.5:1

Additional Context

https://dequeuniversity.com/rules/axe/4.12/color-contrast?application=AxeChrome

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions