Uh oh!
There was an error while loading. Please reload this page.
[SDK] Plumb proxy through network SandboxPolicy and add proxy integration tests - #112
Merged
Merged
Conversation
- Add proxy discriminated union to SandboxPolicy.network - Pass proxy through to ContainerConfig.network in buildSandboxPayload - Reject proxy on Linux with clear error message - Update index.ts doc comment - Add SDK unit tests for proxy plumbing - Add CLI integration tests for builtinTestServer and localhost proxy - Add minimal Node.js CONNECT proxy for localhost test
Branden Bonaby (bbonaby)
marked this pull request as ready for review
April 3, 2026 03:22
Branden Bonaby (bbonaby)
requested review from
Soham Das (SohamDas2021) and Anis Mohammed Khaja Mohideen (kanismohammed)April 3, 2026 04:08
| }; | ||
| if (policy.network?.proxy) { | ||
| throw new Error('Proxy configuration is not supported on Linux'); |
CollaboratorAuthor
There was a problem hiding this comment.
FYI: I haven't added proxy support for linux yet so for now this is not supported. But in the future it will be.
| * - `builtinTestServer`: Use the built-in test proxy server | ||
| * - `localhost`: Forward traffic through a proxy on the specified localhost port | ||
| */ | ||
| proxy?: { builtinTestServer: true } | { localhost: number } |
CollaboratorAuthor
There was a problem hiding this comment.
FYI: Hope is to expand this in the future to allow for folks to add addresses/hosts + ports but for today we just have the builtin test one and external localhost for now.
Branden Bonaby (bbonaby)
requested review from
Jeff Whiteside (jsidewhite) and shschaefer
and removed request for
Jeff Whiteside (jsidewhite)April 3, 2026 04:34
Anis Mohammed Khaja Mohideen (kanismohammed)
approved these changes
Apr 3, 2026
Branden Bonaby (bbonaby)
commented
Apr 3, 2026
CollaboratorAuthor
Merging so we can kick off a build and provide a drop to our partners. If there are concerns I will address them in a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow