Skip to content

Revert "Bring network wire schema to full GA spec" (PR676) - #707

Merged
Gudge (MGudgin) merged 1 commit into
mainfrom
user/gudge/revert_network_schema_changes
Jul 29, 2026
Merged

Revert "Bring network wire schema to full GA spec" (PR676)#707
Gudge (MGudgin) merged 1 commit into
mainfrom
user/gudge/revert_network_schema_changes

Conversation

@MGudgin

@MGudginGudge (MGudgin) commented Jul 29, 2026

Copy link
Copy Markdown
Member

This reverts commit dd14f80 (PR #676)

Microsoft Reviewers: Open in CodeFlow

CopilotAI review requested due to automatic review settings July 29, 2026 19:40
@MGudgin
Gudge (MGudgin) requested a review from a team as a code ownerJuly 29, 2026 19:40
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@MGudginGudge (MGudgin) changed the title Revert "Bring network wire schema to full GA spec (wire.rs + config f…Revert "Bring network wire schema to full GA spec" (PR676)Jul 29, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the incomplete GA network schema migration, restoring the legacy network contract and associated test coverage.

Changes:

  • Restores legacy network and proxy models, parser behavior, generated schema, and SDK types.
  • Restores legacy networking fixtures across supported backends.
  • Re-enables previously deferred tests and SDK integration testing.
Show a summary per file
FileDescription
tests/examples/wslc_hello_world.jsonRestores legacy default-deny policy.
tests/examples/27_mac_terminal_sandboxed.jsonRestores legacy default-deny policy.
tests/examples/25_mac_ui_clipboard_enabled.jsonRestores legacy default-deny policy.
tests/examples/24_mac_ui_disabled.jsonRestores legacy default-deny policy.
tests/examples/23_mac_blocked_hosts_unsupported.jsonRestores legacy blocked-host example.
tests/examples/22_mac_network_allow_all.jsonRestores legacy allow-all policy.
tests/examples/21_mac_python_info.jsonRestores legacy default-deny policy.
tests/examples/20_mac_combined_restrictions.jsonRestores hostname allowlist.
tests/examples/19_mac_network_restricted.jsonRestores hostname allowlist.
tests/examples/18_mac_filesystem_access.jsonRestores legacy default-deny policy.
tests/examples/17_mac_deny_filesystem.jsonRestores legacy default-deny policy.
tests/examples/16_mac_deny_network.jsonRestores legacy default-deny policy.
tests/examples/15_mac_hello_world.jsonRestores legacy default-deny policy.
tests/examples/13_lxc_network_restricted.jsonRestores LXC firewall configuration.
tests/examples/12_builtin_test_proxy_processcontainer.jsonRestores built-in proxy configuration.
tests/examples/11_localhost_proxy_processcontainer.jsonRestores localhost proxy configuration.
tests/examples/06_network_capabilities_only.jsonRestores capability enforcement settings.
tests/examples/04_combined_restrictions.jsonRestores combined network restrictions.
tests/examples/03_network_restricted.jsonRestores firewall host filtering.
tests/configs/wslc_timeout.jsonRestores legacy default-deny policy.
tests/configs/wslc_tar_import_rootfs.jsonRestores legacy default-deny policy.
tests/configs/wslc_tar_import_docker_save.jsonRestores legacy default-deny policy.
tests/configs/wslc_stderr.jsonRestores legacy default-deny policy.
tests/configs/wslc_readonly_mount.jsonRestores legacy default-deny policy.
tests/configs/wslc_python_stdlib.jsonRestores legacy default-deny policy.
tests/configs/wslc_python_hello.jsonRestores legacy default-deny policy.
tests/configs/wslc_port_mapping_tcp.jsonRestores allow-all policy.
tests/configs/wslc_port_mapping_multiple.jsonRestores allow-all policy.
tests/configs/wslc_network_isolated.jsonRestores legacy default-deny policy.
tests/configs/wslc_most_specific_denied_parent.jsonRestores allow-all policy.
tests/configs/wslc_large_output.jsonRestores legacy default-deny policy.
tests/configs/wslc_filesystem.jsonRestores allow-all policy.
tests/configs/wslc_filesystem_object.jsonRestores allow-all policy.
tests/configs/wslc_exit_code.jsonRestores legacy default-deny policy.
tests/configs/wslc_env_vars.jsonRestores legacy default-deny policy.
tests/configs/wslc_destroy_on_exit_true.jsonRestores legacy default-deny policy.
tests/configs/wslc_destroy_on_exit_false.jsonRestores legacy default-deny policy.
tests/configs/wslc_denied_masking.jsonRestores allow-all policy.
tests/configs/wslc_denied_dotdot_alias.jsonRestores allow-all policy.
tests/configs/wslc_custom_registry.jsonRestores allow-all policy.
tests/configs/wslc_custom_registry_quay.jsonRestores allow-all policy.
tests/configs/wslc_custom_registry_ghcr.jsonRestores allow-all policy.
tests/configs/proxy_builtin_test.jsonRestores built-in proxy configuration.
tests/configs/processcontainer_network_unc_blocked.jsonRestores capability-based blocking.
tests/configs/processcontainer_network_tcp_blocked.jsonRestores capability-based blocking.
tests/configs/processcontainer_network_icmp_blocked.jsonRestores capability-based blocking.
tests/configs/processcontainer_network_dns_blocked.jsonRestores capability-based blocking.
tests/configs/network_firewall_test.jsonRestores firewall host filtering.
tests/configs/network_default_test.jsonRestores default host filtering.
tests/configs/network_capabilities_test.jsonRestores capability host filtering.
tests/configs/network_both_test.jsonRestores combined enforcement.
tests/configs/microvm_network.jsonRestores legacy allow-all policy.
tests/configs/microvm_network_linux.jsonRestores legacy allow-all policy.
tests/configs/lxc_network_test.jsonRestores LXC host rules.
tests/configs/hyperlight_networking.jsonRestores Hyperlight allowlist.
tests/configs/hyperlight_networking_blocked.jsonRestores Hyperlight allowlist.
tests/configs/bubblewrap_network_proxy_builtin.jsonRestores Bubblewrap built-in proxy.
tests/configs/bubblewrap_network_proxy_blocklist.jsonRestores proxy blocklist.
tests/configs/bubblewrap_network_proxy_allowlist.jsonRestores proxy allowlist.
tests/configs/bubblewrap_network_firewall.jsonRestores firewall host rules.
tests/configs/bubblewrap_network_block.jsonRestores default-deny policy.
src/testing/wxc_e2e_tests/tests/e2e_windows.rsRe-enables networking E2E cases.
src/testing/wxc_e2e_tests/tests/e2e_seatbelt_characterization.rsRe-enables Seatbelt proxy test.
src/core/wxc_common/src/wire.rsRestores legacy wire network model.
src/core/wxc_common/src/models.rsRemoves unused GA egress models.
src/core/wxc_common/src/config_parser.rsRestores legacy network parsing and tests.
src/core/mxc_engine/src/policy.rsRe-enables policy tests.
src/core/mxc_engine/src/dispatch.rsRe-enables dispatch tests.
sdk/node/tests/unit/wire-conformance.test.tsRestores legacy conformance assertions.
sdk/node/src/generated/wire.tsRegenerates legacy wire types.
schemas/dev/mxc-config.schema.0.8.0-dev.jsonRestores legacy generated schema.
.github/workflows/SDK.Integration.Test.Job.ymlRe-enables SDK integration tests.

Review details

  • Files reviewed: 71/72 changed files
  • Comments generated: 2
  • Review effort level: Medium

Comment threadsrc/core/wxc_common/src/config_parser.rs
Comment threadsrc/core/wxc_common/src/config_parser.rs
@MGudgin
Gudge (MGudgin) merged commit da193b5 into mainJul 29, 2026
23 checks passed
@MGudgin
Gudge (MGudgin) deleted the user/gudge/revert_network_schema_changes branch July 29, 2026 19:54
@MGudgin
Gudge (MGudgin) restored the user/gudge/revert_network_schema_changes branch August 25, 2026 20:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MGudgin@bbonaby