Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Impl AsyncWrite for cobertura output - #3431

Open
Teo Voinea (tevoinea) wants to merge 27 commits into
microsoft:mainfrom
tevoinea:tevoinea/ImplAsyncWrite
Open

Impl AsyncWrite for cobertura output#3431
Teo Voinea (tevoinea) wants to merge 27 commits into
microsoft:mainfrom
tevoinea:tevoinea/ImplAsyncWrite

Conversation

@tevoinea

@tevoineaTeo Voinea (tevoinea) commented Aug 18, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR allows us to write the cobertura coverage file asynchronously without need to spawn it in a separate thread.

@codecov-commenter

Codecov Comments Bot (codecov-commenter) commented Aug 18, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3431 (78f0800) into main (896329d) will increase coverage by 0.25%.
The diff coverage is 80.40%.

@@ Coverage Diff @@## main #3431 +/- ##
==========================================
+ Coverage 39.32% 39.58% +0.25% 
==========================================
Files 299 299 Lines 36270 36512 +242 ==========================================
+ Hits 14264 14454 +190 - Misses 22006 22058 +52
Files ChangedCoverage Δ
...c/agent/onefuzz-task/src/tasks/coverage/generic.rs86.42% <80.00%> (-0.21%)⬇️
src/agent/cobertura/src/lib.rs80.30% <80.41%> (-2.39%)⬇️

@AdamL-Microsoft@chkeita
Release 8.7.1 (hotfix) (microsoft#3459)
c69deed
* Remove the retention policy setting (microsoft#3452)
---------
Co-authored-by: Cheick Keita <chkeita@microsoft.com>
@AdamL-Microsoft
Revert "Release 8.7.1 (hotfix) (microsoft#3459)" (microsoft#3468)
c8986aa
This reverts commit c69deed.
@AdamL-Microsoft@chkeita
Redo 8.7.1 (microsoft#3469)
7b40402
* Redo-8.7.1-hotfix
---------
Co-authored-by: Cheick Keita <chkeita@microsoft.com>
@kananb
Support custom ado fields that mark work items as duplicate (microsof…
d999603
…t#3467)
* Add field to ado config for checking duplicate work items
* Make duplicate fields nullable and add it to python models
* Update broken tests
* Update docs to include new ado_duplicate_fields property
@mgreisen@AdamL-Microsoft
Update readme with archive message (microsoft#3408)
b2435b1
Co-authored-by: Adam <103067949+AdamL-Microsoft@users.noreply.github.com>
@dependabot
Bump tokio from 1.30.0 to 1.32.0 in /src/proxy-manager (microsoft#3425)
b913074
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.30.0 to 1.32.0.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.30.0...tokio-1.32.0)
---
updated-dependencies:
- dependency-name: tokio
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump tokio from 1.30.0 to 1.32.0 in /src/agent (microsoft#3424)
14ab36e
Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.30.0 to 1.32.0.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.30.0...tokio-1.32.0)
---
updated-dependencies:
- dependency-name: tokio
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kananb
Remove unnecessary method argument (microsoft#3473)
f141050
@dependabot
Bump elsa from 1.8.1 to 1.9.0 in /src/agent (microsoft#3411)
d4319d2
Bumps [elsa](https://github.com/manishearth/elsa) from 1.8.1 to 1.9.0.
- [Commits](Manishearth/elsa@v1.8.1...v1.9.0)
---
updated-dependencies:
- dependency-name: elsa
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump tempfile from 3.7.1 to 3.8.0 in /src/agent (microsoft#3437)
93b16ec
Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.7.1 to 3.8.0.
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md)
- [Commits](Stebalien/tempfile@v3.7.1...v3.8.0)
---
updated-dependencies:
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump tempfile from 3.7.1 to 3.8.0 in /src/proxy-manager (microsoft#3436)
7f7ab37
Bumps [tempfile](https://github.com/Stebalien/tempfile) from 3.7.1 to 3.8.0.
- [Changelog](https://github.com/Stebalien/tempfile/blob/master/CHANGELOG.md)
- [Commits](Stebalien/tempfile@v3.7.1...v3.8.0)
---
updated-dependencies:
- dependency-name: tempfile
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@nharper285
Updating requirements.txt to accept >= onefuzztypes. (microsoft#3477)
b2e6a07
* Updating requirements.txt to accept >= onefuzztypes.
* Trying to loosen restriction.
@dependabot
Bump notify from 6.0.1 to 6.1.1 in /src/agent (microsoft#3435)
aa9c9ea
Bumps [notify](https://github.com/notify-rs/notify) from 6.0.1 to 6.1.1.
- [Release notes](https://github.com/notify-rs/notify/releases)
- [Changelog](https://github.com/notify-rs/notify/blob/main/CHANGELOG.md)
- [Commits](notify-rs/notify@notify-6.0.1...notify-6.1.1)
---
updated-dependencies:
- dependency-name: notify
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Porges
Bump azure_* crates (microsoft#3478)
74475cc
@AdamL-Microsoft
Release 8.8.0 (microsoft#3466)
64699ed
* Release 8.8.0
@dependabot
Bump clap from 4.3.21 to 4.4.2 in /src/agent (microsoft#3484)
a3fb480
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.21 to 4.4.2.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.3.21...v4.4.2)
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump gimli from 0.27.3 to 0.28.0 in /src/agent (microsoft#3414)
59c52d6
Bumps [gimli](https://github.com/gimli-rs/gimli) from 0.27.3 to 0.28.0.
- [Changelog](https://github.com/gimli-rs/gimli/blob/master/CHANGELOG.md)
- [Commits](gimli-rs/gimli@0.27.3...0.28.0)
---
updated-dependencies:
- dependency-name: gimli
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump clap from 4.3.21 to 4.4.2 in /src/proxy-manager (microsoft#3474)
dd9e266
Bumps [clap](https://github.com/clap-rs/clap) from 4.3.21 to 4.4.2.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.3.21...v4.4.2)
---
updated-dependencies:
- dependency-name: clap
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot@AdamL-Microsoft
Bump winreg from 0.50.0 to 0.51.0 in /src/agent (microsoft#3434)
6e2cb14
Bumps [winreg](https://github.com/gentoo90/winreg-rs) from 0.50.0 to 0.51.0.
- [Release notes](https://github.com/gentoo90/winreg-rs/releases)
- [Changelog](https://github.com/gentoo90/winreg-rs/blob/master/CHANGELOG.md)
- [Commits](gentoo90/winreg-rs@v0.50.0...v0.51.0)
---
updated-dependencies:
- dependency-name: winreg
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Adam <103067949+AdamL-Microsoft@users.noreply.github.com>
@tevoinea
Starting integration tests (microsoft#3438)
d2d57a8
* Starting integration tests
* Ready to test the test
* Parametrize test
* checkpoint
* Test works
* Run integration tests in pipeline
* fmt
* .
* -p
* Install clang
* quotes not required in yaml?
* Hopefully fixed windows?
* Try without killondrop
* lint
* small test
* another test
* Reuse core name
* Wrong step
* bump tokio?
* Try with rust
* make build happy
* Bump pete and small clean up
* Clean up and make the test pass regularly
* fix broken ci
* Lower the poll timeout
* Set the timeout in a nicer way
* fix windows
* fmt
* Include and copy pdbs
* Ignore if pdb is missing on linux
* It takes too long for coverage to be generated
* lint
* Only warn on missing coverage since it's flaky
* Fix windows build
* Small clean up
* Try lowering the poll delay
* fix coverage
* PR comments
* .
* Apparently make is missing?
* Remove aggressive step skipping in CI
@nharper285
Fix sed checks for CLI versioning (microsoft#3486)
830b479
* Fix sed checks for CLI versioning
* Fix.
* Fix.
* Changing build_cli
* Trying greater than
* Tring once more.
* Trying major minor
* trying to replace major minor
* Using major minor
@dependabot
Bump bytes from 1.4.0 to 1.5.0 in /src/agent (microsoft#3488)
896329d
Bumps [bytes](https://github.com/tokio-rs/bytes) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/tokio-rs/bytes/releases)
- [Changelog](https://github.com/tokio-rs/bytes/blob/master/CHANGELOG.md)
- [Commits](tokio-rs/bytes@v1.4.0...v1.5.0)
---
updated-dependencies:
- dependency-name: bytes
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tevoinea
Merge branch 'main' ofhttps://github.com/microsoft/onefuzzinto tevo…
3dcd4bc
…inea/ImplAsyncWrite
@tevoinea
Demo async cobertura writing
a0f9a84
@tevoinea
Fix CI
78f0800
@tevoinea
Teo Voinea (tevoinea) marked this pull request as ready for review September 11, 2023 19:12
tevoinea
Teo Voinea (tevoinea) commented Sep 11, 2023
View reviewed changes
Comment threadsrc/agent/cobertura/Cargo.toml Outdated
[dependencies]
anyhow = "1.0"
quick-xml = "0.30"
quick-xml = { git = "https://github.com/tevoinea/quick-xml/", branch = "tevoinea/AsyncElementWriter", features = [

@tevoineaTeo Voinea (tevoinea)Sep 11, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only temporary until my PR gets reviewed and merged. tafia/quick-xml#635

Porges
George Pollard (Porges) reviewed Sep 11, 2023
View reviewed changes
Comment threadsrc/agent/cobertura/src/lib.rs Outdated
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chkeitaCheick Keita (chkeita)Awaiting requested review from chkeita
1 more reviewer
@PorgesGeorge Pollard (Porges)Porges approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tevoinea@codecov-commenter@Porges@AdamL-Microsoft@kananb@mgreisen@nharper285