Skip to content

[js/webgpu] validate transpose perm if specified - #23197

Merged
Yulong Wang (fs-eire) merged 2 commits into
microsoft:mainfrom
xhcao:transpose
Jan 1, 2025
Merged

[js/webgpu] validate transpose perm if specified#23197
Yulong Wang (fs-eire) merged 2 commits into
microsoft:mainfrom
xhcao:transpose

Conversation

@xhcao

@xhcao xhcao commented Dec 26, 2024

Copy link
Copy Markdown
Contributor

Description

Motivation and Context

@xhcao
xhcao marked this pull request as ready for review December 26, 2024 07:12
@xhcao

xhcao commented Dec 26, 2024

Copy link
Copy Markdown
Contributor Author

If the users specifies the perm for transpose operator, the users should ensure its size match the input rank, we does not use default perm, which may be not the expected perm for the users, the result is not correct although there is no error message.
CPU EP and Cuda EP will throw an error message if perm does not match input rank.

onnxruntime/onnxruntime/core/providers/cpu/tensor/transpose.h

Line 79 in 2d05c4b

if (p_perm->size() != rank) {

And I find the problem when investigating the issue #22994, the problem makes debugging more difficult.
Yulong Wang (@fs-eire) Guenther Schmuelling (@guschmue) PTAL.
@Jie Chen (@jchen10) Jiajie Hu (@hujiajie)

@jchen10

Jie Chen (jchen10) commented Dec 26, 2024

Copy link
Copy Markdown
Contributor

Good job, Xinghua!

@snnn Changming Sun (snnn) added the ep:WebGPU ort-web webgpu provider label Dec 30, 2024
@fs-eire

Yulong Wang (fs-eire) commented Dec 30, 2024

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Dec 30, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

fs-eire
Yulong Wang (fs-eire) reviewed Dec 30, 2024
View reviewed changes
Comment thread js/web/lib/wasm/jsep/webgpu/ops/transpose.ts Outdated
fs-eire
Yulong Wang (fs-eire) reviewed Dec 30, 2024
View reviewed changes
Comment thread js/web/lib/wasm/jsep/webgpu/ops/transpose.ts Outdated
fs-eire
Yulong Wang (fs-eire) reviewed Dec 30, 2024
View reviewed changes
Comment thread js/web/lib/wasm/jsep/webgpu/ops/transpose.ts Outdated
fs-eire
Yulong Wang (fs-eire) reviewed Dec 30, 2024
View reviewed changes
Comment thread js/web/lib/wasm/jsep/webgpu/ops/transpose.ts Outdated
xhcao
xhcao commented Dec 31, 2024
View reviewed changes

@xhcao xhcao left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yulong, Thanks for your comments

Comment thread js/web/lib/wasm/jsep/webgpu/ops/transpose.ts Outdated
Comment thread js/web/lib/wasm/jsep/webgpu/ops/transpose.ts Outdated
Comment thread js/web/lib/wasm/jsep/webgpu/ops/transpose.ts Outdated
Comment thread js/web/lib/wasm/jsep/webgpu/ops/transpose.ts Outdated
@fs-eire

Yulong Wang (fs-eire) commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline

@fs-eire

Yulong Wang (fs-eire) commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline

@fs-eire

Yulong Wang (fs-eire) commented Jan 1, 2025

Copy link
Copy Markdown
Contributor

/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Jan 1, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines

azure-pipelines Bot commented Jan 1, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines

azure-pipelines Bot commented Jan 1, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@fs-eire
Yulong Wang (fs-eire) merged commit a3833a5 into microsoft:main Jan 1, 2025
Changming Sun (snnn) pushed a commit that referenced this pull request Jan 8, 2025
@xhcao Changming Sun
[js/webgpu] validate transpose perm if specified (#23197)
7ee48cb 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Tarek Ziade (tarekziade) pushed a commit to tarekziade/onnxruntime that referenced this pull request Jan 10, 2025
@xhcao @tarekziade
[js/webgpu] validate transpose perm if specified (microsoft#23197)
2f6e524 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Guenther Schmuelling (guschmue) pushed a commit that referenced this pull request Jan 12, 2025
@xhcao Guenther Schmuelling
[js/webgpu] validate transpose perm if specified (#23197)
686df71 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Ashrit Shetty (ashrit-ms) pushed a commit that referenced this pull request Mar 17, 2025
@xhcao @ashrit-ms
[js/webgpu] validate transpose perm if specified (#23197)
85fa191 
### Description
<!-- Describe your changes. -->



### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@fs-eire Yulong Wang (fs-eire) fs-eire approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ep:WebGPU ort-web webgpu provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xhcao @jchen10 @fs-eire @snnn