Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ Playwright is a Java library to automate [Chromium](https://www.chromium.org/Hom
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->148.0.7778.96<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| WebKit <!-- GEN:webkit-version -->26.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->150.0.1<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| Firefox <!-- GEN:firefox-version -->150.0.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |

## Documentation

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@
public interface Screencast {
class StartOptions {
/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public Consumer<ScreencastFrame> onFrame;
/**
Expand All@@ -40,7 +40,7 @@ class StartOptions {
public Integer quality;

/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public StartOptions setOnFrame(Consumer<ScreencastFrame> onFrame) {
this.onFrame = onFrame;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,19 +14,21 @@
* limitations under the License.
*/

package com.microsoft.playwright.options;
package com.microsoft.playwright;

/**
* A single screencast frame delivered to {@link com.microsoft.playwright.Screencast#start Screencast.start()}'s
* {@code onFrame} callback.
*/
public class ScreencastFrame {
public interface ScreencastFrame {
/**
* JPEG-encoded frame data.
*/
public byte[] data;
byte[] data();

/**
* Width of the page viewport at the time the frame was captured.
*/
int viewportWidth();

public ScreencastFrame(byte[] data) {
this.data = data;
}
}
/**
* Height of the page viewport at the time the frame was captured.
*/
int viewportHeight();
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
/*
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.microsoft.playwright.impl;

import com.microsoft.playwright.ScreencastFrame;

class ScreencastFrameImpl implements ScreencastFrame {
private final byte[] data;
private final int viewportWidth;
private final int viewportHeight;

ScreencastFrameImpl(byte[] data, int viewportWidth, int viewportHeight) {
this.data = data;
this.viewportWidth = viewportWidth;
this.viewportHeight = viewportHeight;
}

@Override
public byte[] data() {
return data;
}

@Override
public int viewportWidth() {
return viewportWidth;
}

@Override
public int viewportHeight() {
return viewportHeight;
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@
import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;
import com.microsoft.playwright.Screencast;
import com.microsoft.playwright.options.ScreencastFrame;
import com.microsoft.playwright.ScreencastFrame;

import java.nio.file.Path;
import java.util.function.Consumer;
Expand All@@ -44,7 +44,9 @@ void handleScreencastFrame(JsonObject params) {
}
String dataBase64 = params.get("data").getAsString();
byte[] data = java.util.Base64.getDecoder().decode(dataBase64);
onFrame.accept(new ScreencastFrame(data));
int viewportWidth = params.get("viewportWidth").getAsInt();
int viewportHeight = params.get("viewportHeight").getAsInt();
onFrame.accept(new ScreencastFrameImpl(data, viewportWidth, viewportHeight));
}

@Override
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@

package com.microsoft.playwright;

import com.microsoft.playwright.options.ScreencastFrame;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand DownExpand Up@@ -113,9 +112,30 @@ void screencastStartShouldDeliverFramesViaOnFrame() throws Exception {
assertFalse(frames.isEmpty(), "expected at least one frame");
// JPEG-encoded frames start with FF D8.
for (ScreencastFrame frame : frames) {
assertNotNull(frame.data);
assertEquals((byte) 0xFF, frame.data[0]);
assertEquals((byte) 0xD8, frame.data[1]);
assertNotNull(frame.data());
assertEquals((byte) 0xFF, frame.data()[0]);
assertEquals((byte) 0xD8, frame.data()[1]);
}
} finally {
context.close();
}
}

@Test
void onFrameShouldReceiveViewportSize() {
BrowserContext context = browser.newContext(new Browser.NewContextOptions().setViewportSize(1000, 400));
Page page = context.newPage();
try {
List<ScreencastFrame> frames = new ArrayList<>();
page.screencast().start(new Screencast.StartOptions().setOnFrame(frames::add));
page.navigate(server.EMPTY_PAGE);
page.evaluate("() => document.body.style.backgroundColor = 'red'");
page.waitForTimeout(500);
page.screencast().stop();
assertFalse(frames.isEmpty(), "expected at least one frame");
for (ScreencastFrame frame : frames) {
assertEquals(1000, frame.viewportWidth());
assertEquals(400, frame.viewportHeight());
}
} finally {
context.close();
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1.60.0-alpha-1778025033000
1.60.0-beta-1778180503000
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,6 +326,22 @@ private void createClassesAndEnums(JsonObject jsonObject) {
}
return;
}
if ("function".equals(jsonObject.get("name").getAsString()) && jsonObject.has("args")) {
for (JsonElement item : jsonObject.getAsJsonArray("args")) {
if (!item.isJsonObject()) {
continue;
}
JsonObject argObject = item.getAsJsonObject();
if (!"Object".equals(argObject.get("name").getAsString())) {
continue;
}
String alias = javaAlias(argObject);
if (alias != null) {
typeScope().createTopLevelInterface(alias, this, argObject);
}
}
return;
}
if ("Object".equals(jsonObject.get("name").getAsString())) {
if (customType != null) {
// Same type maybe referenced as 'Object' in several union values, e.g. Object|Array<Object>
Expand DownExpand Up@@ -506,8 +522,8 @@ private String convertBuiltinType(JsonObject jsonType) {
if (customType != null) {
return customType;
}
// Inner Objects (e.g. function arguments) are not visited by createClassesAndEnums,
// so resolve their Java type name from langAliases here.
// Inner Objects without langAliases (e.g. unaliased function arguments) are not visited
// by createClassesAndEnums, so resolve their Java type name from langAliases here.
String alias = javaAlias(jsonType);
if (alias != null) {
return alias;
Expand DownExpand Up@@ -601,6 +617,14 @@ void createTopLevelClass(String name, Element parent, JsonObject jsonObject) {
}
}

void createTopLevelInterface(String name, Element parent, JsonObject jsonObject) {
Map<String, TypeDefinition> map = topLevelTypes();
TypeDefinition existing = map.putIfAbsent(name, new CustomInterface(parent, name, jsonObject));
if (existing != null && !(existing instanceof CustomInterface)) {
throw new RuntimeException("Two interfaces with same name have different values:\n" + jsonObject + "\n" + existing.jsonElement);
}
}

void createNestedClass(String name, Element parent, JsonObject jsonObject) {
for (CustomClass c : classes) {
if (c.name.equals(name)) {
Expand DownExpand Up@@ -840,7 +864,7 @@ class Field extends Element {
final String name;
final TypeRef type;

Field(CustomClass parent, String name, JsonObject jsonElement) {
Field(TypeDefinition parent, String name, JsonObject jsonElement) {
super(parent, jsonElement);
this.name = name;
this.type = new TypeRef(this, jsonElement.getAsJsonObject().get("type"));
Expand DownExpand Up@@ -1151,6 +1175,43 @@ private void writeConstructor(List<String> output, String bodyOffset) {
}
}

class CustomInterface extends TypeDefinition {
final String name;
final List<Field> fields = new ArrayList<>();

CustomInterface(Element parent, String name, JsonObject jsonElement) {
super(parent, true, jsonElement);
this.name = name;
if (jsonElement.has("properties")) {
for (JsonElement item : jsonElement.getAsJsonArray("properties")) {
JsonObject propertyJson = item.getAsJsonObject();
fields.add(new Field(this, propertyJson.get("name").getAsString(), propertyJson));
}
}
}

@Override
String name() {
return name;
}

@Override
void writeTo(List<String> output, String offset) {
output.add(offset + "public interface " + name + " {");
String bodyOffset = offset + " ";
boolean first = true;
for (Field f : fields) {
if (!first) {
output.add("");
}
first = false;
writeJavadoc(output, bodyOffset, f.comment());
output.add(bodyOffset + f.type.toJava() + " " + f.name + "();");
}
output.add(offset + "}");
}
}

class Enum extends TypeDefinition {
final List<String> enumValues;

Expand DownExpand Up@@ -1199,18 +1260,25 @@ public class ApiGenerator {
System.out.println("Writing assertion files to: " + dir.getCanonicalPath());
generate(api, assertionsDir, "com.microsoft.playwright.assertions", isAssertion().and(isSoftAssertion().negate()), sharedTypes);

writeTopLevelTypes(sharedTypes, optionsDir, "com.microsoft.playwright");
writeTopLevelTypes(sharedTypes, dir, optionsDir, "com.microsoft.playwright");
}

private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File optionsDir, String packageName) throws IOException {
private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File dir, File optionsDir, String packageName) throws IOException {
for (TypeDefinition e : topLevelTypes.values()) {
List<String> lines = new ArrayList<>();
lines.add(Interface.header);
lines.add("package " + packageName + ".options;");
File targetDir;
if (e instanceof CustomInterface) {
lines.add("package " + packageName + ";");
targetDir = dir;
} else {
lines.add("package " + packageName + ".options;");
targetDir = optionsDir;
}
lines.add("");
e.writeTo(lines, "");
String text = String.join("\n", lines);
try (FileWriter writer = new FileWriter(new File(optionsDir, e.name() + ".java"))) {
try (FileWriter writer = new FileWriter(new File(targetDir, e.name() + ".java"))) {
writer.write(text);
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore: roll driver to 1.60.0-beta-1778180503000 by yury-s · Pull Request #1918 · microsoft/playwright-java · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ Playwright is a Java library to automate [Chromium](https://www.chromium.org/Hom
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->148.0.7778.96<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| WebKit <!-- GEN:webkit-version -->26.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->150.0.1<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| Firefox <!-- GEN:firefox-version -->150.0.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |

## Documentation

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@
public interface Screencast {
class StartOptions {
/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public Consumer<ScreencastFrame> onFrame;
/**
Expand All@@ -40,7 +40,7 @@ class StartOptions {
public Integer quality;

/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public StartOptions setOnFrame(Consumer<ScreencastFrame> onFrame) {
this.onFrame = onFrame;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,19 +14,21 @@
* limitations under the License.
*/

package com.microsoft.playwright.options;
package com.microsoft.playwright;

/**
* A single screencast frame delivered to {@link com.microsoft.playwright.Screencast#start Screencast.start()}'s
* {@code onFrame} callback.
*/
public class ScreencastFrame {
public interface ScreencastFrame {
/**
* JPEG-encoded frame data.
*/
public byte[] data;
byte[] data();

/**
* Width of the page viewport at the time the frame was captured.
*/
int viewportWidth();

public ScreencastFrame(byte[] data) {
this.data = data;
}
}
/**
* Height of the page viewport at the time the frame was captured.
*/
int viewportHeight();
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
/*
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.microsoft.playwright.impl;

import com.microsoft.playwright.ScreencastFrame;

class ScreencastFrameImpl implements ScreencastFrame {
private final byte[] data;
private final int viewportWidth;
private final int viewportHeight;

ScreencastFrameImpl(byte[] data, int viewportWidth, int viewportHeight) {
this.data = data;
this.viewportWidth = viewportWidth;
this.viewportHeight = viewportHeight;
}

@Override
public byte[] data() {
return data;
}

@Override
public int viewportWidth() {
return viewportWidth;
}

@Override
public int viewportHeight() {
return viewportHeight;
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@
import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;
import com.microsoft.playwright.Screencast;
import com.microsoft.playwright.options.ScreencastFrame;
import com.microsoft.playwright.ScreencastFrame;

import java.nio.file.Path;
import java.util.function.Consumer;
Expand All@@ -44,7 +44,9 @@ void handleScreencastFrame(JsonObject params) {
}
String dataBase64 = params.get("data").getAsString();
byte[] data = java.util.Base64.getDecoder().decode(dataBase64);
onFrame.accept(new ScreencastFrame(data));
int viewportWidth = params.get("viewportWidth").getAsInt();
int viewportHeight = params.get("viewportHeight").getAsInt();
onFrame.accept(new ScreencastFrameImpl(data, viewportWidth, viewportHeight));
}

@Override
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@

package com.microsoft.playwright;

import com.microsoft.playwright.options.ScreencastFrame;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand DownExpand Up@@ -113,9 +112,30 @@ void screencastStartShouldDeliverFramesViaOnFrame() throws Exception {
assertFalse(frames.isEmpty(), "expected at least one frame");
// JPEG-encoded frames start with FF D8.
for (ScreencastFrame frame : frames) {
assertNotNull(frame.data);
assertEquals((byte) 0xFF, frame.data[0]);
assertEquals((byte) 0xD8, frame.data[1]);
assertNotNull(frame.data());
assertEquals((byte) 0xFF, frame.data()[0]);
assertEquals((byte) 0xD8, frame.data()[1]);
}
} finally {
context.close();
}
}

@Test
void onFrameShouldReceiveViewportSize() {
BrowserContext context = browser.newContext(new Browser.NewContextOptions().setViewportSize(1000, 400));
Page page = context.newPage();
try {
List<ScreencastFrame> frames = new ArrayList<>();
page.screencast().start(new Screencast.StartOptions().setOnFrame(frames::add));
page.navigate(server.EMPTY_PAGE);
page.evaluate("() => document.body.style.backgroundColor = 'red'");
page.waitForTimeout(500);
page.screencast().stop();
assertFalse(frames.isEmpty(), "expected at least one frame");
for (ScreencastFrame frame : frames) {
assertEquals(1000, frame.viewportWidth());
assertEquals(400, frame.viewportHeight());
}
} finally {
context.close();
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1.60.0-alpha-1778025033000
1.60.0-beta-1778180503000
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,6 +326,22 @@ private void createClassesAndEnums(JsonObject jsonObject) {
}
return;
}
if ("function".equals(jsonObject.get("name").getAsString()) && jsonObject.has("args")) {
for (JsonElement item : jsonObject.getAsJsonArray("args")) {
if (!item.isJsonObject()) {
continue;
}
JsonObject argObject = item.getAsJsonObject();
if (!"Object".equals(argObject.get("name").getAsString())) {
continue;
}
String alias = javaAlias(argObject);
if (alias != null) {
typeScope().createTopLevelInterface(alias, this, argObject);
}
}
return;
}
if ("Object".equals(jsonObject.get("name").getAsString())) {
if (customType != null) {
// Same type maybe referenced as 'Object' in several union values, e.g. Object|Array<Object>
Expand DownExpand Up@@ -506,8 +522,8 @@ private String convertBuiltinType(JsonObject jsonType) {
if (customType != null) {
return customType;
}
// Inner Objects (e.g. function arguments) are not visited by createClassesAndEnums,
// so resolve their Java type name from langAliases here.
// Inner Objects without langAliases (e.g. unaliased function arguments) are not visited
// by createClassesAndEnums, so resolve their Java type name from langAliases here.
String alias = javaAlias(jsonType);
if (alias != null) {
return alias;
Expand DownExpand Up@@ -601,6 +617,14 @@ void createTopLevelClass(String name, Element parent, JsonObject jsonObject) {
}
}

void createTopLevelInterface(String name, Element parent, JsonObject jsonObject) {
Map<String, TypeDefinition> map = topLevelTypes();
TypeDefinition existing = map.putIfAbsent(name, new CustomInterface(parent, name, jsonObject));
if (existing != null && !(existing instanceof CustomInterface)) {
throw new RuntimeException("Two interfaces with same name have different values:\n" + jsonObject + "\n" + existing.jsonElement);
}
}

void createNestedClass(String name, Element parent, JsonObject jsonObject) {
for (CustomClass c : classes) {
if (c.name.equals(name)) {
Expand DownExpand Up@@ -840,7 +864,7 @@ class Field extends Element {
final String name;
final TypeRef type;

Field(CustomClass parent, String name, JsonObject jsonElement) {
Field(TypeDefinition parent, String name, JsonObject jsonElement) {
super(parent, jsonElement);
this.name = name;
this.type = new TypeRef(this, jsonElement.getAsJsonObject().get("type"));
Expand DownExpand Up@@ -1151,6 +1175,43 @@ private void writeConstructor(List<String> output, String bodyOffset) {
}
}

class CustomInterface extends TypeDefinition {
final String name;
final List<Field> fields = new ArrayList<>();

CustomInterface(Element parent, String name, JsonObject jsonElement) {
super(parent, true, jsonElement);
this.name = name;
if (jsonElement.has("properties")) {
for (JsonElement item : jsonElement.getAsJsonArray("properties")) {
JsonObject propertyJson = item.getAsJsonObject();
fields.add(new Field(this, propertyJson.get("name").getAsString(), propertyJson));
}
}
}

@Override
String name() {
return name;
}

@Override
void writeTo(List<String> output, String offset) {
output.add(offset + "public interface " + name + " {");
String bodyOffset = offset + " ";
boolean first = true;
for (Field f : fields) {
if (!first) {
output.add("");
}
first = false;
writeJavadoc(output, bodyOffset, f.comment());
output.add(bodyOffset + f.type.toJava() + " " + f.name + "();");
}
output.add(offset + "}");
}
}

class Enum extends TypeDefinition {
final List<String> enumValues;

Expand DownExpand Up@@ -1199,18 +1260,25 @@ public class ApiGenerator {
System.out.println("Writing assertion files to: " + dir.getCanonicalPath());
generate(api, assertionsDir, "com.microsoft.playwright.assertions", isAssertion().and(isSoftAssertion().negate()), sharedTypes);

writeTopLevelTypes(sharedTypes, optionsDir, "com.microsoft.playwright");
writeTopLevelTypes(sharedTypes, dir, optionsDir, "com.microsoft.playwright");
}

private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File optionsDir, String packageName) throws IOException {
private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File dir, File optionsDir, String packageName) throws IOException {
for (TypeDefinition e : topLevelTypes.values()) {
List<String> lines = new ArrayList<>();
lines.add(Interface.header);
lines.add("package " + packageName + ".options;");
File targetDir;
if (e instanceof CustomInterface) {
lines.add("package " + packageName + ";");
targetDir = dir;
} else {
lines.add("package " + packageName + ".options;");
targetDir = optionsDir;
}
lines.add("");
e.writeTo(lines, "");
String text = String.join("\n", lines);
try (FileWriter writer = new FileWriter(new File(optionsDir, e.name() + ".java"))) {
try (FileWriter writer = new FileWriter(new File(targetDir, e.name() + ".java"))) {
writer.write(text);
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: roll driver to 1.60.0-beta-1778180503000 by yury-s · Pull Request #1918 · microsoft/playwright-java · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ Playwright is a Java library to automate [Chromium](https://www.chromium.org/Hom
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->148.0.7778.96<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| WebKit <!-- GEN:webkit-version -->26.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->150.0.1<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| Firefox <!-- GEN:firefox-version -->150.0.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |

## Documentation

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@
public interface Screencast {
class StartOptions {
/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public Consumer<ScreencastFrame> onFrame;
/**
Expand All@@ -40,7 +40,7 @@ class StartOptions {
public Integer quality;

/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public StartOptions setOnFrame(Consumer<ScreencastFrame> onFrame) {
this.onFrame = onFrame;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,19 +14,21 @@
* limitations under the License.
*/

package com.microsoft.playwright.options;
package com.microsoft.playwright;

/**
* A single screencast frame delivered to {@link com.microsoft.playwright.Screencast#start Screencast.start()}'s
* {@code onFrame} callback.
*/
public class ScreencastFrame {
public interface ScreencastFrame {
/**
* JPEG-encoded frame data.
*/
public byte[] data;
byte[] data();

/**
* Width of the page viewport at the time the frame was captured.
*/
int viewportWidth();

public ScreencastFrame(byte[] data) {
this.data = data;
}
}
/**
* Height of the page viewport at the time the frame was captured.
*/
int viewportHeight();
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
/*
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.microsoft.playwright.impl;

import com.microsoft.playwright.ScreencastFrame;

class ScreencastFrameImpl implements ScreencastFrame {
private final byte[] data;
private final int viewportWidth;
private final int viewportHeight;

ScreencastFrameImpl(byte[] data, int viewportWidth, int viewportHeight) {
this.data = data;
this.viewportWidth = viewportWidth;
this.viewportHeight = viewportHeight;
}

@Override
public byte[] data() {
return data;
}

@Override
public int viewportWidth() {
return viewportWidth;
}

@Override
public int viewportHeight() {
return viewportHeight;
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@
import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;
import com.microsoft.playwright.Screencast;
import com.microsoft.playwright.options.ScreencastFrame;
import com.microsoft.playwright.ScreencastFrame;

import java.nio.file.Path;
import java.util.function.Consumer;
Expand All@@ -44,7 +44,9 @@ void handleScreencastFrame(JsonObject params) {
}
String dataBase64 = params.get("data").getAsString();
byte[] data = java.util.Base64.getDecoder().decode(dataBase64);
onFrame.accept(new ScreencastFrame(data));
int viewportWidth = params.get("viewportWidth").getAsInt();
int viewportHeight = params.get("viewportHeight").getAsInt();
onFrame.accept(new ScreencastFrameImpl(data, viewportWidth, viewportHeight));
}

@Override
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@

package com.microsoft.playwright;

import com.microsoft.playwright.options.ScreencastFrame;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand DownExpand Up@@ -113,9 +112,30 @@ void screencastStartShouldDeliverFramesViaOnFrame() throws Exception {
assertFalse(frames.isEmpty(), "expected at least one frame");
// JPEG-encoded frames start with FF D8.
for (ScreencastFrame frame : frames) {
assertNotNull(frame.data);
assertEquals((byte) 0xFF, frame.data[0]);
assertEquals((byte) 0xD8, frame.data[1]);
assertNotNull(frame.data());
assertEquals((byte) 0xFF, frame.data()[0]);
assertEquals((byte) 0xD8, frame.data()[1]);
}
} finally {
context.close();
}
}

@Test
void onFrameShouldReceiveViewportSize() {
BrowserContext context = browser.newContext(new Browser.NewContextOptions().setViewportSize(1000, 400));
Page page = context.newPage();
try {
List<ScreencastFrame> frames = new ArrayList<>();
page.screencast().start(new Screencast.StartOptions().setOnFrame(frames::add));
page.navigate(server.EMPTY_PAGE);
page.evaluate("() => document.body.style.backgroundColor = 'red'");
page.waitForTimeout(500);
page.screencast().stop();
assertFalse(frames.isEmpty(), "expected at least one frame");
for (ScreencastFrame frame : frames) {
assertEquals(1000, frame.viewportWidth());
assertEquals(400, frame.viewportHeight());
}
} finally {
context.close();
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1.60.0-alpha-1778025033000
1.60.0-beta-1778180503000
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,6 +326,22 @@ private void createClassesAndEnums(JsonObject jsonObject) {
}
return;
}
if ("function".equals(jsonObject.get("name").getAsString()) && jsonObject.has("args")) {
for (JsonElement item : jsonObject.getAsJsonArray("args")) {
if (!item.isJsonObject()) {
continue;
}
JsonObject argObject = item.getAsJsonObject();
if (!"Object".equals(argObject.get("name").getAsString())) {
continue;
}
String alias = javaAlias(argObject);
if (alias != null) {
typeScope().createTopLevelInterface(alias, this, argObject);
}
}
return;
}
if ("Object".equals(jsonObject.get("name").getAsString())) {
if (customType != null) {
// Same type maybe referenced as 'Object' in several union values, e.g. Object|Array<Object>
Expand DownExpand Up@@ -506,8 +522,8 @@ private String convertBuiltinType(JsonObject jsonType) {
if (customType != null) {
return customType;
}
// Inner Objects (e.g. function arguments) are not visited by createClassesAndEnums,
// so resolve their Java type name from langAliases here.
// Inner Objects without langAliases (e.g. unaliased function arguments) are not visited
// by createClassesAndEnums, so resolve their Java type name from langAliases here.
String alias = javaAlias(jsonType);
if (alias != null) {
return alias;
Expand DownExpand Up@@ -601,6 +617,14 @@ void createTopLevelClass(String name, Element parent, JsonObject jsonObject) {
}
}

void createTopLevelInterface(String name, Element parent, JsonObject jsonObject) {
Map<String, TypeDefinition> map = topLevelTypes();
TypeDefinition existing = map.putIfAbsent(name, new CustomInterface(parent, name, jsonObject));
if (existing != null && !(existing instanceof CustomInterface)) {
throw new RuntimeException("Two interfaces with same name have different values:\n" + jsonObject + "\n" + existing.jsonElement);
}
}

void createNestedClass(String name, Element parent, JsonObject jsonObject) {
for (CustomClass c : classes) {
if (c.name.equals(name)) {
Expand DownExpand Up@@ -840,7 +864,7 @@ class Field extends Element {
final String name;
final TypeRef type;

Field(CustomClass parent, String name, JsonObject jsonElement) {
Field(TypeDefinition parent, String name, JsonObject jsonElement) {
super(parent, jsonElement);
this.name = name;
this.type = new TypeRef(this, jsonElement.getAsJsonObject().get("type"));
Expand DownExpand Up@@ -1151,6 +1175,43 @@ private void writeConstructor(List<String> output, String bodyOffset) {
}
}

class CustomInterface extends TypeDefinition {
final String name;
final List<Field> fields = new ArrayList<>();

CustomInterface(Element parent, String name, JsonObject jsonElement) {
super(parent, true, jsonElement);
this.name = name;
if (jsonElement.has("properties")) {
for (JsonElement item : jsonElement.getAsJsonArray("properties")) {
JsonObject propertyJson = item.getAsJsonObject();
fields.add(new Field(this, propertyJson.get("name").getAsString(), propertyJson));
}
}
}

@Override
String name() {
return name;
}

@Override
void writeTo(List<String> output, String offset) {
output.add(offset + "public interface " + name + " {");
String bodyOffset = offset + " ";
boolean first = true;
for (Field f : fields) {
if (!first) {
output.add("");
}
first = false;
writeJavadoc(output, bodyOffset, f.comment());
output.add(bodyOffset + f.type.toJava() + " " + f.name + "();");
}
output.add(offset + "}");
}
}

class Enum extends TypeDefinition {
final List<String> enumValues;

Expand DownExpand Up@@ -1199,18 +1260,25 @@ public class ApiGenerator {
System.out.println("Writing assertion files to: " + dir.getCanonicalPath());
generate(api, assertionsDir, "com.microsoft.playwright.assertions", isAssertion().and(isSoftAssertion().negate()), sharedTypes);

writeTopLevelTypes(sharedTypes, optionsDir, "com.microsoft.playwright");
writeTopLevelTypes(sharedTypes, dir, optionsDir, "com.microsoft.playwright");
}

private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File optionsDir, String packageName) throws IOException {
private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File dir, File optionsDir, String packageName) throws IOException {
for (TypeDefinition e : topLevelTypes.values()) {
List<String> lines = new ArrayList<>();
lines.add(Interface.header);
lines.add("package " + packageName + ".options;");
File targetDir;
if (e instanceof CustomInterface) {
lines.add("package " + packageName + ";");
targetDir = dir;
} else {
lines.add("package " + packageName + ".options;");
targetDir = optionsDir;
}
lines.add("");
e.writeTo(lines, "");
String text = String.join("\n", lines);
try (FileWriter writer = new FileWriter(new File(optionsDir, e.name() + ".java"))) {
try (FileWriter writer = new FileWriter(new File(targetDir, e.name() + ".java"))) {
writer.write(text);
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: roll driver to 1.60.0-beta-1778180503000 by yury-s · Pull Request #1918 · microsoft/playwright-java · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ Playwright is a Java library to automate [Chromium](https://www.chromium.org/Hom
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->148.0.7778.96<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| WebKit <!-- GEN:webkit-version -->26.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->150.0.1<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| Firefox <!-- GEN:firefox-version -->150.0.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |

## Documentation

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@
public interface Screencast {
class StartOptions {
/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public Consumer<ScreencastFrame> onFrame;
/**
Expand All@@ -40,7 +40,7 @@ class StartOptions {
public Integer quality;

/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public StartOptions setOnFrame(Consumer<ScreencastFrame> onFrame) {
this.onFrame = onFrame;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,19 +14,21 @@
* limitations under the License.
*/

package com.microsoft.playwright.options;
package com.microsoft.playwright;

/**
* A single screencast frame delivered to {@link com.microsoft.playwright.Screencast#start Screencast.start()}'s
* {@code onFrame} callback.
*/
public class ScreencastFrame {
public interface ScreencastFrame {
/**
* JPEG-encoded frame data.
*/
public byte[] data;
byte[] data();

/**
* Width of the page viewport at the time the frame was captured.
*/
int viewportWidth();

public ScreencastFrame(byte[] data) {
this.data = data;
}
}
/**
* Height of the page viewport at the time the frame was captured.
*/
int viewportHeight();
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
/*
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.microsoft.playwright.impl;

import com.microsoft.playwright.ScreencastFrame;

class ScreencastFrameImpl implements ScreencastFrame {
private final byte[] data;
private final int viewportWidth;
private final int viewportHeight;

ScreencastFrameImpl(byte[] data, int viewportWidth, int viewportHeight) {
this.data = data;
this.viewportWidth = viewportWidth;
this.viewportHeight = viewportHeight;
}

@Override
public byte[] data() {
return data;
}

@Override
public int viewportWidth() {
return viewportWidth;
}

@Override
public int viewportHeight() {
return viewportHeight;
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@
import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;
import com.microsoft.playwright.Screencast;
import com.microsoft.playwright.options.ScreencastFrame;
import com.microsoft.playwright.ScreencastFrame;

import java.nio.file.Path;
import java.util.function.Consumer;
Expand All@@ -44,7 +44,9 @@ void handleScreencastFrame(JsonObject params) {
}
String dataBase64 = params.get("data").getAsString();
byte[] data = java.util.Base64.getDecoder().decode(dataBase64);
onFrame.accept(new ScreencastFrame(data));
int viewportWidth = params.get("viewportWidth").getAsInt();
int viewportHeight = params.get("viewportHeight").getAsInt();
onFrame.accept(new ScreencastFrameImpl(data, viewportWidth, viewportHeight));
}

@Override
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@

package com.microsoft.playwright;

import com.microsoft.playwright.options.ScreencastFrame;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand DownExpand Up@@ -113,9 +112,30 @@ void screencastStartShouldDeliverFramesViaOnFrame() throws Exception {
assertFalse(frames.isEmpty(), "expected at least one frame");
// JPEG-encoded frames start with FF D8.
for (ScreencastFrame frame : frames) {
assertNotNull(frame.data);
assertEquals((byte) 0xFF, frame.data[0]);
assertEquals((byte) 0xD8, frame.data[1]);
assertNotNull(frame.data());
assertEquals((byte) 0xFF, frame.data()[0]);
assertEquals((byte) 0xD8, frame.data()[1]);
}
} finally {
context.close();
}
}

@Test
void onFrameShouldReceiveViewportSize() {
BrowserContext context = browser.newContext(new Browser.NewContextOptions().setViewportSize(1000, 400));
Page page = context.newPage();
try {
List<ScreencastFrame> frames = new ArrayList<>();
page.screencast().start(new Screencast.StartOptions().setOnFrame(frames::add));
page.navigate(server.EMPTY_PAGE);
page.evaluate("() => document.body.style.backgroundColor = 'red'");
page.waitForTimeout(500);
page.screencast().stop();
assertFalse(frames.isEmpty(), "expected at least one frame");
for (ScreencastFrame frame : frames) {
assertEquals(1000, frame.viewportWidth());
assertEquals(400, frame.viewportHeight());
}
} finally {
context.close();
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1.60.0-alpha-1778025033000
1.60.0-beta-1778180503000
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,6 +326,22 @@ private void createClassesAndEnums(JsonObject jsonObject) {
}
return;
}
if ("function".equals(jsonObject.get("name").getAsString()) && jsonObject.has("args")) {
for (JsonElement item : jsonObject.getAsJsonArray("args")) {
if (!item.isJsonObject()) {
continue;
}
JsonObject argObject = item.getAsJsonObject();
if (!"Object".equals(argObject.get("name").getAsString())) {
continue;
}
String alias = javaAlias(argObject);
if (alias != null) {
typeScope().createTopLevelInterface(alias, this, argObject);
}
}
return;
}
if ("Object".equals(jsonObject.get("name").getAsString())) {
if (customType != null) {
// Same type maybe referenced as 'Object' in several union values, e.g. Object|Array<Object>
Expand DownExpand Up@@ -506,8 +522,8 @@ private String convertBuiltinType(JsonObject jsonType) {
if (customType != null) {
return customType;
}
// Inner Objects (e.g. function arguments) are not visited by createClassesAndEnums,
// so resolve their Java type name from langAliases here.
// Inner Objects without langAliases (e.g. unaliased function arguments) are not visited
// by createClassesAndEnums, so resolve their Java type name from langAliases here.
String alias = javaAlias(jsonType);
if (alias != null) {
return alias;
Expand DownExpand Up@@ -601,6 +617,14 @@ void createTopLevelClass(String name, Element parent, JsonObject jsonObject) {
}
}

void createTopLevelInterface(String name, Element parent, JsonObject jsonObject) {
Map<String, TypeDefinition> map = topLevelTypes();
TypeDefinition existing = map.putIfAbsent(name, new CustomInterface(parent, name, jsonObject));
if (existing != null && !(existing instanceof CustomInterface)) {
throw new RuntimeException("Two interfaces with same name have different values:\n" + jsonObject + "\n" + existing.jsonElement);
}
}

void createNestedClass(String name, Element parent, JsonObject jsonObject) {
for (CustomClass c : classes) {
if (c.name.equals(name)) {
Expand DownExpand Up@@ -840,7 +864,7 @@ class Field extends Element {
final String name;
final TypeRef type;

Field(CustomClass parent, String name, JsonObject jsonElement) {
Field(TypeDefinition parent, String name, JsonObject jsonElement) {
super(parent, jsonElement);
this.name = name;
this.type = new TypeRef(this, jsonElement.getAsJsonObject().get("type"));
Expand DownExpand Up@@ -1151,6 +1175,43 @@ private void writeConstructor(List<String> output, String bodyOffset) {
}
}

class CustomInterface extends TypeDefinition {
final String name;
final List<Field> fields = new ArrayList<>();

CustomInterface(Element parent, String name, JsonObject jsonElement) {
super(parent, true, jsonElement);
this.name = name;
if (jsonElement.has("properties")) {
for (JsonElement item : jsonElement.getAsJsonArray("properties")) {
JsonObject propertyJson = item.getAsJsonObject();
fields.add(new Field(this, propertyJson.get("name").getAsString(), propertyJson));
}
}
}

@Override
String name() {
return name;
}

@Override
void writeTo(List<String> output, String offset) {
output.add(offset + "public interface " + name + " {");
String bodyOffset = offset + " ";
boolean first = true;
for (Field f : fields) {
if (!first) {
output.add("");
}
first = false;
writeJavadoc(output, bodyOffset, f.comment());
output.add(bodyOffset + f.type.toJava() + " " + f.name + "();");
}
output.add(offset + "}");
}
}

class Enum extends TypeDefinition {
final List<String> enumValues;

Expand DownExpand Up@@ -1199,18 +1260,25 @@ public class ApiGenerator {
System.out.println("Writing assertion files to: " + dir.getCanonicalPath());
generate(api, assertionsDir, "com.microsoft.playwright.assertions", isAssertion().and(isSoftAssertion().negate()), sharedTypes);

writeTopLevelTypes(sharedTypes, optionsDir, "com.microsoft.playwright");
writeTopLevelTypes(sharedTypes, dir, optionsDir, "com.microsoft.playwright");
}

private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File optionsDir, String packageName) throws IOException {
private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File dir, File optionsDir, String packageName) throws IOException {
for (TypeDefinition e : topLevelTypes.values()) {
List<String> lines = new ArrayList<>();
lines.add(Interface.header);
lines.add("package " + packageName + ".options;");
File targetDir;
if (e instanceof CustomInterface) {
lines.add("package " + packageName + ";");
targetDir = dir;
} else {
lines.add("package " + packageName + ".options;");
targetDir = optionsDir;
}
lines.add("");
e.writeTo(lines, "");
String text = String.join("\n", lines);
try (FileWriter writer = new FileWriter(new File(optionsDir, e.name() + ".java"))) {
try (FileWriter writer = new FileWriter(new File(targetDir, e.name() + ".java"))) {
writer.write(text);
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' chore: roll driver to 1.60.0-beta-1778180503000 by yury-s · Pull Request #1918 · microsoft/playwright-java · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ Playwright is a Java library to automate [Chromium](https://www.chromium.org/Hom
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->148.0.7778.96<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| WebKit <!-- GEN:webkit-version -->26.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->150.0.1<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| Firefox <!-- GEN:firefox-version -->150.0.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |

## Documentation

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@
public interface Screencast {
class StartOptions {
/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public Consumer<ScreencastFrame> onFrame;
/**
Expand All@@ -40,7 +40,7 @@ class StartOptions {
public Integer quality;

/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public StartOptions setOnFrame(Consumer<ScreencastFrame> onFrame) {
this.onFrame = onFrame;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,19 +14,21 @@
* limitations under the License.
*/

package com.microsoft.playwright.options;
package com.microsoft.playwright;

/**
* A single screencast frame delivered to {@link com.microsoft.playwright.Screencast#start Screencast.start()}'s
* {@code onFrame} callback.
*/
public class ScreencastFrame {
public interface ScreencastFrame {
/**
* JPEG-encoded frame data.
*/
public byte[] data;
byte[] data();

/**
* Width of the page viewport at the time the frame was captured.
*/
int viewportWidth();

public ScreencastFrame(byte[] data) {
this.data = data;
}
}
/**
* Height of the page viewport at the time the frame was captured.
*/
int viewportHeight();
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
/*
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.microsoft.playwright.impl;

import com.microsoft.playwright.ScreencastFrame;

class ScreencastFrameImpl implements ScreencastFrame {
private final byte[] data;
private final int viewportWidth;
private final int viewportHeight;

ScreencastFrameImpl(byte[] data, int viewportWidth, int viewportHeight) {
this.data = data;
this.viewportWidth = viewportWidth;
this.viewportHeight = viewportHeight;
}

@Override
public byte[] data() {
return data;
}

@Override
public int viewportWidth() {
return viewportWidth;
}

@Override
public int viewportHeight() {
return viewportHeight;
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@
import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;
import com.microsoft.playwright.Screencast;
import com.microsoft.playwright.options.ScreencastFrame;
import com.microsoft.playwright.ScreencastFrame;

import java.nio.file.Path;
import java.util.function.Consumer;
Expand All@@ -44,7 +44,9 @@ void handleScreencastFrame(JsonObject params) {
}
String dataBase64 = params.get("data").getAsString();
byte[] data = java.util.Base64.getDecoder().decode(dataBase64);
onFrame.accept(new ScreencastFrame(data));
int viewportWidth = params.get("viewportWidth").getAsInt();
int viewportHeight = params.get("viewportHeight").getAsInt();
onFrame.accept(new ScreencastFrameImpl(data, viewportWidth, viewportHeight));
}

@Override
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@

package com.microsoft.playwright;

import com.microsoft.playwright.options.ScreencastFrame;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand DownExpand Up@@ -113,9 +112,30 @@ void screencastStartShouldDeliverFramesViaOnFrame() throws Exception {
assertFalse(frames.isEmpty(), "expected at least one frame");
// JPEG-encoded frames start with FF D8.
for (ScreencastFrame frame : frames) {
assertNotNull(frame.data);
assertEquals((byte) 0xFF, frame.data[0]);
assertEquals((byte) 0xD8, frame.data[1]);
assertNotNull(frame.data());
assertEquals((byte) 0xFF, frame.data()[0]);
assertEquals((byte) 0xD8, frame.data()[1]);
}
} finally {
context.close();
}
}

@Test
void onFrameShouldReceiveViewportSize() {
BrowserContext context = browser.newContext(new Browser.NewContextOptions().setViewportSize(1000, 400));
Page page = context.newPage();
try {
List<ScreencastFrame> frames = new ArrayList<>();
page.screencast().start(new Screencast.StartOptions().setOnFrame(frames::add));
page.navigate(server.EMPTY_PAGE);
page.evaluate("() => document.body.style.backgroundColor = 'red'");
page.waitForTimeout(500);
page.screencast().stop();
assertFalse(frames.isEmpty(), "expected at least one frame");
for (ScreencastFrame frame : frames) {
assertEquals(1000, frame.viewportWidth());
assertEquals(400, frame.viewportHeight());
}
} finally {
context.close();
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1.60.0-alpha-1778025033000
1.60.0-beta-1778180503000
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,6 +326,22 @@ private void createClassesAndEnums(JsonObject jsonObject) {
}
return;
}
if ("function".equals(jsonObject.get("name").getAsString()) && jsonObject.has("args")) {
for (JsonElement item : jsonObject.getAsJsonArray("args")) {
if (!item.isJsonObject()) {
continue;
}
JsonObject argObject = item.getAsJsonObject();
if (!"Object".equals(argObject.get("name").getAsString())) {
continue;
}
String alias = javaAlias(argObject);
if (alias != null) {
typeScope().createTopLevelInterface(alias, this, argObject);
}
}
return;
}
if ("Object".equals(jsonObject.get("name").getAsString())) {
if (customType != null) {
// Same type maybe referenced as 'Object' in several union values, e.g. Object|Array<Object>
Expand DownExpand Up@@ -506,8 +522,8 @@ private String convertBuiltinType(JsonObject jsonType) {
if (customType != null) {
return customType;
}
// Inner Objects (e.g. function arguments) are not visited by createClassesAndEnums,
// so resolve their Java type name from langAliases here.
// Inner Objects without langAliases (e.g. unaliased function arguments) are not visited
// by createClassesAndEnums, so resolve their Java type name from langAliases here.
String alias = javaAlias(jsonType);
if (alias != null) {
return alias;
Expand DownExpand Up@@ -601,6 +617,14 @@ void createTopLevelClass(String name, Element parent, JsonObject jsonObject) {
}
}

void createTopLevelInterface(String name, Element parent, JsonObject jsonObject) {
Map<String, TypeDefinition> map = topLevelTypes();
TypeDefinition existing = map.putIfAbsent(name, new CustomInterface(parent, name, jsonObject));
if (existing != null && !(existing instanceof CustomInterface)) {
throw new RuntimeException("Two interfaces with same name have different values:\n" + jsonObject + "\n" + existing.jsonElement);
}
}

void createNestedClass(String name, Element parent, JsonObject jsonObject) {
for (CustomClass c : classes) {
if (c.name.equals(name)) {
Expand DownExpand Up@@ -840,7 +864,7 @@ class Field extends Element {
final String name;
final TypeRef type;

Field(CustomClass parent, String name, JsonObject jsonElement) {
Field(TypeDefinition parent, String name, JsonObject jsonElement) {
super(parent, jsonElement);
this.name = name;
this.type = new TypeRef(this, jsonElement.getAsJsonObject().get("type"));
Expand DownExpand Up@@ -1151,6 +1175,43 @@ private void writeConstructor(List<String> output, String bodyOffset) {
}
}

class CustomInterface extends TypeDefinition {
final String name;
final List<Field> fields = new ArrayList<>();

CustomInterface(Element parent, String name, JsonObject jsonElement) {
super(parent, true, jsonElement);
this.name = name;
if (jsonElement.has("properties")) {
for (JsonElement item : jsonElement.getAsJsonArray("properties")) {
JsonObject propertyJson = item.getAsJsonObject();
fields.add(new Field(this, propertyJson.get("name").getAsString(), propertyJson));
}
}
}

@Override
String name() {
return name;
}

@Override
void writeTo(List<String> output, String offset) {
output.add(offset + "public interface " + name + " {");
String bodyOffset = offset + " ";
boolean first = true;
for (Field f : fields) {
if (!first) {
output.add("");
}
first = false;
writeJavadoc(output, bodyOffset, f.comment());
output.add(bodyOffset + f.type.toJava() + " " + f.name + "();");
}
output.add(offset + "}");
}
}

class Enum extends TypeDefinition {
final List<String> enumValues;

Expand DownExpand Up@@ -1199,18 +1260,25 @@ public class ApiGenerator {
System.out.println("Writing assertion files to: " + dir.getCanonicalPath());
generate(api, assertionsDir, "com.microsoft.playwright.assertions", isAssertion().and(isSoftAssertion().negate()), sharedTypes);

writeTopLevelTypes(sharedTypes, optionsDir, "com.microsoft.playwright");
writeTopLevelTypes(sharedTypes, dir, optionsDir, "com.microsoft.playwright");
}

private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File optionsDir, String packageName) throws IOException {
private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File dir, File optionsDir, String packageName) throws IOException {
for (TypeDefinition e : topLevelTypes.values()) {
List<String> lines = new ArrayList<>();
lines.add(Interface.header);
lines.add("package " + packageName + ".options;");
File targetDir;
if (e instanceof CustomInterface) {
lines.add("package " + packageName + ";");
targetDir = dir;
} else {
lines.add("package " + packageName + ".options;");
targetDir = optionsDir;
}
lines.add("");
e.writeTo(lines, "");
String text = String.join("\n", lines);
try (FileWriter writer = new FileWriter(new File(optionsDir, e.name() + ".java"))) {
try (FileWriter writer = new FileWriter(new File(targetDir, e.name() + ".java"))) {
writer.write(text);
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: roll driver to 1.60.0-beta-1778180503000 by yury-s · Pull Request #1918 · microsoft/playwright-java · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ Playwright is a Java library to automate [Chromium](https://www.chromium.org/Hom
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->148.0.7778.96<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| WebKit <!-- GEN:webkit-version -->26.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->150.0.1<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| Firefox <!-- GEN:firefox-version -->150.0.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |

## Documentation

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@
public interface Screencast {
class StartOptions {
/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public Consumer<ScreencastFrame> onFrame;
/**
Expand All@@ -40,7 +40,7 @@ class StartOptions {
public Integer quality;

/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public StartOptions setOnFrame(Consumer<ScreencastFrame> onFrame) {
this.onFrame = onFrame;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,19 +14,21 @@
* limitations under the License.
*/

package com.microsoft.playwright.options;
package com.microsoft.playwright;

/**
* A single screencast frame delivered to {@link com.microsoft.playwright.Screencast#start Screencast.start()}'s
* {@code onFrame} callback.
*/
public class ScreencastFrame {
public interface ScreencastFrame {
/**
* JPEG-encoded frame data.
*/
public byte[] data;
byte[] data();

/**
* Width of the page viewport at the time the frame was captured.
*/
int viewportWidth();

public ScreencastFrame(byte[] data) {
this.data = data;
}
}
/**
* Height of the page viewport at the time the frame was captured.
*/
int viewportHeight();
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
/*
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.microsoft.playwright.impl;

import com.microsoft.playwright.ScreencastFrame;

class ScreencastFrameImpl implements ScreencastFrame {
private final byte[] data;
private final int viewportWidth;
private final int viewportHeight;

ScreencastFrameImpl(byte[] data, int viewportWidth, int viewportHeight) {
this.data = data;
this.viewportWidth = viewportWidth;
this.viewportHeight = viewportHeight;
}

@Override
public byte[] data() {
return data;
}

@Override
public int viewportWidth() {
return viewportWidth;
}

@Override
public int viewportHeight() {
return viewportHeight;
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@
import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;
import com.microsoft.playwright.Screencast;
import com.microsoft.playwright.options.ScreencastFrame;
import com.microsoft.playwright.ScreencastFrame;

import java.nio.file.Path;
import java.util.function.Consumer;
Expand All@@ -44,7 +44,9 @@ void handleScreencastFrame(JsonObject params) {
}
String dataBase64 = params.get("data").getAsString();
byte[] data = java.util.Base64.getDecoder().decode(dataBase64);
onFrame.accept(new ScreencastFrame(data));
int viewportWidth = params.get("viewportWidth").getAsInt();
int viewportHeight = params.get("viewportHeight").getAsInt();
onFrame.accept(new ScreencastFrameImpl(data, viewportWidth, viewportHeight));
}

@Override
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@

package com.microsoft.playwright;

import com.microsoft.playwright.options.ScreencastFrame;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand DownExpand Up@@ -113,9 +112,30 @@ void screencastStartShouldDeliverFramesViaOnFrame() throws Exception {
assertFalse(frames.isEmpty(), "expected at least one frame");
// JPEG-encoded frames start with FF D8.
for (ScreencastFrame frame : frames) {
assertNotNull(frame.data);
assertEquals((byte) 0xFF, frame.data[0]);
assertEquals((byte) 0xD8, frame.data[1]);
assertNotNull(frame.data());
assertEquals((byte) 0xFF, frame.data()[0]);
assertEquals((byte) 0xD8, frame.data()[1]);
}
} finally {
context.close();
}
}

@Test
void onFrameShouldReceiveViewportSize() {
BrowserContext context = browser.newContext(new Browser.NewContextOptions().setViewportSize(1000, 400));
Page page = context.newPage();
try {
List<ScreencastFrame> frames = new ArrayList<>();
page.screencast().start(new Screencast.StartOptions().setOnFrame(frames::add));
page.navigate(server.EMPTY_PAGE);
page.evaluate("() => document.body.style.backgroundColor = 'red'");
page.waitForTimeout(500);
page.screencast().stop();
assertFalse(frames.isEmpty(), "expected at least one frame");
for (ScreencastFrame frame : frames) {
assertEquals(1000, frame.viewportWidth());
assertEquals(400, frame.viewportHeight());
}
} finally {
context.close();
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1.60.0-alpha-1778025033000
1.60.0-beta-1778180503000
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,6 +326,22 @@ private void createClassesAndEnums(JsonObject jsonObject) {
}
return;
}
if ("function".equals(jsonObject.get("name").getAsString()) && jsonObject.has("args")) {
for (JsonElement item : jsonObject.getAsJsonArray("args")) {
if (!item.isJsonObject()) {
continue;
}
JsonObject argObject = item.getAsJsonObject();
if (!"Object".equals(argObject.get("name").getAsString())) {
continue;
}
String alias = javaAlias(argObject);
if (alias != null) {
typeScope().createTopLevelInterface(alias, this, argObject);
}
}
return;
}
if ("Object".equals(jsonObject.get("name").getAsString())) {
if (customType != null) {
// Same type maybe referenced as 'Object' in several union values, e.g. Object|Array<Object>
Expand DownExpand Up@@ -506,8 +522,8 @@ private String convertBuiltinType(JsonObject jsonType) {
if (customType != null) {
return customType;
}
// Inner Objects (e.g. function arguments) are not visited by createClassesAndEnums,
// so resolve their Java type name from langAliases here.
// Inner Objects without langAliases (e.g. unaliased function arguments) are not visited
// by createClassesAndEnums, so resolve their Java type name from langAliases here.
String alias = javaAlias(jsonType);
if (alias != null) {
return alias;
Expand DownExpand Up@@ -601,6 +617,14 @@ void createTopLevelClass(String name, Element parent, JsonObject jsonObject) {
}
}

void createTopLevelInterface(String name, Element parent, JsonObject jsonObject) {
Map<String, TypeDefinition> map = topLevelTypes();
TypeDefinition existing = map.putIfAbsent(name, new CustomInterface(parent, name, jsonObject));
if (existing != null && !(existing instanceof CustomInterface)) {
throw new RuntimeException("Two interfaces with same name have different values:\n" + jsonObject + "\n" + existing.jsonElement);
}
}

void createNestedClass(String name, Element parent, JsonObject jsonObject) {
for (CustomClass c : classes) {
if (c.name.equals(name)) {
Expand DownExpand Up@@ -840,7 +864,7 @@ class Field extends Element {
final String name;
final TypeRef type;

Field(CustomClass parent, String name, JsonObject jsonElement) {
Field(TypeDefinition parent, String name, JsonObject jsonElement) {
super(parent, jsonElement);
this.name = name;
this.type = new TypeRef(this, jsonElement.getAsJsonObject().get("type"));
Expand DownExpand Up@@ -1151,6 +1175,43 @@ private void writeConstructor(List<String> output, String bodyOffset) {
}
}

class CustomInterface extends TypeDefinition {
final String name;
final List<Field> fields = new ArrayList<>();

CustomInterface(Element parent, String name, JsonObject jsonElement) {
super(parent, true, jsonElement);
this.name = name;
if (jsonElement.has("properties")) {
for (JsonElement item : jsonElement.getAsJsonArray("properties")) {
JsonObject propertyJson = item.getAsJsonObject();
fields.add(new Field(this, propertyJson.get("name").getAsString(), propertyJson));
}
}
}

@Override
String name() {
return name;
}

@Override
void writeTo(List<String> output, String offset) {
output.add(offset + "public interface " + name + " {");
String bodyOffset = offset + " ";
boolean first = true;
for (Field f : fields) {
if (!first) {
output.add("");
}
first = false;
writeJavadoc(output, bodyOffset, f.comment());
output.add(bodyOffset + f.type.toJava() + " " + f.name + "();");
}
output.add(offset + "}");
}
}

class Enum extends TypeDefinition {
final List<String> enumValues;

Expand DownExpand Up@@ -1199,18 +1260,25 @@ public class ApiGenerator {
System.out.println("Writing assertion files to: " + dir.getCanonicalPath());
generate(api, assertionsDir, "com.microsoft.playwright.assertions", isAssertion().and(isSoftAssertion().negate()), sharedTypes);

writeTopLevelTypes(sharedTypes, optionsDir, "com.microsoft.playwright");
writeTopLevelTypes(sharedTypes, dir, optionsDir, "com.microsoft.playwright");
}

private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File optionsDir, String packageName) throws IOException {
private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File dir, File optionsDir, String packageName) throws IOException {
for (TypeDefinition e : topLevelTypes.values()) {
List<String> lines = new ArrayList<>();
lines.add(Interface.header);
lines.add("package " + packageName + ".options;");
File targetDir;
if (e instanceof CustomInterface) {
lines.add("package " + packageName + ";");
targetDir = dir;
} else {
lines.add("package " + packageName + ".options;");
targetDir = optionsDir;
}
lines.add("");
e.writeTo(lines, "");
String text = String.join("\n", lines);
try (FileWriter writer = new FileWriter(new File(optionsDir, e.name() + ".java"))) {
try (FileWriter writer = new FileWriter(new File(targetDir, e.name() + ".java"))) {
writer.write(text);
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore: roll driver to 1.60.0-beta-1778180503000 by yury-s · Pull Request #1918 · microsoft/playwright-java · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ Playwright is a Java library to automate [Chromium](https://www.chromium.org/Hom
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->148.0.7778.96<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| WebKit <!-- GEN:webkit-version -->26.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->150.0.1<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| Firefox <!-- GEN:firefox-version -->150.0.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |

## Documentation

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@
public interface Screencast {
class StartOptions {
/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public Consumer<ScreencastFrame> onFrame;
/**
Expand All@@ -40,7 +40,7 @@ class StartOptions {
public Integer quality;

/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public StartOptions setOnFrame(Consumer<ScreencastFrame> onFrame) {
this.onFrame = onFrame;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,19 +14,21 @@
* limitations under the License.
*/

package com.microsoft.playwright.options;
package com.microsoft.playwright;

/**
* A single screencast frame delivered to {@link com.microsoft.playwright.Screencast#start Screencast.start()}'s
* {@code onFrame} callback.
*/
public class ScreencastFrame {
public interface ScreencastFrame {
/**
* JPEG-encoded frame data.
*/
public byte[] data;
byte[] data();

/**
* Width of the page viewport at the time the frame was captured.
*/
int viewportWidth();

public ScreencastFrame(byte[] data) {
this.data = data;
}
}
/**
* Height of the page viewport at the time the frame was captured.
*/
int viewportHeight();
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
/*
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.microsoft.playwright.impl;

import com.microsoft.playwright.ScreencastFrame;

class ScreencastFrameImpl implements ScreencastFrame {
private final byte[] data;
private final int viewportWidth;
private final int viewportHeight;

ScreencastFrameImpl(byte[] data, int viewportWidth, int viewportHeight) {
this.data = data;
this.viewportWidth = viewportWidth;
this.viewportHeight = viewportHeight;
}

@Override
public byte[] data() {
return data;
}

@Override
public int viewportWidth() {
return viewportWidth;
}

@Override
public int viewportHeight() {
return viewportHeight;
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@
import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;
import com.microsoft.playwright.Screencast;
import com.microsoft.playwright.options.ScreencastFrame;
import com.microsoft.playwright.ScreencastFrame;

import java.nio.file.Path;
import java.util.function.Consumer;
Expand All@@ -44,7 +44,9 @@ void handleScreencastFrame(JsonObject params) {
}
String dataBase64 = params.get("data").getAsString();
byte[] data = java.util.Base64.getDecoder().decode(dataBase64);
onFrame.accept(new ScreencastFrame(data));
int viewportWidth = params.get("viewportWidth").getAsInt();
int viewportHeight = params.get("viewportHeight").getAsInt();
onFrame.accept(new ScreencastFrameImpl(data, viewportWidth, viewportHeight));
}

@Override
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@

package com.microsoft.playwright;

import com.microsoft.playwright.options.ScreencastFrame;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand DownExpand Up@@ -113,9 +112,30 @@ void screencastStartShouldDeliverFramesViaOnFrame() throws Exception {
assertFalse(frames.isEmpty(), "expected at least one frame");
// JPEG-encoded frames start with FF D8.
for (ScreencastFrame frame : frames) {
assertNotNull(frame.data);
assertEquals((byte) 0xFF, frame.data[0]);
assertEquals((byte) 0xD8, frame.data[1]);
assertNotNull(frame.data());
assertEquals((byte) 0xFF, frame.data()[0]);
assertEquals((byte) 0xD8, frame.data()[1]);
}
} finally {
context.close();
}
}

@Test
void onFrameShouldReceiveViewportSize() {
BrowserContext context = browser.newContext(new Browser.NewContextOptions().setViewportSize(1000, 400));
Page page = context.newPage();
try {
List<ScreencastFrame> frames = new ArrayList<>();
page.screencast().start(new Screencast.StartOptions().setOnFrame(frames::add));
page.navigate(server.EMPTY_PAGE);
page.evaluate("() => document.body.style.backgroundColor = 'red'");
page.waitForTimeout(500);
page.screencast().stop();
assertFalse(frames.isEmpty(), "expected at least one frame");
for (ScreencastFrame frame : frames) {
assertEquals(1000, frame.viewportWidth());
assertEquals(400, frame.viewportHeight());
}
} finally {
context.close();
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1.60.0-alpha-1778025033000
1.60.0-beta-1778180503000
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,6 +326,22 @@ private void createClassesAndEnums(JsonObject jsonObject) {
}
return;
}
if ("function".equals(jsonObject.get("name").getAsString()) && jsonObject.has("args")) {
for (JsonElement item : jsonObject.getAsJsonArray("args")) {
if (!item.isJsonObject()) {
continue;
}
JsonObject argObject = item.getAsJsonObject();
if (!"Object".equals(argObject.get("name").getAsString())) {
continue;
}
String alias = javaAlias(argObject);
if (alias != null) {
typeScope().createTopLevelInterface(alias, this, argObject);
}
}
return;
}
if ("Object".equals(jsonObject.get("name").getAsString())) {
if (customType != null) {
// Same type maybe referenced as 'Object' in several union values, e.g. Object|Array<Object>
Expand DownExpand Up@@ -506,8 +522,8 @@ private String convertBuiltinType(JsonObject jsonType) {
if (customType != null) {
return customType;
}
// Inner Objects (e.g. function arguments) are not visited by createClassesAndEnums,
// so resolve their Java type name from langAliases here.
// Inner Objects without langAliases (e.g. unaliased function arguments) are not visited
// by createClassesAndEnums, so resolve their Java type name from langAliases here.
String alias = javaAlias(jsonType);
if (alias != null) {
return alias;
Expand DownExpand Up@@ -601,6 +617,14 @@ void createTopLevelClass(String name, Element parent, JsonObject jsonObject) {
}
}

void createTopLevelInterface(String name, Element parent, JsonObject jsonObject) {
Map<String, TypeDefinition> map = topLevelTypes();
TypeDefinition existing = map.putIfAbsent(name, new CustomInterface(parent, name, jsonObject));
if (existing != null && !(existing instanceof CustomInterface)) {
throw new RuntimeException("Two interfaces with same name have different values:\n" + jsonObject + "\n" + existing.jsonElement);
}
}

void createNestedClass(String name, Element parent, JsonObject jsonObject) {
for (CustomClass c : classes) {
if (c.name.equals(name)) {
Expand DownExpand Up@@ -840,7 +864,7 @@ class Field extends Element {
final String name;
final TypeRef type;

Field(CustomClass parent, String name, JsonObject jsonElement) {
Field(TypeDefinition parent, String name, JsonObject jsonElement) {
super(parent, jsonElement);
this.name = name;
this.type = new TypeRef(this, jsonElement.getAsJsonObject().get("type"));
Expand DownExpand Up@@ -1151,6 +1175,43 @@ private void writeConstructor(List<String> output, String bodyOffset) {
}
}

class CustomInterface extends TypeDefinition {
final String name;
final List<Field> fields = new ArrayList<>();

CustomInterface(Element parent, String name, JsonObject jsonElement) {
super(parent, true, jsonElement);
this.name = name;
if (jsonElement.has("properties")) {
for (JsonElement item : jsonElement.getAsJsonArray("properties")) {
JsonObject propertyJson = item.getAsJsonObject();
fields.add(new Field(this, propertyJson.get("name").getAsString(), propertyJson));
}
}
}

@Override
String name() {
return name;
}

@Override
void writeTo(List<String> output, String offset) {
output.add(offset + "public interface " + name + " {");
String bodyOffset = offset + " ";
boolean first = true;
for (Field f : fields) {
if (!first) {
output.add("");
}
first = false;
writeJavadoc(output, bodyOffset, f.comment());
output.add(bodyOffset + f.type.toJava() + " " + f.name + "();");
}
output.add(offset + "}");
}
}

class Enum extends TypeDefinition {
final List<String> enumValues;

Expand DownExpand Up@@ -1199,18 +1260,25 @@ public class ApiGenerator {
System.out.println("Writing assertion files to: " + dir.getCanonicalPath());
generate(api, assertionsDir, "com.microsoft.playwright.assertions", isAssertion().and(isSoftAssertion().negate()), sharedTypes);

writeTopLevelTypes(sharedTypes, optionsDir, "com.microsoft.playwright");
writeTopLevelTypes(sharedTypes, dir, optionsDir, "com.microsoft.playwright");
}

private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File optionsDir, String packageName) throws IOException {
private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File dir, File optionsDir, String packageName) throws IOException {
for (TypeDefinition e : topLevelTypes.values()) {
List<String> lines = new ArrayList<>();
lines.add(Interface.header);
lines.add("package " + packageName + ".options;");
File targetDir;
if (e instanceof CustomInterface) {
lines.add("package " + packageName + ";");
targetDir = dir;
} else {
lines.add("package " + packageName + ".options;");
targetDir = optionsDir;
}
lines.add("");
e.writeTo(lines, "");
String text = String.join("\n", lines);
try (FileWriter writer = new FileWriter(new File(optionsDir, e.name() + ".java"))) {
try (FileWriter writer = new FileWriter(new File(targetDir, e.name() + ".java"))) {
writer.write(text);
}
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); chore: roll driver to 1.60.0-beta-1778180503000 by yury-s · Pull Request #1918 · microsoft/playwright-java · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@ Playwright is a Java library to automate [Chromium](https://www.chromium.org/Hom
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->148.0.7778.96<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| WebKit <!-- GEN:webkit-version -->26.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->150.0.1<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |
| Firefox <!-- GEN:firefox-version -->150.0.2<!-- GEN:stop --> | :white_check_mark: | :white_check_mark: | :white_check_mark: |

## Documentation

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@
public interface Screencast {
class StartOptions {
/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public Consumer<ScreencastFrame> onFrame;
/**
Expand All@@ -40,7 +40,7 @@ class StartOptions {
public Integer quality;

/**
* Callback that receives JPEG-encoded frame data.
* Callback that receives JPEG-encoded frame data along with the page viewport size at the time of capture.
*/
public StartOptions setOnFrame(Consumer<ScreencastFrame> onFrame) {
this.onFrame = onFrame;
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,19 +14,21 @@
* limitations under the License.
*/

package com.microsoft.playwright.options;
package com.microsoft.playwright;

/**
* A single screencast frame delivered to {@link com.microsoft.playwright.Screencast#start Screencast.start()}'s
* {@code onFrame} callback.
*/
public class ScreencastFrame {
public interface ScreencastFrame {
/**
* JPEG-encoded frame data.
*/
public byte[] data;
byte[] data();

/**
* Width of the page viewport at the time the frame was captured.
*/
int viewportWidth();

public ScreencastFrame(byte[] data) {
this.data = data;
}
}
/**
* Height of the page viewport at the time the frame was captured.
*/
int viewportHeight();
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
/*
* Copyright (c) Microsoft Corporation.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.microsoft.playwright.impl;

import com.microsoft.playwright.ScreencastFrame;

class ScreencastFrameImpl implements ScreencastFrame {
private final byte[] data;
private final int viewportWidth;
private final int viewportHeight;

ScreencastFrameImpl(byte[] data, int viewportWidth, int viewportHeight) {
this.data = data;
this.viewportWidth = viewportWidth;
this.viewportHeight = viewportHeight;
}

@Override
public byte[] data() {
return data;
}

@Override
public int viewportWidth() {
return viewportWidth;
}

@Override
public int viewportHeight() {
return viewportHeight;
}
}
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@
import com.google.gson.JsonObject;
import com.microsoft.playwright.PlaywrightException;
import com.microsoft.playwright.Screencast;
import com.microsoft.playwright.options.ScreencastFrame;
import com.microsoft.playwright.ScreencastFrame;

import java.nio.file.Path;
import java.util.function.Consumer;
Expand All@@ -44,7 +44,9 @@ void handleScreencastFrame(JsonObject params) {
}
String dataBase64 = params.get("data").getAsString();
byte[] data = java.util.Base64.getDecoder().decode(dataBase64);
onFrame.accept(new ScreencastFrame(data));
int viewportWidth = params.get("viewportWidth").getAsInt();
int viewportHeight = params.get("viewportHeight").getAsInt();
onFrame.accept(new ScreencastFrameImpl(data, viewportWidth, viewportHeight));
}

@Override
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,7 +16,6 @@

package com.microsoft.playwright;

import com.microsoft.playwright.options.ScreencastFrame;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;

Expand DownExpand Up@@ -113,9 +112,30 @@ void screencastStartShouldDeliverFramesViaOnFrame() throws Exception {
assertFalse(frames.isEmpty(), "expected at least one frame");
// JPEG-encoded frames start with FF D8.
for (ScreencastFrame frame : frames) {
assertNotNull(frame.data);
assertEquals((byte) 0xFF, frame.data[0]);
assertEquals((byte) 0xD8, frame.data[1]);
assertNotNull(frame.data());
assertEquals((byte) 0xFF, frame.data()[0]);
assertEquals((byte) 0xD8, frame.data()[1]);
}
} finally {
context.close();
}
}

@Test
void onFrameShouldReceiveViewportSize() {
BrowserContext context = browser.newContext(new Browser.NewContextOptions().setViewportSize(1000, 400));
Page page = context.newPage();
try {
List<ScreencastFrame> frames = new ArrayList<>();
page.screencast().start(new Screencast.StartOptions().setOnFrame(frames::add));
page.navigate(server.EMPTY_PAGE);
page.evaluate("() => document.body.style.backgroundColor = 'red'");
page.waitForTimeout(500);
page.screencast().stop();
assertFalse(frames.isEmpty(), "expected at least one frame");
for (ScreencastFrame frame : frames) {
assertEquals(1000, frame.viewportWidth());
assertEquals(400, frame.viewportHeight());
}
} finally {
context.close();
Expand Down
2 changes: 1 addition & 1 deletion scripts/DRIVER_VERSION
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1.60.0-alpha-1778025033000
1.60.0-beta-1778180503000
Original file line numberDiff line numberDiff line change
Expand Up@@ -326,6 +326,22 @@ private void createClassesAndEnums(JsonObject jsonObject) {
}
return;
}
if ("function".equals(jsonObject.get("name").getAsString()) && jsonObject.has("args")) {
for (JsonElement item : jsonObject.getAsJsonArray("args")) {
if (!item.isJsonObject()) {
continue;
}
JsonObject argObject = item.getAsJsonObject();
if (!"Object".equals(argObject.get("name").getAsString())) {
continue;
}
String alias = javaAlias(argObject);
if (alias != null) {
typeScope().createTopLevelInterface(alias, this, argObject);
}
}
return;
}
if ("Object".equals(jsonObject.get("name").getAsString())) {
if (customType != null) {
// Same type maybe referenced as 'Object' in several union values, e.g. Object|Array<Object>
Expand DownExpand Up@@ -506,8 +522,8 @@ private String convertBuiltinType(JsonObject jsonType) {
if (customType != null) {
return customType;
}
// Inner Objects (e.g. function arguments) are not visited by createClassesAndEnums,
// so resolve their Java type name from langAliases here.
// Inner Objects without langAliases (e.g. unaliased function arguments) are not visited
// by createClassesAndEnums, so resolve their Java type name from langAliases here.
String alias = javaAlias(jsonType);
if (alias != null) {
return alias;
Expand DownExpand Up@@ -601,6 +617,14 @@ void createTopLevelClass(String name, Element parent, JsonObject jsonObject) {
}
}

void createTopLevelInterface(String name, Element parent, JsonObject jsonObject) {
Map<String, TypeDefinition> map = topLevelTypes();
TypeDefinition existing = map.putIfAbsent(name, new CustomInterface(parent, name, jsonObject));
if (existing != null && !(existing instanceof CustomInterface)) {
throw new RuntimeException("Two interfaces with same name have different values:\n" + jsonObject + "\n" + existing.jsonElement);
}
}

void createNestedClass(String name, Element parent, JsonObject jsonObject) {
for (CustomClass c : classes) {
if (c.name.equals(name)) {
Expand DownExpand Up@@ -840,7 +864,7 @@ class Field extends Element {
final String name;
final TypeRef type;

Field(CustomClass parent, String name, JsonObject jsonElement) {
Field(TypeDefinition parent, String name, JsonObject jsonElement) {
super(parent, jsonElement);
this.name = name;
this.type = new TypeRef(this, jsonElement.getAsJsonObject().get("type"));
Expand DownExpand Up@@ -1151,6 +1175,43 @@ private void writeConstructor(List<String> output, String bodyOffset) {
}
}

class CustomInterface extends TypeDefinition {
final String name;
final List<Field> fields = new ArrayList<>();

CustomInterface(Element parent, String name, JsonObject jsonElement) {
super(parent, true, jsonElement);
this.name = name;
if (jsonElement.has("properties")) {
for (JsonElement item : jsonElement.getAsJsonArray("properties")) {
JsonObject propertyJson = item.getAsJsonObject();
fields.add(new Field(this, propertyJson.get("name").getAsString(), propertyJson));
}
}
}

@Override
String name() {
return name;
}

@Override
void writeTo(List<String> output, String offset) {
output.add(offset + "public interface " + name + " {");
String bodyOffset = offset + " ";
boolean first = true;
for (Field f : fields) {
if (!first) {
output.add("");
}
first = false;
writeJavadoc(output, bodyOffset, f.comment());
output.add(bodyOffset + f.type.toJava() + " " + f.name + "();");
}
output.add(offset + "}");
}
}

class Enum extends TypeDefinition {
final List<String> enumValues;

Expand DownExpand Up@@ -1199,18 +1260,25 @@ public class ApiGenerator {
System.out.println("Writing assertion files to: " + dir.getCanonicalPath());
generate(api, assertionsDir, "com.microsoft.playwright.assertions", isAssertion().and(isSoftAssertion().negate()), sharedTypes);

writeTopLevelTypes(sharedTypes, optionsDir, "com.microsoft.playwright");
writeTopLevelTypes(sharedTypes, dir, optionsDir, "com.microsoft.playwright");
}

private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File optionsDir, String packageName) throws IOException {
private void writeTopLevelTypes(Map<String, TypeDefinition> topLevelTypes, File dir, File optionsDir, String packageName) throws IOException {
for (TypeDefinition e : topLevelTypes.values()) {
List<String> lines = new ArrayList<>();
lines.add(Interface.header);
lines.add("package " + packageName + ".options;");
File targetDir;
if (e instanceof CustomInterface) {
lines.add("package " + packageName + ";");
targetDir = dir;
} else {
lines.add("package " + packageName + ".options;");
targetDir = optionsDir;
}
lines.add("");
e.writeTo(lines, "");
String text = String.join("\n", lines);
try (FileWriter writer = new FileWriter(new File(optionsDir, e.name() + ".java"))) {
try (FileWriter writer = new FileWriter(new File(targetDir, e.name() + ".java"))) {
writer.write(text);
}
}
Expand Down
Loading