Skip to content

chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Max Schmitt (mxschmitt) merged 3 commits into from
Mar 10, 2025
Merged

chore(roll): roll Playwright to 1.51.0-beta-1741166263000 #2767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e90d7b
chore(roll): roll Playwright to 1.51.0-beta-1741166263000
mxschmitt Mar 5, 2025
f535d4f
update driver
mxschmitt Mar 6, 2025
10088a6
fixes
mxschmitt Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->133.0.6943.16<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->134.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Chromium <!-- GEN:chromium-version -->134.0.6998.35<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->135.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |

## Documentation

Expand Down
5 changes: 5 additions & 0 deletions playwright/_impl/_browser.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@
from playwright._impl._errors import is_target_closed_error
from playwright._impl._helper import (
ColorScheme,
Contrast,
ForcedColors,
HarContentPolicy,
HarMode,
Expand DownExpand Up@@ -107,6 +108,7 @@ async def new_context(
colorScheme: ColorScheme = None,
reducedMotion: ReducedMotion = None,
forcedColors: ForcedColors = None,
contrast: Contrast = None,
acceptDownloads: bool = None,
defaultBrowserType: str = None,
proxy: ProxySettings = None,
Expand DownExpand Up@@ -152,6 +154,7 @@ async def new_page(
hasTouch: bool = None,
colorScheme: ColorScheme = None,
forcedColors: ForcedColors = None,
contrast: Contrast = None,
reducedMotion: ReducedMotion = None,
acceptDownloads: bool = None,
defaultBrowserType: str = None,
Expand DownExpand Up@@ -254,6 +257,8 @@ async def prepare_browser_context_params(params: Dict) -> None:
params["reducedMotion"] = "no-override"
if params.get("forcedColors", None) == "null":
params["forcedColors"] = "no-override"
if params.get("contrast", None) == "null":
params["contrast"] = "no-override"
if "acceptDownloads" in params:
params["acceptDownloads"] = "accept" if params["acceptDownloads"] else "deny"

Expand Down
8 changes: 6 additions & 2 deletions playwright/_impl/_browser_context.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -599,8 +599,12 @@ async def _inner_close() -> None:
await self._channel.send("close", {"reason": reason})
await self._closed_future

async def storage_state(self, path: Union[str, Path] = None) -> StorageState:
result = await self._channel.send_return_as_dict("storageState")
async def storage_state(
self, path: Union[str, Path] = None, indexedDB: bool = None

@dgozmanDmitry Gozman (dgozman)Mar 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not indexed_db?

@mxschmittMax Schmitt (mxschmitt)Mar 6, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our generator layer has some magical logic which maps indexed_db (user consuming API) to indexedDB (driver). The reason for this is that we like to use the protocol.yaml compatible property names in the implementation so we can simply pass locals() to the driver.

) -> StorageState:
result = await self._channel.send_return_as_dict(
"storageState", {"indexedDB": indexedDB}
)
if path:
await async_writefile(path, json.dumps(result))
return result
Expand Down
11 changes: 10 additions & 1 deletion playwright/_impl/_browser_type.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@
from playwright._impl._errors import Error
from playwright._impl._helper import (
ColorScheme,
Contrast,
Env,
ForcedColors,
HarContentPolicy,
Expand DownExpand Up@@ -134,6 +135,7 @@ async def launch_persistent_context(
colorScheme: ColorScheme = None,
reducedMotion: ReducedMotion = None,
forcedColors: ForcedColors = None,
contrast: Contrast = None,
acceptDownloads: bool = None,
tracesDir: Union[pathlib.Path, str] = None,
chromiumSandbox: bool = None,
Expand All@@ -150,7 +152,7 @@ async def launch_persistent_context(
recordHarContent: HarContentPolicy = None,
clientCertificates: List[ClientCertificate] = None,
) -> BrowserContext:
userDataDir = str(Path(userDataDir)) if userDataDir else ""
userDataDir = self._user_data_dir(userDataDir)
params = locals_to_params(locals())
await prepare_browser_context_params(params)
normalize_launch_params(params)
Expand All@@ -161,6 +163,13 @@ async def launch_persistent_context(
self._did_create_context(context, params, params)
return context

def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:
if not userDataDir:
return ""
if not Path(userDataDir).is_absolute():
return str(Path(userDataDir).resolve())
return str(Path(userDataDir))

async def connect_over_cdp(
self,
endpointURL: str,
Expand Down
22 changes: 15 additions & 7 deletions playwright/_impl/_fetch.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ async def new_context(
timeout: float = None,
storageState: Union[StorageState, str, Path] = None,
clientCertificates: List[ClientCertificate] = None,
failOnStatusCode: bool = None,
) -> "APIRequestContext":
params = locals_to_params(locals())
if "storageState" in params:
Expand DownExpand Up@@ -422,9 +423,13 @@ async def _inner_fetch(
return APIResponse(self, response)

async def storage_state(
self, path: Union[pathlib.Path, str] = None
self,
path: Union[pathlib.Path, str] = None,
indexedDB: bool = None,
) -> StorageState:
result = await self._channel.send_return_as_dict("storageState")
result = await self._channel.send_return_as_dict(
"storageState", {"indexedDB": indexedDB}
)
if path:
await async_writefile(path, json.dumps(result))
return result
Expand DownExpand Up@@ -475,11 +480,14 @@ def headers_array(self) -> network.HeadersArray:

async def body(self) -> bytes:
try:
result = await self._request._channel.send_return_as_dict(
"fetchResponseBody",
{
"fetchUid": self._fetch_uid,
},
result = await self._request._connection.wrap_api_call(
lambda: self._request._channel.send_return_as_dict(
"fetchResponseBody",
{
"fetchUid": self._fetch_uid,
},
),
True,
)
if result is None:
raise Error("Response has been disposed")
Expand Down
1 change: 1 addition & 0 deletions playwright/_impl/_helper.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,7 @@

ColorScheme = Literal["dark", "light", "no-preference", "null"]
ForcedColors = Literal["active", "none", "null"]
Contrast = Literal["more", "no-preference", "null"]
ReducedMotion = Literal["no-preference", "null", "reduce"]
DocumentLoadState = Literal["commit", "domcontentloaded", "load", "networkidle"]
KeyboardModifier = Literal["Alt", "Control", "ControlOrMeta", "Meta", "Shift"]
Expand Down
6 changes: 6 additions & 0 deletions playwright/_impl/_locator.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ def __init__(
has_not_text: Union[str, Pattern[str]] = None,
has: "Locator" = None,
has_not: "Locator" = None,
visible: bool = None,
) -> None:
self._frame = frame
self._selector = selector
Expand All@@ -95,6 +96,9 @@ def __init__(
raise Error('Inner "has_not" locator must belong to the same frame.')
self._selector += " >> internal:has-not=" + json.dumps(locator._selector)

if visible is not None:
self._selector += f" >> visible={bool_to_js_bool(visible)}"

def __repr__(self) -> str:
return f"<Locator frame={self._frame!r} selector={self._selector!r}>"

Expand DownExpand Up@@ -338,6 +342,7 @@ def filter(
hasNotText: Union[str, Pattern[str]] = None,
has: "Locator" = None,
hasNot: "Locator" = None,
visible: bool = None,
) -> "Locator":
return Locator(
self._frame,
Expand All@@ -346,6 +351,7 @@ def filter(
has_not_text=hasNotText,
has=has,
has_not=hasNot,
visible=visible,
)

def or_(self, locator: "Locator") -> "Locator":
Expand Down
6 changes: 6 additions & 0 deletions playwright/_impl/_page.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@
from playwright._impl._har_router import HarRouter
from playwright._impl._helper import (
ColorScheme,
Contrast,
DocumentLoadState,
ForcedColors,
HarMode,
Expand DownExpand Up@@ -608,6 +609,7 @@ async def emulate_media(
colorScheme: ColorScheme = None,
reducedMotion: ReducedMotion = None,
forcedColors: ForcedColors = None,
contrast: Contrast = None,
) -> None:
params = locals_to_params(locals())
if "media" in params:
Expand All@@ -624,6 +626,10 @@ async def emulate_media(
params["forcedColors"] = (
"no-override" if params["forcedColors"] == "null" else forcedColors
)
if "contrast" in params:
params["contrast"] = (
"no-override" if params["contrast"] == "null" else contrast
)
await self._channel.send("emulateMedia", params)

async def set_viewport_size(self, viewportSize: ViewportSize) -> None:
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(roll): roll Playwright to 1.51.0-beta-1741166263000 by mxschmitt · Pull Request #2767 · microsoft/playwright-python · GitHub
Skip to content
chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Max Schmitt (mxschmitt)
merged 3 commits into

from

Mar 10, 2025
 Merged


chore(roll): roll Playwright to 1.51.0-beta-1741166263000
#2767
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
4e90d7b

chore(roll): roll Playwright to 1.51.0-beta-1741166263000


mxschmitt Mar 5, 2025
f535d4f

update driver


mxschmitt Mar 6, 2025
10088a6

fixes


mxschmitt Mar 10, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->133.0.6943.16<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->134.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Chromium <!-- GEN:chromium-version -->134.0.6998.35<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->135.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |

## Documentation

Expand Down

5 changes: 5 additions & 0 deletions
playwright/_impl/_browser.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@
from playwright._impl._errors import is_target_closed_error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 ForcedColors,
 HarContentPolicy,
 HarMode,
Expand DownExpand Up@@ -107,6 +108,7 @@ async def new_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
 proxy: ProxySettings = None,
Expand DownExpand Up@@ -152,6 +154,7 @@ async def new_page(
 hasTouch: bool = None,
 colorScheme: ColorScheme = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 reducedMotion: ReducedMotion = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
Expand DownExpand Up@@ -254,6 +257,8 @@ async def prepare_browser_context_params(params: Dict) -> None:
 params["reducedMotion"] = "no-override"
 if params.get("forcedColors", None) == "null":
 params["forcedColors"] = "no-override"
 if params.get("contrast", None) == "null":
 params["contrast"] = "no-override"
 if "acceptDownloads" in params:
 params["acceptDownloads"] = "accept" if params["acceptDownloads"] else "deny"

Expand Down

8 changes: 6 additions & 2 deletions
playwright/_impl/_browser_context.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -599,8 +599,12 @@ async def _inner_close() -> None:
 await self._channel.send("close", {"reason": reason})
 await self._closed_future

 async def storage_state(self, path: Union[str, Path] = None) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 async def storage_state(
 self, path: Union[str, Path] = None, indexedDB: bool = None
@dgozmanDmitry Gozman (dgozman)Mar 6, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not indexed_db?
@mxschmittMax Schmitt (mxschmitt)Mar 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our generator layer has some magical logic which maps indexed_db (user consuming API) to indexedDB (driver). The reason for this is that we like to use the protocol.yaml compatible property names in the implementation so we can simply pass locals() to the driver.
 ) -> StorageState:
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand Down

11 changes: 10 additions & 1 deletion
playwright/_impl/_browser_type.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@
from playwright._impl._errors import Error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 Env,
 ForcedColors,
 HarContentPolicy,
Expand DownExpand Up@@ -134,6 +135,7 @@ async def launch_persistent_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 tracesDir: Union[pathlib.Path, str] = None,
 chromiumSandbox: bool = None,
Expand All@@ -150,7 +152,7 @@ async def launch_persistent_context(
 recordHarContent: HarContentPolicy = None,
 clientCertificates: List[ClientCertificate] = None,
 ) -> BrowserContext:
 userDataDir = str(Path(userDataDir)) if userDataDir else ""
 userDataDir = self._user_data_dir(userDataDir)
 params = locals_to_params(locals())
 await prepare_browser_context_params(params)
 normalize_launch_params(params)
Expand All@@ -161,6 +163,13 @@ async def launch_persistent_context(
 self._did_create_context(context, params, params)
 return context

 def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:
 if not userDataDir:
 return ""
 if not Path(userDataDir).is_absolute():
 return str(Path(userDataDir).resolve())
 return str(Path(userDataDir))

 async def connect_over_cdp(
 self,
 endpointURL: str,
Expand Down

22 changes: 15 additions & 7 deletions
playwright/_impl/_fetch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ async def new_context(
 timeout: float = None,
 storageState: Union[StorageState, str, Path] = None,
 clientCertificates: List[ClientCertificate] = None,
 failOnStatusCode: bool = None,
 ) -> "APIRequestContext":
 params = locals_to_params(locals())
 if "storageState" in params:
Expand DownExpand Up@@ -422,9 +423,13 @@ async def _inner_fetch(
 return APIResponse(self, response)

 async def storage_state(
 self, path: Union[pathlib.Path, str] = None
 self,
 path: Union[pathlib.Path, str] = None,
 indexedDB: bool = None,
 ) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand DownExpand Up@@ -475,11 +480,14 @@ def headers_array(self) -> network.HeadersArray:

 async def body(self) -> bytes:
 try:
 result = await self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 result = await self._request._connection.wrap_api_call(
 lambda: self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 ),
 True,
 )
 if result is None:
 raise Error("Response has been disposed")
Expand Down

1 change: 1 addition & 0 deletions
playwright/_impl/_helper.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,7 @@

ColorScheme = Literal["dark", "light", "no-preference", "null"]
ForcedColors = Literal["active", "none", "null"]
Contrast = Literal["more", "no-preference", "null"]
ReducedMotion = Literal["no-preference", "null", "reduce"]
DocumentLoadState = Literal["commit", "domcontentloaded", "load", "networkidle"]
KeyboardModifier = Literal["Alt", "Control", "ControlOrMeta", "Meta", "Shift"]
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_locator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ def __init__(
 has_not_text: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 has_not: "Locator" = None,
 visible: bool = None,
 ) -> None:
 self._frame = frame
 self._selector = selector
Expand All@@ -95,6 +96,9 @@ def __init__(
 raise Error('Inner "has_not" locator must belong to the same frame.')
 self._selector += " >> internal:has-not=" + json.dumps(locator._selector)

 if visible is not None:
 self._selector += f" >> visible={bool_to_js_bool(visible)}"

 def __repr__(self) -> str:
 return f"<Locator frame={self._frame!r} selector={self._selector!r}>"

Expand DownExpand Up@@ -338,6 +342,7 @@ def filter(
 hasNotText: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 hasNot: "Locator" = None,
 visible: bool = None,
 ) -> "Locator":
 return Locator(
 self._frame,
Expand All@@ -346,6 +351,7 @@ def filter(
 has_not_text=hasNotText,
 has=has,
 has_not=hasNot,
 visible=visible,
 )

 def or_(self, locator: "Locator") -> "Locator":
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_page.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@
from playwright._impl._har_router import HarRouter
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 DocumentLoadState,
 ForcedColors,
 HarMode,
Expand DownExpand Up@@ -608,6 +609,7 @@ async def emulate_media(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 ) -> None:
 params = locals_to_params(locals())
 if "media" in params:
Expand All@@ -624,6 +626,10 @@ async def emulate_media(
 params["forcedColors"] = (
 "no-override" if params["forcedColors"] == "null" else forcedColors
 )
 if "contrast" in params:
 params["contrast"] = (
 "no-override" if params["contrast"] == "null" else contrast
 )
 await self._channel.send("emulateMedia", params)

 async def set_viewport_size(self, viewportSize: ViewportSize) -> None:
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(roll): roll Playwright to 1.51.0-beta-1741166263000 by mxschmitt · Pull Request #2767 · microsoft/playwright-python · GitHub
Skip to content
chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Max Schmitt (mxschmitt)
merged 3 commits into

from

Mar 10, 2025
 Merged


chore(roll): roll Playwright to 1.51.0-beta-1741166263000
#2767
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
4e90d7b

chore(roll): roll Playwright to 1.51.0-beta-1741166263000


mxschmitt Mar 5, 2025
f535d4f

update driver


mxschmitt Mar 6, 2025
10088a6

fixes


mxschmitt Mar 10, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->133.0.6943.16<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->134.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Chromium <!-- GEN:chromium-version -->134.0.6998.35<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->135.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |

## Documentation

Expand Down

5 changes: 5 additions & 0 deletions
playwright/_impl/_browser.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@
from playwright._impl._errors import is_target_closed_error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 ForcedColors,
 HarContentPolicy,
 HarMode,
Expand DownExpand Up@@ -107,6 +108,7 @@ async def new_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
 proxy: ProxySettings = None,
Expand DownExpand Up@@ -152,6 +154,7 @@ async def new_page(
 hasTouch: bool = None,
 colorScheme: ColorScheme = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 reducedMotion: ReducedMotion = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
Expand DownExpand Up@@ -254,6 +257,8 @@ async def prepare_browser_context_params(params: Dict) -> None:
 params["reducedMotion"] = "no-override"
 if params.get("forcedColors", None) == "null":
 params["forcedColors"] = "no-override"
 if params.get("contrast", None) == "null":
 params["contrast"] = "no-override"
 if "acceptDownloads" in params:
 params["acceptDownloads"] = "accept" if params["acceptDownloads"] else "deny"

Expand Down

8 changes: 6 additions & 2 deletions
playwright/_impl/_browser_context.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -599,8 +599,12 @@ async def _inner_close() -> None:
 await self._channel.send("close", {"reason": reason})
 await self._closed_future

 async def storage_state(self, path: Union[str, Path] = None) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 async def storage_state(
 self, path: Union[str, Path] = None, indexedDB: bool = None
@dgozmanDmitry Gozman (dgozman)Mar 6, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not indexed_db?
@mxschmittMax Schmitt (mxschmitt)Mar 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our generator layer has some magical logic which maps indexed_db (user consuming API) to indexedDB (driver). The reason for this is that we like to use the protocol.yaml compatible property names in the implementation so we can simply pass locals() to the driver.
 ) -> StorageState:
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand Down

11 changes: 10 additions & 1 deletion
playwright/_impl/_browser_type.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@
from playwright._impl._errors import Error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 Env,
 ForcedColors,
 HarContentPolicy,
Expand DownExpand Up@@ -134,6 +135,7 @@ async def launch_persistent_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 tracesDir: Union[pathlib.Path, str] = None,
 chromiumSandbox: bool = None,
Expand All@@ -150,7 +152,7 @@ async def launch_persistent_context(
 recordHarContent: HarContentPolicy = None,
 clientCertificates: List[ClientCertificate] = None,
 ) -> BrowserContext:
 userDataDir = str(Path(userDataDir)) if userDataDir else ""
 userDataDir = self._user_data_dir(userDataDir)
 params = locals_to_params(locals())
 await prepare_browser_context_params(params)
 normalize_launch_params(params)
Expand All@@ -161,6 +163,13 @@ async def launch_persistent_context(
 self._did_create_context(context, params, params)
 return context

 def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:
 if not userDataDir:
 return ""
 if not Path(userDataDir).is_absolute():
 return str(Path(userDataDir).resolve())
 return str(Path(userDataDir))

 async def connect_over_cdp(
 self,
 endpointURL: str,
Expand Down

22 changes: 15 additions & 7 deletions
playwright/_impl/_fetch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ async def new_context(
 timeout: float = None,
 storageState: Union[StorageState, str, Path] = None,
 clientCertificates: List[ClientCertificate] = None,
 failOnStatusCode: bool = None,
 ) -> "APIRequestContext":
 params = locals_to_params(locals())
 if "storageState" in params:
Expand DownExpand Up@@ -422,9 +423,13 @@ async def _inner_fetch(
 return APIResponse(self, response)

 async def storage_state(
 self, path: Union[pathlib.Path, str] = None
 self,
 path: Union[pathlib.Path, str] = None,
 indexedDB: bool = None,
 ) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand DownExpand Up@@ -475,11 +480,14 @@ def headers_array(self) -> network.HeadersArray:

 async def body(self) -> bytes:
 try:
 result = await self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 result = await self._request._connection.wrap_api_call(
 lambda: self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 ),
 True,
 )
 if result is None:
 raise Error("Response has been disposed")
Expand Down

1 change: 1 addition & 0 deletions
playwright/_impl/_helper.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,7 @@

ColorScheme = Literal["dark", "light", "no-preference", "null"]
ForcedColors = Literal["active", "none", "null"]
Contrast = Literal["more", "no-preference", "null"]
ReducedMotion = Literal["no-preference", "null", "reduce"]
DocumentLoadState = Literal["commit", "domcontentloaded", "load", "networkidle"]
KeyboardModifier = Literal["Alt", "Control", "ControlOrMeta", "Meta", "Shift"]
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_locator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ def __init__(
 has_not_text: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 has_not: "Locator" = None,
 visible: bool = None,
 ) -> None:
 self._frame = frame
 self._selector = selector
Expand All@@ -95,6 +96,9 @@ def __init__(
 raise Error('Inner "has_not" locator must belong to the same frame.')
 self._selector += " >> internal:has-not=" + json.dumps(locator._selector)

 if visible is not None:
 self._selector += f" >> visible={bool_to_js_bool(visible)}"

 def __repr__(self) -> str:
 return f"<Locator frame={self._frame!r} selector={self._selector!r}>"

Expand DownExpand Up@@ -338,6 +342,7 @@ def filter(
 hasNotText: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 hasNot: "Locator" = None,
 visible: bool = None,
 ) -> "Locator":
 return Locator(
 self._frame,
Expand All@@ -346,6 +351,7 @@ def filter(
 has_not_text=hasNotText,
 has=has,
 has_not=hasNot,
 visible=visible,
 )

 def or_(self, locator: "Locator") -> "Locator":
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_page.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@
from playwright._impl._har_router import HarRouter
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 DocumentLoadState,
 ForcedColors,
 HarMode,
Expand DownExpand Up@@ -608,6 +609,7 @@ async def emulate_media(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 ) -> None:
 params = locals_to_params(locals())
 if "media" in params:
Expand All@@ -624,6 +626,10 @@ async def emulate_media(
 params["forcedColors"] = (
 "no-override" if params["forcedColors"] == "null" else forcedColors
 )
 if "contrast" in params:
 params["contrast"] = (
 "no-override" if params["contrast"] == "null" else contrast
 )
 await self._channel.send("emulateMedia", params)

 async def set_viewport_size(self, viewportSize: ViewportSize) -> None:
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(roll): roll Playwright to 1.51.0-beta-1741166263000 by mxschmitt · Pull Request #2767 · microsoft/playwright-python · GitHub
Skip to content
chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Max Schmitt (mxschmitt)
merged 3 commits into

from

Mar 10, 2025
 Merged


chore(roll): roll Playwright to 1.51.0-beta-1741166263000
#2767
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
4e90d7b

chore(roll): roll Playwright to 1.51.0-beta-1741166263000


mxschmitt Mar 5, 2025
f535d4f

update driver


mxschmitt Mar 6, 2025
10088a6

fixes


mxschmitt Mar 10, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->133.0.6943.16<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->134.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Chromium <!-- GEN:chromium-version -->134.0.6998.35<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->135.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |

## Documentation

Expand Down

5 changes: 5 additions & 0 deletions
playwright/_impl/_browser.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@
from playwright._impl._errors import is_target_closed_error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 ForcedColors,
 HarContentPolicy,
 HarMode,
Expand DownExpand Up@@ -107,6 +108,7 @@ async def new_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
 proxy: ProxySettings = None,
Expand DownExpand Up@@ -152,6 +154,7 @@ async def new_page(
 hasTouch: bool = None,
 colorScheme: ColorScheme = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 reducedMotion: ReducedMotion = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
Expand DownExpand Up@@ -254,6 +257,8 @@ async def prepare_browser_context_params(params: Dict) -> None:
 params["reducedMotion"] = "no-override"
 if params.get("forcedColors", None) == "null":
 params["forcedColors"] = "no-override"
 if params.get("contrast", None) == "null":
 params["contrast"] = "no-override"
 if "acceptDownloads" in params:
 params["acceptDownloads"] = "accept" if params["acceptDownloads"] else "deny"

Expand Down

8 changes: 6 additions & 2 deletions
playwright/_impl/_browser_context.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -599,8 +599,12 @@ async def _inner_close() -> None:
 await self._channel.send("close", {"reason": reason})
 await self._closed_future

 async def storage_state(self, path: Union[str, Path] = None) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 async def storage_state(
 self, path: Union[str, Path] = None, indexedDB: bool = None
@dgozmanDmitry Gozman (dgozman)Mar 6, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not indexed_db?
@mxschmittMax Schmitt (mxschmitt)Mar 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our generator layer has some magical logic which maps indexed_db (user consuming API) to indexedDB (driver). The reason for this is that we like to use the protocol.yaml compatible property names in the implementation so we can simply pass locals() to the driver.
 ) -> StorageState:
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand Down

11 changes: 10 additions & 1 deletion
playwright/_impl/_browser_type.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@
from playwright._impl._errors import Error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 Env,
 ForcedColors,
 HarContentPolicy,
Expand DownExpand Up@@ -134,6 +135,7 @@ async def launch_persistent_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 tracesDir: Union[pathlib.Path, str] = None,
 chromiumSandbox: bool = None,
Expand All@@ -150,7 +152,7 @@ async def launch_persistent_context(
 recordHarContent: HarContentPolicy = None,
 clientCertificates: List[ClientCertificate] = None,
 ) -> BrowserContext:
 userDataDir = str(Path(userDataDir)) if userDataDir else ""
 userDataDir = self._user_data_dir(userDataDir)
 params = locals_to_params(locals())
 await prepare_browser_context_params(params)
 normalize_launch_params(params)
Expand All@@ -161,6 +163,13 @@ async def launch_persistent_context(
 self._did_create_context(context, params, params)
 return context

 def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:
 if not userDataDir:
 return ""
 if not Path(userDataDir).is_absolute():
 return str(Path(userDataDir).resolve())
 return str(Path(userDataDir))

 async def connect_over_cdp(
 self,
 endpointURL: str,
Expand Down

22 changes: 15 additions & 7 deletions
playwright/_impl/_fetch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ async def new_context(
 timeout: float = None,
 storageState: Union[StorageState, str, Path] = None,
 clientCertificates: List[ClientCertificate] = None,
 failOnStatusCode: bool = None,
 ) -> "APIRequestContext":
 params = locals_to_params(locals())
 if "storageState" in params:
Expand DownExpand Up@@ -422,9 +423,13 @@ async def _inner_fetch(
 return APIResponse(self, response)

 async def storage_state(
 self, path: Union[pathlib.Path, str] = None
 self,
 path: Union[pathlib.Path, str] = None,
 indexedDB: bool = None,
 ) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand DownExpand Up@@ -475,11 +480,14 @@ def headers_array(self) -> network.HeadersArray:

 async def body(self) -> bytes:
 try:
 result = await self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 result = await self._request._connection.wrap_api_call(
 lambda: self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 ),
 True,
 )
 if result is None:
 raise Error("Response has been disposed")
Expand Down

1 change: 1 addition & 0 deletions
playwright/_impl/_helper.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,7 @@

ColorScheme = Literal["dark", "light", "no-preference", "null"]
ForcedColors = Literal["active", "none", "null"]
Contrast = Literal["more", "no-preference", "null"]
ReducedMotion = Literal["no-preference", "null", "reduce"]
DocumentLoadState = Literal["commit", "domcontentloaded", "load", "networkidle"]
KeyboardModifier = Literal["Alt", "Control", "ControlOrMeta", "Meta", "Shift"]
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_locator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ def __init__(
 has_not_text: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 has_not: "Locator" = None,
 visible: bool = None,
 ) -> None:
 self._frame = frame
 self._selector = selector
Expand All@@ -95,6 +96,9 @@ def __init__(
 raise Error('Inner "has_not" locator must belong to the same frame.')
 self._selector += " >> internal:has-not=" + json.dumps(locator._selector)

 if visible is not None:
 self._selector += f" >> visible={bool_to_js_bool(visible)}"

 def __repr__(self) -> str:
 return f"<Locator frame={self._frame!r} selector={self._selector!r}>"

Expand DownExpand Up@@ -338,6 +342,7 @@ def filter(
 hasNotText: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 hasNot: "Locator" = None,
 visible: bool = None,
 ) -> "Locator":
 return Locator(
 self._frame,
Expand All@@ -346,6 +351,7 @@ def filter(
 has_not_text=hasNotText,
 has=has,
 has_not=hasNot,
 visible=visible,
 )

 def or_(self, locator: "Locator") -> "Locator":
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_page.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@
from playwright._impl._har_router import HarRouter
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 DocumentLoadState,
 ForcedColors,
 HarMode,
Expand DownExpand Up@@ -608,6 +609,7 @@ async def emulate_media(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 ) -> None:
 params = locals_to_params(locals())
 if "media" in params:
Expand All@@ -624,6 +626,10 @@ async def emulate_media(
 params["forcedColors"] = (
 "no-override" if params["forcedColors"] == "null" else forcedColors
 )
 if "contrast" in params:
 params["contrast"] = (
 "no-override" if params["contrast"] == "null" else contrast
 )
 await self._channel.send("emulateMedia", params)

 async def set_viewport_size(self, viewportSize: ViewportSize) -> None:
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
chore(roll): roll Playwright to 1.51.0-beta-1741166263000 by mxschmitt · Pull Request #2767 · microsoft/playwright-python · GitHub
Skip to content
chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Max Schmitt (mxschmitt)
merged 3 commits into

from

Mar 10, 2025
 Merged


chore(roll): roll Playwright to 1.51.0-beta-1741166263000
#2767
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
4e90d7b

chore(roll): roll Playwright to 1.51.0-beta-1741166263000


mxschmitt Mar 5, 2025
f535d4f

update driver


mxschmitt Mar 6, 2025
10088a6

fixes


mxschmitt Mar 10, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->133.0.6943.16<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->134.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Chromium <!-- GEN:chromium-version -->134.0.6998.35<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->135.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |

## Documentation

Expand Down

5 changes: 5 additions & 0 deletions
playwright/_impl/_browser.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@
from playwright._impl._errors import is_target_closed_error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 ForcedColors,
 HarContentPolicy,
 HarMode,
Expand DownExpand Up@@ -107,6 +108,7 @@ async def new_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
 proxy: ProxySettings = None,
Expand DownExpand Up@@ -152,6 +154,7 @@ async def new_page(
 hasTouch: bool = None,
 colorScheme: ColorScheme = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 reducedMotion: ReducedMotion = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
Expand DownExpand Up@@ -254,6 +257,8 @@ async def prepare_browser_context_params(params: Dict) -> None:
 params["reducedMotion"] = "no-override"
 if params.get("forcedColors", None) == "null":
 params["forcedColors"] = "no-override"
 if params.get("contrast", None) == "null":
 params["contrast"] = "no-override"
 if "acceptDownloads" in params:
 params["acceptDownloads"] = "accept" if params["acceptDownloads"] else "deny"

Expand Down

8 changes: 6 additions & 2 deletions
playwright/_impl/_browser_context.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -599,8 +599,12 @@ async def _inner_close() -> None:
 await self._channel.send("close", {"reason": reason})
 await self._closed_future

 async def storage_state(self, path: Union[str, Path] = None) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 async def storage_state(
 self, path: Union[str, Path] = None, indexedDB: bool = None
@dgozmanDmitry Gozman (dgozman)Mar 6, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not indexed_db?
@mxschmittMax Schmitt (mxschmitt)Mar 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our generator layer has some magical logic which maps indexed_db (user consuming API) to indexedDB (driver). The reason for this is that we like to use the protocol.yaml compatible property names in the implementation so we can simply pass locals() to the driver.
 ) -> StorageState:
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand Down

11 changes: 10 additions & 1 deletion
playwright/_impl/_browser_type.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@
from playwright._impl._errors import Error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 Env,
 ForcedColors,
 HarContentPolicy,
Expand DownExpand Up@@ -134,6 +135,7 @@ async def launch_persistent_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 tracesDir: Union[pathlib.Path, str] = None,
 chromiumSandbox: bool = None,
Expand All@@ -150,7 +152,7 @@ async def launch_persistent_context(
 recordHarContent: HarContentPolicy = None,
 clientCertificates: List[ClientCertificate] = None,
 ) -> BrowserContext:
 userDataDir = str(Path(userDataDir)) if userDataDir else ""
 userDataDir = self._user_data_dir(userDataDir)
 params = locals_to_params(locals())
 await prepare_browser_context_params(params)
 normalize_launch_params(params)
Expand All@@ -161,6 +163,13 @@ async def launch_persistent_context(
 self._did_create_context(context, params, params)
 return context

 def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:
 if not userDataDir:
 return ""
 if not Path(userDataDir).is_absolute():
 return str(Path(userDataDir).resolve())
 return str(Path(userDataDir))

 async def connect_over_cdp(
 self,
 endpointURL: str,
Expand Down

22 changes: 15 additions & 7 deletions
playwright/_impl/_fetch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ async def new_context(
 timeout: float = None,
 storageState: Union[StorageState, str, Path] = None,
 clientCertificates: List[ClientCertificate] = None,
 failOnStatusCode: bool = None,
 ) -> "APIRequestContext":
 params = locals_to_params(locals())
 if "storageState" in params:
Expand DownExpand Up@@ -422,9 +423,13 @@ async def _inner_fetch(
 return APIResponse(self, response)

 async def storage_state(
 self, path: Union[pathlib.Path, str] = None
 self,
 path: Union[pathlib.Path, str] = None,
 indexedDB: bool = None,
 ) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand DownExpand Up@@ -475,11 +480,14 @@ def headers_array(self) -> network.HeadersArray:

 async def body(self) -> bytes:
 try:
 result = await self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 result = await self._request._connection.wrap_api_call(
 lambda: self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 ),
 True,
 )
 if result is None:
 raise Error("Response has been disposed")
Expand Down

1 change: 1 addition & 0 deletions
playwright/_impl/_helper.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,7 @@

ColorScheme = Literal["dark", "light", "no-preference", "null"]
ForcedColors = Literal["active", "none", "null"]
Contrast = Literal["more", "no-preference", "null"]
ReducedMotion = Literal["no-preference", "null", "reduce"]
DocumentLoadState = Literal["commit", "domcontentloaded", "load", "networkidle"]
KeyboardModifier = Literal["Alt", "Control", "ControlOrMeta", "Meta", "Shift"]
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_locator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ def __init__(
 has_not_text: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 has_not: "Locator" = None,
 visible: bool = None,
 ) -> None:
 self._frame = frame
 self._selector = selector
Expand All@@ -95,6 +96,9 @@ def __init__(
 raise Error('Inner "has_not" locator must belong to the same frame.')
 self._selector += " >> internal:has-not=" + json.dumps(locator._selector)

 if visible is not None:
 self._selector += f" >> visible={bool_to_js_bool(visible)}"

 def __repr__(self) -> str:
 return f"<Locator frame={self._frame!r} selector={self._selector!r}>"

Expand DownExpand Up@@ -338,6 +342,7 @@ def filter(
 hasNotText: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 hasNot: "Locator" = None,
 visible: bool = None,
 ) -> "Locator":
 return Locator(
 self._frame,
Expand All@@ -346,6 +351,7 @@ def filter(
 has_not_text=hasNotText,
 has=has,
 has_not=hasNot,
 visible=visible,
 )

 def or_(self, locator: "Locator") -> "Locator":
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_page.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@
from playwright._impl._har_router import HarRouter
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 DocumentLoadState,
 ForcedColors,
 HarMode,
Expand DownExpand Up@@ -608,6 +609,7 @@ async def emulate_media(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 ) -> None:
 params = locals_to_params(locals())
 if "media" in params:
Expand All@@ -624,6 +626,10 @@ async def emulate_media(
 params["forcedColors"] = (
 "no-override" if params["forcedColors"] == "null" else forcedColors
 )
 if "contrast" in params:
 params["contrast"] = (
 "no-override" if params["contrast"] == "null" else contrast
 )
 await self._channel.send("emulateMedia", params)

 async def set_viewport_size(self, viewportSize: ViewportSize) -> None:
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(roll): roll Playwright to 1.51.0-beta-1741166263000 by mxschmitt · Pull Request #2767 · microsoft/playwright-python · GitHub
Skip to content
chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Max Schmitt (mxschmitt)
merged 3 commits into

from

Mar 10, 2025
 Merged


chore(roll): roll Playwright to 1.51.0-beta-1741166263000
#2767
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
4e90d7b

chore(roll): roll Playwright to 1.51.0-beta-1741166263000


mxschmitt Mar 5, 2025
f535d4f

update driver


mxschmitt Mar 6, 2025
10088a6

fixes


mxschmitt Mar 10, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->133.0.6943.16<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->134.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Chromium <!-- GEN:chromium-version -->134.0.6998.35<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->135.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |

## Documentation

Expand Down

5 changes: 5 additions & 0 deletions
playwright/_impl/_browser.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@
from playwright._impl._errors import is_target_closed_error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 ForcedColors,
 HarContentPolicy,
 HarMode,
Expand DownExpand Up@@ -107,6 +108,7 @@ async def new_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
 proxy: ProxySettings = None,
Expand DownExpand Up@@ -152,6 +154,7 @@ async def new_page(
 hasTouch: bool = None,
 colorScheme: ColorScheme = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 reducedMotion: ReducedMotion = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
Expand DownExpand Up@@ -254,6 +257,8 @@ async def prepare_browser_context_params(params: Dict) -> None:
 params["reducedMotion"] = "no-override"
 if params.get("forcedColors", None) == "null":
 params["forcedColors"] = "no-override"
 if params.get("contrast", None) == "null":
 params["contrast"] = "no-override"
 if "acceptDownloads" in params:
 params["acceptDownloads"] = "accept" if params["acceptDownloads"] else "deny"

Expand Down

8 changes: 6 additions & 2 deletions
playwright/_impl/_browser_context.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -599,8 +599,12 @@ async def _inner_close() -> None:
 await self._channel.send("close", {"reason": reason})
 await self._closed_future

 async def storage_state(self, path: Union[str, Path] = None) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 async def storage_state(
 self, path: Union[str, Path] = None, indexedDB: bool = None
@dgozmanDmitry Gozman (dgozman)Mar 6, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not indexed_db?
@mxschmittMax Schmitt (mxschmitt)Mar 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our generator layer has some magical logic which maps indexed_db (user consuming API) to indexedDB (driver). The reason for this is that we like to use the protocol.yaml compatible property names in the implementation so we can simply pass locals() to the driver.
 ) -> StorageState:
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand Down

11 changes: 10 additions & 1 deletion
playwright/_impl/_browser_type.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@
from playwright._impl._errors import Error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 Env,
 ForcedColors,
 HarContentPolicy,
Expand DownExpand Up@@ -134,6 +135,7 @@ async def launch_persistent_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 tracesDir: Union[pathlib.Path, str] = None,
 chromiumSandbox: bool = None,
Expand All@@ -150,7 +152,7 @@ async def launch_persistent_context(
 recordHarContent: HarContentPolicy = None,
 clientCertificates: List[ClientCertificate] = None,
 ) -> BrowserContext:
 userDataDir = str(Path(userDataDir)) if userDataDir else ""
 userDataDir = self._user_data_dir(userDataDir)
 params = locals_to_params(locals())
 await prepare_browser_context_params(params)
 normalize_launch_params(params)
Expand All@@ -161,6 +163,13 @@ async def launch_persistent_context(
 self._did_create_context(context, params, params)
 return context

 def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:
 if not userDataDir:
 return ""
 if not Path(userDataDir).is_absolute():
 return str(Path(userDataDir).resolve())
 return str(Path(userDataDir))

 async def connect_over_cdp(
 self,
 endpointURL: str,
Expand Down

22 changes: 15 additions & 7 deletions
playwright/_impl/_fetch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ async def new_context(
 timeout: float = None,
 storageState: Union[StorageState, str, Path] = None,
 clientCertificates: List[ClientCertificate] = None,
 failOnStatusCode: bool = None,
 ) -> "APIRequestContext":
 params = locals_to_params(locals())
 if "storageState" in params:
Expand DownExpand Up@@ -422,9 +423,13 @@ async def _inner_fetch(
 return APIResponse(self, response)

 async def storage_state(
 self, path: Union[pathlib.Path, str] = None
 self,
 path: Union[pathlib.Path, str] = None,
 indexedDB: bool = None,
 ) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand DownExpand Up@@ -475,11 +480,14 @@ def headers_array(self) -> network.HeadersArray:

 async def body(self) -> bytes:
 try:
 result = await self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 result = await self._request._connection.wrap_api_call(
 lambda: self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 ),
 True,
 )
 if result is None:
 raise Error("Response has been disposed")
Expand Down

1 change: 1 addition & 0 deletions
playwright/_impl/_helper.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,7 @@

ColorScheme = Literal["dark", "light", "no-preference", "null"]
ForcedColors = Literal["active", "none", "null"]
Contrast = Literal["more", "no-preference", "null"]
ReducedMotion = Literal["no-preference", "null", "reduce"]
DocumentLoadState = Literal["commit", "domcontentloaded", "load", "networkidle"]
KeyboardModifier = Literal["Alt", "Control", "ControlOrMeta", "Meta", "Shift"]
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_locator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ def __init__(
 has_not_text: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 has_not: "Locator" = None,
 visible: bool = None,
 ) -> None:
 self._frame = frame
 self._selector = selector
Expand All@@ -95,6 +96,9 @@ def __init__(
 raise Error('Inner "has_not" locator must belong to the same frame.')
 self._selector += " >> internal:has-not=" + json.dumps(locator._selector)

 if visible is not None:
 self._selector += f" >> visible={bool_to_js_bool(visible)}"

 def __repr__(self) -> str:
 return f"<Locator frame={self._frame!r} selector={self._selector!r}>"

Expand DownExpand Up@@ -338,6 +342,7 @@ def filter(
 hasNotText: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 hasNot: "Locator" = None,
 visible: bool = None,
 ) -> "Locator":
 return Locator(
 self._frame,
Expand All@@ -346,6 +351,7 @@ def filter(
 has_not_text=hasNotText,
 has=has,
 has_not=hasNot,
 visible=visible,
 )

 def or_(self, locator: "Locator") -> "Locator":
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_page.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@
from playwright._impl._har_router import HarRouter
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 DocumentLoadState,
 ForcedColors,
 HarMode,
Expand DownExpand Up@@ -608,6 +609,7 @@ async def emulate_media(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 ) -> None:
 params = locals_to_params(locals())
 if "media" in params:
Expand All@@ -624,6 +626,10 @@ async def emulate_media(
 params["forcedColors"] = (
 "no-override" if params["forcedColors"] == "null" else forcedColors
 )
 if "contrast" in params:
 params["contrast"] = (
 "no-override" if params["contrast"] == "null" else contrast
 )
 await self._channel.send("emulateMedia", params)

 async def set_viewport_size(self, viewportSize: ViewportSize) -> None:
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
chore(roll): roll Playwright to 1.51.0-beta-1741166263000 by mxschmitt · Pull Request #2767 · microsoft/playwright-python · GitHub
Skip to content
chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Max Schmitt (mxschmitt)
merged 3 commits into

from

Mar 10, 2025
 Merged


chore(roll): roll Playwright to 1.51.0-beta-1741166263000
#2767
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
4e90d7b

chore(roll): roll Playwright to 1.51.0-beta-1741166263000


mxschmitt Mar 5, 2025
f535d4f

update driver


mxschmitt Mar 6, 2025
10088a6

fixes


mxschmitt Mar 10, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->133.0.6943.16<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->134.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Chromium <!-- GEN:chromium-version -->134.0.6998.35<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->135.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |

## Documentation

Expand Down

5 changes: 5 additions & 0 deletions
playwright/_impl/_browser.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@
from playwright._impl._errors import is_target_closed_error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 ForcedColors,
 HarContentPolicy,
 HarMode,
Expand DownExpand Up@@ -107,6 +108,7 @@ async def new_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
 proxy: ProxySettings = None,
Expand DownExpand Up@@ -152,6 +154,7 @@ async def new_page(
 hasTouch: bool = None,
 colorScheme: ColorScheme = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 reducedMotion: ReducedMotion = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
Expand DownExpand Up@@ -254,6 +257,8 @@ async def prepare_browser_context_params(params: Dict) -> None:
 params["reducedMotion"] = "no-override"
 if params.get("forcedColors", None) == "null":
 params["forcedColors"] = "no-override"
 if params.get("contrast", None) == "null":
 params["contrast"] = "no-override"
 if "acceptDownloads" in params:
 params["acceptDownloads"] = "accept" if params["acceptDownloads"] else "deny"

Expand Down

8 changes: 6 additions & 2 deletions
playwright/_impl/_browser_context.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -599,8 +599,12 @@ async def _inner_close() -> None:
 await self._channel.send("close", {"reason": reason})
 await self._closed_future

 async def storage_state(self, path: Union[str, Path] = None) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 async def storage_state(
 self, path: Union[str, Path] = None, indexedDB: bool = None
@dgozmanDmitry Gozman (dgozman)Mar 6, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not indexed_db?
@mxschmittMax Schmitt (mxschmitt)Mar 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our generator layer has some magical logic which maps indexed_db (user consuming API) to indexedDB (driver). The reason for this is that we like to use the protocol.yaml compatible property names in the implementation so we can simply pass locals() to the driver.
 ) -> StorageState:
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand Down

11 changes: 10 additions & 1 deletion
playwright/_impl/_browser_type.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@
from playwright._impl._errors import Error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 Env,
 ForcedColors,
 HarContentPolicy,
Expand DownExpand Up@@ -134,6 +135,7 @@ async def launch_persistent_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 tracesDir: Union[pathlib.Path, str] = None,
 chromiumSandbox: bool = None,
Expand All@@ -150,7 +152,7 @@ async def launch_persistent_context(
 recordHarContent: HarContentPolicy = None,
 clientCertificates: List[ClientCertificate] = None,
 ) -> BrowserContext:
 userDataDir = str(Path(userDataDir)) if userDataDir else ""
 userDataDir = self._user_data_dir(userDataDir)
 params = locals_to_params(locals())
 await prepare_browser_context_params(params)
 normalize_launch_params(params)
Expand All@@ -161,6 +163,13 @@ async def launch_persistent_context(
 self._did_create_context(context, params, params)
 return context

 def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:
 if not userDataDir:
 return ""
 if not Path(userDataDir).is_absolute():
 return str(Path(userDataDir).resolve())
 return str(Path(userDataDir))

 async def connect_over_cdp(
 self,
 endpointURL: str,
Expand Down

22 changes: 15 additions & 7 deletions
playwright/_impl/_fetch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ async def new_context(
 timeout: float = None,
 storageState: Union[StorageState, str, Path] = None,
 clientCertificates: List[ClientCertificate] = None,
 failOnStatusCode: bool = None,
 ) -> "APIRequestContext":
 params = locals_to_params(locals())
 if "storageState" in params:
Expand DownExpand Up@@ -422,9 +423,13 @@ async def _inner_fetch(
 return APIResponse(self, response)

 async def storage_state(
 self, path: Union[pathlib.Path, str] = None
 self,
 path: Union[pathlib.Path, str] = None,
 indexedDB: bool = None,
 ) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand DownExpand Up@@ -475,11 +480,14 @@ def headers_array(self) -> network.HeadersArray:

 async def body(self) -> bytes:
 try:
 result = await self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 result = await self._request._connection.wrap_api_call(
 lambda: self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 ),
 True,
 )
 if result is None:
 raise Error("Response has been disposed")
Expand Down

1 change: 1 addition & 0 deletions
playwright/_impl/_helper.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,7 @@

ColorScheme = Literal["dark", "light", "no-preference", "null"]
ForcedColors = Literal["active", "none", "null"]
Contrast = Literal["more", "no-preference", "null"]
ReducedMotion = Literal["no-preference", "null", "reduce"]
DocumentLoadState = Literal["commit", "domcontentloaded", "load", "networkidle"]
KeyboardModifier = Literal["Alt", "Control", "ControlOrMeta", "Meta", "Shift"]
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_locator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ def __init__(
 has_not_text: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 has_not: "Locator" = None,
 visible: bool = None,
 ) -> None:
 self._frame = frame
 self._selector = selector
Expand All@@ -95,6 +96,9 @@ def __init__(
 raise Error('Inner "has_not" locator must belong to the same frame.')
 self._selector += " >> internal:has-not=" + json.dumps(locator._selector)

 if visible is not None:
 self._selector += f" >> visible={bool_to_js_bool(visible)}"

 def __repr__(self) -> str:
 return f"<Locator frame={self._frame!r} selector={self._selector!r}>"

Expand DownExpand Up@@ -338,6 +342,7 @@ def filter(
 hasNotText: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 hasNot: "Locator" = None,
 visible: bool = None,
 ) -> "Locator":
 return Locator(
 self._frame,
Expand All@@ -346,6 +351,7 @@ def filter(
 has_not_text=hasNotText,
 has=has,
 has_not=hasNot,
 visible=visible,
 )

 def or_(self, locator: "Locator") -> "Locator":
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_page.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@
from playwright._impl._har_router import HarRouter
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 DocumentLoadState,
 ForcedColors,
 HarMode,
Expand DownExpand Up@@ -608,6 +609,7 @@ async def emulate_media(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 ) -> None:
 params = locals_to_params(locals())
 if "media" in params:
Expand All@@ -624,6 +626,10 @@ async def emulate_media(
 params["forcedColors"] = (
 "no-override" if params["forcedColors"] == "null" else forcedColors
 )
 if "contrast" in params:
 params["contrast"] = (
 "no-override" if params["contrast"] == "null" else contrast
 )
 await self._channel.send("emulateMedia", params)

 async def set_viewport_size(self, viewportSize: ViewportSize) -> None:
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
chore(roll): roll Playwright to 1.51.0-beta-1741166263000 by mxschmitt · Pull Request #2767 · microsoft/playwright-python · GitHub
Skip to content
chore(roll): roll Playwright to 1.51.0-beta-1741166263000#2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Max Schmitt (mxschmitt)
merged 3 commits into

from

Mar 10, 2025
 Merged


chore(roll): roll Playwright to 1.51.0-beta-1741166263000
#2767
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
4e90d7b

chore(roll): roll Playwright to 1.51.0-beta-1741166263000


mxschmitt Mar 5, 2025
f535d4f

update driver


mxschmitt Mar 6, 2025
10088a6

fixes


mxschmitt Mar 10, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,9 +4,9 @@ Playwright is a Python library to automate [Chromium](https://www.chromium.org/H

| | Linux | macOS | Windows |
| :--- | :---: | :---: | :---: |
| Chromium <!-- GEN:chromium-version -->133.0.6943.16<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.2<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->134.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Chromium <!-- GEN:chromium-version -->134.0.6998.35<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| WebKit <!-- GEN:webkit-version -->18.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
| Firefox <!-- GEN:firefox-version -->135.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |

## Documentation

Expand Down

5 changes: 5 additions & 0 deletions
playwright/_impl/_browser.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,6 +32,7 @@
from playwright._impl._errors import is_target_closed_error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 ForcedColors,
 HarContentPolicy,
 HarMode,
Expand DownExpand Up@@ -107,6 +108,7 @@ async def new_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
 proxy: ProxySettings = None,
Expand DownExpand Up@@ -152,6 +154,7 @@ async def new_page(
 hasTouch: bool = None,
 colorScheme: ColorScheme = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 reducedMotion: ReducedMotion = None,
 acceptDownloads: bool = None,
 defaultBrowserType: str = None,
Expand DownExpand Up@@ -254,6 +257,8 @@ async def prepare_browser_context_params(params: Dict) -> None:
 params["reducedMotion"] = "no-override"
 if params.get("forcedColors", None) == "null":
 params["forcedColors"] = "no-override"
 if params.get("contrast", None) == "null":
 params["contrast"] = "no-override"
 if "acceptDownloads" in params:
 params["acceptDownloads"] = "accept" if params["acceptDownloads"] else "deny"

Expand Down

8 changes: 6 additions & 2 deletions
playwright/_impl/_browser_context.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -599,8 +599,12 @@ async def _inner_close() -> None:
 await self._channel.send("close", {"reason": reason})
 await self._closed_future

 async def storage_state(self, path: Union[str, Path] = None) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 async def storage_state(
 self, path: Union[str, Path] = None, indexedDB: bool = None
@dgozmanDmitry Gozman (dgozman)Mar 6, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not indexed_db?
@mxschmittMax Schmitt (mxschmitt)Mar 6, 2025

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our generator layer has some magical logic which maps indexed_db (user consuming API) to indexedDB (driver). The reason for this is that we like to use the protocol.yaml compatible property names in the implementation so we can simply pass locals() to the driver.
 ) -> StorageState:
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand Down

11 changes: 10 additions & 1 deletion
playwright/_impl/_browser_type.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,6 +35,7 @@
from playwright._impl._errors import Error
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 Env,
 ForcedColors,
 HarContentPolicy,
Expand DownExpand Up@@ -134,6 +135,7 @@ async def launch_persistent_context(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 acceptDownloads: bool = None,
 tracesDir: Union[pathlib.Path, str] = None,
 chromiumSandbox: bool = None,
Expand All@@ -150,7 +152,7 @@ async def launch_persistent_context(
 recordHarContent: HarContentPolicy = None,
 clientCertificates: List[ClientCertificate] = None,
 ) -> BrowserContext:
 userDataDir = str(Path(userDataDir)) if userDataDir else ""
 userDataDir = self._user_data_dir(userDataDir)
 params = locals_to_params(locals())
 await prepare_browser_context_params(params)
 normalize_launch_params(params)
Expand All@@ -161,6 +163,13 @@ async def launch_persistent_context(
 self._did_create_context(context, params, params)
 return context

 def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:
 if not userDataDir:
 return ""
 if not Path(userDataDir).is_absolute():
 return str(Path(userDataDir).resolve())
 return str(Path(userDataDir))

 async def connect_over_cdp(
 self,
 endpointURL: str,
Expand Down

22 changes: 15 additions & 7 deletions
playwright/_impl/_fetch.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -73,6 +73,7 @@ async def new_context(
 timeout: float = None,
 storageState: Union[StorageState, str, Path] = None,
 clientCertificates: List[ClientCertificate] = None,
 failOnStatusCode: bool = None,
 ) -> "APIRequestContext":
 params = locals_to_params(locals())
 if "storageState" in params:
Expand DownExpand Up@@ -422,9 +423,13 @@ async def _inner_fetch(
 return APIResponse(self, response)

 async def storage_state(
 self, path: Union[pathlib.Path, str] = None
 self,
 path: Union[pathlib.Path, str] = None,
 indexedDB: bool = None,
 ) -> StorageState:
 result = await self._channel.send_return_as_dict("storageState")
 result = await self._channel.send_return_as_dict(
 "storageState", {"indexedDB": indexedDB}
 )
 if path:
 await async_writefile(path, json.dumps(result))
 return result
Expand DownExpand Up@@ -475,11 +480,14 @@ def headers_array(self) -> network.HeadersArray:

 async def body(self) -> bytes:
 try:
 result = await self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 result = await self._request._connection.wrap_api_call(
 lambda: self._request._channel.send_return_as_dict(
 "fetchResponseBody",
 {
 "fetchUid": self._fetch_uid,
 },
 ),
 True,
 )
 if result is None:
 raise Error("Response has been disposed")
Expand Down

1 change: 1 addition & 0 deletions
playwright/_impl/_helper.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,7 @@

ColorScheme = Literal["dark", "light", "no-preference", "null"]
ForcedColors = Literal["active", "none", "null"]
Contrast = Literal["more", "no-preference", "null"]
ReducedMotion = Literal["no-preference", "null", "reduce"]
DocumentLoadState = Literal["commit", "domcontentloaded", "load", "networkidle"]
KeyboardModifier = Literal["Alt", "Control", "ControlOrMeta", "Meta", "Shift"]
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_locator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ def __init__(
 has_not_text: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 has_not: "Locator" = None,
 visible: bool = None,
 ) -> None:
 self._frame = frame
 self._selector = selector
Expand All@@ -95,6 +96,9 @@ def __init__(
 raise Error('Inner "has_not" locator must belong to the same frame.')
 self._selector += " >> internal:has-not=" + json.dumps(locator._selector)

 if visible is not None:
 self._selector += f" >> visible={bool_to_js_bool(visible)}"

 def __repr__(self) -> str:
 return f"<Locator frame={self._frame!r} selector={self._selector!r}>"

Expand DownExpand Up@@ -338,6 +342,7 @@ def filter(
 hasNotText: Union[str, Pattern[str]] = None,
 has: "Locator" = None,
 hasNot: "Locator" = None,
 visible: bool = None,
 ) -> "Locator":
 return Locator(
 self._frame,
Expand All@@ -346,6 +351,7 @@ def filter(
 has_not_text=hasNotText,
 has=has,
 has_not=hasNot,
 visible=visible,
 )

 def or_(self, locator: "Locator") -> "Locator":
Expand Down

6 changes: 6 additions & 0 deletions
playwright/_impl/_page.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -60,6 +60,7 @@
from playwright._impl._har_router import HarRouter
from playwright._impl._helper import (
 ColorScheme,
 Contrast,
 DocumentLoadState,
 ForcedColors,
 HarMode,
Expand DownExpand Up@@ -608,6 +609,7 @@ async def emulate_media(
 colorScheme: ColorScheme = None,
 reducedMotion: ReducedMotion = None,
 forcedColors: ForcedColors = None,
 contrast: Contrast = None,
 ) -> None:
 params = locals_to_params(locals())
 if "media" in params:
Expand All@@ -624,6 +626,10 @@ async def emulate_media(
 params["forcedColors"] = (
 "no-override" if params["forcedColors"] == "null" else forcedColors
 )
 if "contrast" in params:
 params["contrast"] = (
 "no-override" if params["contrast"] == "null" else contrast
 )
 await self._channel.send("emulateMedia", params)

 async def set_viewport_size(self, viewportSize: ViewportSize) -> None:
Expand Down
Loading