feat(api): add screencast size option

[Rohan Patnaik (rohan-patnaik)]

Fixes#3083

Summary

This adds the missing size option to page.screencast.start() for both async and sync Python APIs.

Why

The screencast protocol already accepts a size, but Python users could only set quality, path, and on_frame. That meant users could not control screencast frame/video resolution without changing the page viewport.

Test plan

• python3 - <<'PY' signature import check for async and sync Screencast.start
• git diff --check

[Simon Knott (Skn0tt)]

Don't change the _generated.py files by hand.

[Rohan Patnaik (rohan-patnaik)]

Simon Knott (@Skn0tt) thanks, you’re right. I hand-edited _generated.py because I saw size was already accepted by the driver/protocol path and assumed the Python wrapper was just missing the same option.

I should have checked the generation source first. After doing that, I found Screencast.start.size is present in api.json, but marked langs.only: ["js"], so Python codegen intentionally filters its docs out.

If you’re open to reopening this PR, I can fix it properly by keeping the _impl change, regenerating the wrappers, and adding the expected API mismatch. If you’d prefer this to be fixed in upstream API metadata first, I can move it there instead.

[Rohan Patnaik (rohan-patnaik)]

Just found that microsoft/playwright#41183 fixed the upstream source-of-truth metadata for this by removing the JS-only marker from Screencast.start.size.
It makes sense to leave this PR closed then.

[Rohan Patnaik (rohan-patnaik)]

Fixes#3083

Summary

This adds the missing size option to page.screencast.start() for both async and sync Python APIs.

Why

The screencast protocol already accepts a size, but Python users could only set quality, path, and on_frame. That meant users could not control screencast frame/video resolution without changing the page viewport.

Test plan

• python3 - <<'PY' signature import check for async and sync Screencast.start
• git diff --check

[Simon Knott (Skn0tt)]

Don't change the _generated.py files by hand.

[Rohan Patnaik (rohan-patnaik)]

Simon Knott (@Skn0tt) thanks, you’re right. I hand-edited _generated.py because I saw size was already accepted by the driver/protocol path and assumed the Python wrapper was just missing the same option.

I should have checked the generation source first. After doing that, I found Screencast.start.size is present in api.json, but marked langs.only: ["js"], so Python codegen intentionally filters its docs out.

If you’re open to reopening this PR, I can fix it properly by keeping the _impl change, regenerating the wrappers, and adding the expected API mismatch. If you’d prefer this to be fixed in upstream API metadata first, I can move it there instead.

[Rohan Patnaik (rohan-patnaik)]

Just found that microsoft/playwright#41183 fixed the upstream source-of-truth metadata for this by removing the JS-only marker from Screencast.start.size.
It makes sense to leave this PR closed then.

[Rohan Patnaik (rohan-patnaik)]

Fixes#3083

Summary

This adds the missing size option to page.screencast.start() for both async and sync Python APIs.

Why

The screencast protocol already accepts a size, but Python users could only set quality, path, and on_frame. That meant users could not control screencast frame/video resolution without changing the page viewport.

Test plan

• python3 - <<'PY' signature import check for async and sync Screencast.start
• git diff --check

[Simon Knott (Skn0tt)]

Don't change the _generated.py files by hand.

[Rohan Patnaik (rohan-patnaik)]

Simon Knott (@Skn0tt) thanks, you’re right. I hand-edited _generated.py because I saw size was already accepted by the driver/protocol path and assumed the Python wrapper was just missing the same option.

I should have checked the generation source first. After doing that, I found Screencast.start.size is present in api.json, but marked langs.only: ["js"], so Python codegen intentionally filters its docs out.

If you’re open to reopening this PR, I can fix it properly by keeping the _impl change, regenerating the wrappers, and adding the expected API mismatch. If you’d prefer this to be fixed in upstream API metadata first, I can move it there instead.

[Rohan Patnaik (rohan-patnaik)]

Just found that microsoft/playwright#41183 fixed the upstream source-of-truth metadata for this by removing the JS-only marker from Screencast.start.size.
It makes sense to leave this PR closed then.

[Rohan Patnaik (rohan-patnaik)]

Fixes#3083

Summary

This adds the missing size option to page.screencast.start() for both async and sync Python APIs.

Why

The screencast protocol already accepts a size, but Python users could only set quality, path, and on_frame. That meant users could not control screencast frame/video resolution without changing the page viewport.

Test plan

• python3 - <<'PY' signature import check for async and sync Screencast.start
• git diff --check

[Simon Knott (Skn0tt)]

Don't change the _generated.py files by hand.

[Rohan Patnaik (rohan-patnaik)]

Simon Knott (@Skn0tt) thanks, you’re right. I hand-edited _generated.py because I saw size was already accepted by the driver/protocol path and assumed the Python wrapper was just missing the same option.

I should have checked the generation source first. After doing that, I found Screencast.start.size is present in api.json, but marked langs.only: ["js"], so Python codegen intentionally filters its docs out.

If you’re open to reopening this PR, I can fix it properly by keeping the _impl change, regenerating the wrappers, and adding the expected API mismatch. If you’d prefer this to be fixed in upstream API metadata first, I can move it there instead.

[Rohan Patnaik (rohan-patnaik)]

Just found that microsoft/playwright#41183 fixed the upstream source-of-truth metadata for this by removing the JS-only marker from Screencast.start.size.
It makes sense to leave this PR closed then.

[Rohan Patnaik (rohan-patnaik)]

Fixes#3083

Summary

This adds the missing size option to page.screencast.start() for both async and sync Python APIs.

Why

The screencast protocol already accepts a size, but Python users could only set quality, path, and on_frame. That meant users could not control screencast frame/video resolution without changing the page viewport.

Test plan

• python3 - <<'PY' signature import check for async and sync Screencast.start
• git diff --check

[Simon Knott (Skn0tt)]

Don't change the _generated.py files by hand.

[Rohan Patnaik (rohan-patnaik)]

Simon Knott (@Skn0tt) thanks, you’re right. I hand-edited _generated.py because I saw size was already accepted by the driver/protocol path and assumed the Python wrapper was just missing the same option.

I should have checked the generation source first. After doing that, I found Screencast.start.size is present in api.json, but marked langs.only: ["js"], so Python codegen intentionally filters its docs out.

If you’re open to reopening this PR, I can fix it properly by keeping the _impl change, regenerating the wrappers, and adding the expected API mismatch. If you’d prefer this to be fixed in upstream API metadata first, I can move it there instead.

[Rohan Patnaik (rohan-patnaik)]

Just found that microsoft/playwright#41183 fixed the upstream source-of-truth metadata for this by removing the JS-only marker from Screencast.start.size.
It makes sense to leave this PR closed then.

[Rohan Patnaik (rohan-patnaik)]

Fixes#3083

Summary

This adds the missing size option to page.screencast.start() for both async and sync Python APIs.

Why

The screencast protocol already accepts a size, but Python users could only set quality, path, and on_frame. That meant users could not control screencast frame/video resolution without changing the page viewport.

Test plan

• python3 - <<'PY' signature import check for async and sync Screencast.start
• git diff --check

[Simon Knott (Skn0tt)]

Don't change the _generated.py files by hand.

[Rohan Patnaik (rohan-patnaik)]

Simon Knott (@Skn0tt) thanks, you’re right. I hand-edited _generated.py because I saw size was already accepted by the driver/protocol path and assumed the Python wrapper was just missing the same option.

I should have checked the generation source first. After doing that, I found Screencast.start.size is present in api.json, but marked langs.only: ["js"], so Python codegen intentionally filters its docs out.

If you’re open to reopening this PR, I can fix it properly by keeping the _impl change, regenerating the wrappers, and adding the expected API mismatch. If you’d prefer this to be fixed in upstream API metadata first, I can move it there instead.

[Rohan Patnaik (rohan-patnaik)]

Just found that microsoft/playwright#41183 fixed the upstream source-of-truth metadata for this by removing the JS-only marker from Screencast.start.size.
It makes sense to leave this PR closed then.

[Rohan Patnaik (rohan-patnaik)]

Fixes#3083

Summary

This adds the missing size option to page.screencast.start() for both async and sync Python APIs.

Why

The screencast protocol already accepts a size, but Python users could only set quality, path, and on_frame. That meant users could not control screencast frame/video resolution without changing the page viewport.

Test plan

• python3 - <<'PY' signature import check for async and sync Screencast.start
• git diff --check

[Simon Knott (Skn0tt)]

Don't change the _generated.py files by hand.

[Rohan Patnaik (rohan-patnaik)]

Simon Knott (@Skn0tt) thanks, you’re right. I hand-edited _generated.py because I saw size was already accepted by the driver/protocol path and assumed the Python wrapper was just missing the same option.

I should have checked the generation source first. After doing that, I found Screencast.start.size is present in api.json, but marked langs.only: ["js"], so Python codegen intentionally filters its docs out.

If you’re open to reopening this PR, I can fix it properly by keeping the _impl change, regenerating the wrappers, and adding the expected API mismatch. If you’d prefer this to be fixed in upstream API metadata first, I can move it there instead.

[Rohan Patnaik (rohan-patnaik)]

Just found that microsoft/playwright#41183 fixed the upstream source-of-truth metadata for this by removing the JS-only marker from Screencast.start.size.
It makes sense to leave this PR closed then.

[Rohan Patnaik (rohan-patnaik)]

Fixes#3083

Summary

This adds the missing size option to page.screencast.start() for both async and sync Python APIs.

Why

The screencast protocol already accepts a size, but Python users could only set quality, path, and on_frame. That meant users could not control screencast frame/video resolution without changing the page viewport.

Test plan

• python3 - <<'PY' signature import check for async and sync Screencast.start
• git diff --check

[Simon Knott (Skn0tt)]

Don't change the _generated.py files by hand.

[Rohan Patnaik (rohan-patnaik)]

Simon Knott (@Skn0tt) thanks, you’re right. I hand-edited _generated.py because I saw size was already accepted by the driver/protocol path and assumed the Python wrapper was just missing the same option.

I should have checked the generation source first. After doing that, I found Screencast.start.size is present in api.json, but marked langs.only: ["js"], so Python codegen intentionally filters its docs out.

If you’re open to reopening this PR, I can fix it properly by keeping the _impl change, regenerating the wrappers, and adding the expected API mismatch. If you’d prefer this to be fixed in upstream API metadata first, I can move it there instead.

[Rohan Patnaik (rohan-patnaik)]

Just found that microsoft/playwright#41183 fixed the upstream source-of-truth metadata for this by removing the JS-only marker from Screencast.start.size.
It makes sense to leave this PR closed then.