Skip to content

chore(protocol): implement client side hello - #836

Merged
mxschmitt merged 8 commits into
microsoft:masterfrom
mxschmitt:new-protocol
Aug 26, 2021
Merged

chore(protocol): implement client side hello#836
mxschmitt merged 8 commits into
microsoft:masterfrom
mxschmitt:new-protocol

Conversation

@mxschmitt

@mxschmittmxschmitt commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@mxschmittmxschmitt mentioned this pull request Aug 5, 2021
Merged
pavelfeldman
pavelfeldman reviewed Aug 5, 2021
View reviewed changes
Comment threadplaywright/async_api/_context_manager.py Outdated
kumaraditya303
kumaraditya303 reviewed Aug 8, 2021
View reviewed changes
Comment threadplaywright/_impl/_connection.py Outdated
@mxschmitt
mxschmittforce-pushed the new-protocol branch 2 times, most recently from 50e081e to f48ec89CompareAugust 19, 2021 15:44
@mxschmitt
mxschmitt marked this pull request as ready for review August 19, 2021 15:44
@mxschmitt
mxschmittforce-pushed the new-protocol branch 2 times, most recently from 3a54b87 to 2de45fbCompareAugust 19, 2021 17:50
kumaraditya303
kumaraditya303 reviewed Aug 19, 2021
View reviewed changes
Comment threadplaywright/_impl/_transport.py Outdated
Comment threadplaywright/_impl/_transport.py Outdated
Comment threadplaywright/sync_api/_context_manager.py Outdated
@mxschmitt
mxschmittforce-pushed the new-protocol branch 2 times, most recently from 964b217 to d5cdd0bCompareAugust 19, 2021 19:50
kumaraditya303
kumaraditya303 reviewed Aug 20, 2021
View reviewed changes
Comment threadplaywright/_impl/_browser_type.py Outdated
kumaraditya303
kumaraditya303 reviewed Aug 20, 2021
View reviewed changes
Comment threadplaywright/_impl/_connection.py Outdated
kumaraditya303
kumaraditya303 reviewed Aug 24, 2021
View reviewed changes
Comment threadplaywright/_impl/_transport.py Outdated
kumaraditya303
kumaraditya303 reviewed Aug 24, 2021
View reviewed changes
Comment threadplaywright/_impl/_transport.py Outdated
kumaraditya303
kumaraditya303 reviewed Aug 24, 2021
View reviewed changes
Comment threadplaywright/_impl/_transport.py Outdated
@pavelfeldman

pavelfeldman commented Aug 24, 2021

Copy link
Copy Markdown
Member

I don't think we want all those callbacks. Now that the client is establishing the connection, can we have something simple like connection.connect() that returns the Playwright object?

pavelfeldman
pavelfeldman reviewed Aug 25, 2021
View reviewed changes
Comment threadplaywright/_impl/_connection.py
@mxschmitt
mxschmittforce-pushed the new-protocol branch 2 times, most recently from e618f77 to 25950ceCompareAugust 25, 2021 13:40
@mxschmitt
mxschmittforce-pushed the new-protocol branch 2 times, most recently from f66c5be to 02e5fb0CompareAugust 26, 2021 19:56
pavelfeldman
pavelfeldman approved these changes Aug 26, 2021
View reviewed changes
Comment threadplaywright/_impl/_connection.py Outdated
@mxschmitt
mxschmitt merged commit 5981155 into microsoft:masterAug 26, 2021
@Skn0ttSkn0tt mentioned this pull request Aug 4, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldmanpavelfeldmanpavelfeldman approved these changes
+1 more reviewer
@kumaraditya303kumaraditya303kumaraditya303 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mxschmitt@pavelfeldman@kumaraditya303