Uh oh!
There was an error while loading. Please reload this page.
api(popups): move Page.authenticate to BrowserContext.setHTTPCredentials - #1267
Merged
Andrey Lushnikov (aslushnikov) merged 1 commit intoMar 6, 2020
Merged
Conversation
Dmitry Gozman (dgozman)
approved these changes
Mar 6, 2020
Andrey Lushnikov (aslushnikov)force-pushed
the
bc-auth
branch
2 times, most recently
from
March 6, 2020 20:24
eb182f4 to
f291257CompareAndrey Lushnikov (aslushnikov)force-pushed
the
bc-auth
branch
from
March 6, 2020 21:34
f291257 to
c3e1ab1Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drive-by: fixes#720 since it rolls past r1037.