Uh oh!
There was an error while loading. Please reload this page.
feat(aria): extend toHaveAccessibleName() to accept an array of expected accessible names - #33277
Conversation
…ted accessible names This commit extends the toHaveAccessibleName() matcher to support an array References microsoft#32593
This commit includes the handling accessible.name.array References microsoft#32593
The expected string can be asserting softly without being equivalent to the actual string References microsoft#32593
This comment has been minimized.
This comment has been minimized.
aairiian
commented
Oct 25, 2024
@microsoft-github-policy-service agree |
Update type in the doc References microsoft#32593
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Simon Knott (Skn0tt)
left a comment
There was a problem hiding this comment.
Thanks for the PR, this looks great! I'll discuss with the team tonight to see if there's anything we need to pay close attention to.
| }, expected, options); | ||
| if (Array.isArray(expected)) { | ||
| return toEqual.call(this, 'toHaveAccessibleName', locator, 'Locator', async (isNot, timeout) => { | ||
| const expectedText = serializeExpectedTextValues(expected, { matchSubstring: true, normalizeWhiteSpace: true, ignoreCase: options.ignoreCase }); |
There was a problem hiding this comment.
I'd prefer the changes to normalizeWhiteSpace and matchSubstring to be in a separate PR, and discuss them in an issue first - especially the matchSubstring one sounds breaking to me.
Let's keep this PR strictly about accepting an array.
There was a problem hiding this comment.
+1, let's only land the array aspect.
There was a problem hiding this comment.
I excluded the matchSubstring option from the string serialization
We're happy to go forward with this. We have a related feature in the works that's about ARIA snapshots, and that should be strictly better than the array forms of |
aairiian
commented
Oct 30, 2024
Thank you for getting back to me. I appreciate the time you've taken to review my PR and consider it 😌🙏🏻 |
| ### param: LocatorAssertions.toHaveAccessibleName.name | ||
| * since: v1.44 | ||
| - `name` <[string]|[RegExp]> | ||
| - `name` <[string]|[RegExp]|[Array]<[string]>|[Array]<[RegExp]>> |
There was a problem hiding this comment.
This should be [Array]<[string]|[RegExp]>
| }, expected, options); | ||
| if (Array.isArray(expected)) { | ||
| return toEqual.call(this, 'toHaveAccessibleName', locator, 'Locator', async (isNot, timeout) => { | ||
| const expectedText = serializeExpectedTextValues(expected, { matchSubstring: true, normalizeWhiteSpace: true, ignoreCase: options.ignoreCase }); |
There was a problem hiding this comment.
+1, let's only land the array aspect.
Update accessible name check in the matchers.ts References microsoft#32593
This comment has been minimized.
This comment has been minimized.
Changed type accessible name in the doc file References microsoft#32593
Test results for "tests 1"2 flaky36917 passed, 650 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
left a comment
There was a problem hiding this comment.
Looks great, thank you for the PR!
…of expected accessible names (microsoft#33277)" This reverts commit 7f054ef.
extend toHaveAccessibleName() to accept an array of expected accessible names and write the tests for the type
Closes#32593.