chore: pdf generation now works in headed mode too - #33879

Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom
yury-s:pdf-headed
Dec 6, 2024
Merged

chore: pdf generation now works in headed mode too#33879
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom
yury-s:pdf-headed

Conversation

@yury-s

@yury-sYury Semikhatsky (yury-s) commented Dec 5, 2024

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actionsBot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Test results for "tests others"

1 fatal errors, not part of any test
19292 passed, 452 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

github-actionsBot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 failed
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-22.04-node18
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-22.04-node18
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-22.04-node18
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-22.04-node18

1 flaky⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20

37196 passed, 646 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

github-actionsBot commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

69 failed
❌ [chromium-library] › library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-macos-latest
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-macos-latest
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-macos-latest
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-ubuntu-20.04
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-ubuntu-20.04
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-windows-latest
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-windows-latest
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-macos-14-xlarge
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-macos-14-xlarge
❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-ubuntu-24.04
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-ubuntu-24.04
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-windows-latest
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-windows-latest
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-large
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-large
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-xlarge
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-xlarge
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-large
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-large
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-xlarge
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-xlarge
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-20.04
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-20.04
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-24.04
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-24.04
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-windows-latest
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-windows-latest
❌ [chromium-library] › library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest
❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest
❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work Radoslav Kirilov (@smoke) @msedge-dev-ubuntu-20.04
❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-dev-ubuntu-20.04
❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-macos-latest
❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-firefox
❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-firefox
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-webkit
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-webkit
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-macos-14-xlarge
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-macos-14-xlarge
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-20.04
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-20.04
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-22.04
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-22.04
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-24.04
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-24.04
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-windows-latest
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-windows-latest
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-13-xlarge
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-13-xlarge
❌ [webkit-library] › library/trace-viewer.spec.ts:1576:1 › should show a popover @webkit-macos-13-xlarge
❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › launchServer › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge
❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › run-server › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-14-xlarge
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-14-xlarge
❌ [webkit-page] › page/page-set-input-files.spec.ts:767:3 › should preserve lastModified timestamp @webkit-macos-14-xlarge
❌ [webkit-library] › library/capabilities.spec.ts:94:3 › should play audio Radoslav Kirilov (@smoke) @webkit-macos-15-large
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-large
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-large
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-xlarge
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-xlarge
❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-20.04
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-20.04
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-24.04
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-24.04
❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-windows-latest
❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-windows-latest

98 flaky⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @channel-chromium-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @channel-chromium-windows-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chrome-beta-ubuntu-20.04
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-macos-latest
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @chrome-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-macos-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-windows-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-windows-latest
⚠️ [chromium-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @chromium-macos-14-large
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-tip-of-tree-windows-latest--headed
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-beta-macos-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-beta-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:305:3 › should emulate media in popup @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:198:5 › run-server › should be able to connect two browsers at the same time @firefox-headed-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:53:3 › should respect CSP Radoslav Kirilov (@smoke) @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:828:7 › cli codegen › should record slider @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-windows-latest
⚠️ [firefox-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @firefox-headed-windows-latest
⚠️ [firefox-library] › library/trace-viewer.spec.ts:752:1 › should preserve currentSrc @firefox-headed-windows-latest
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-24.04
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-windows-latest
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:161:5 › launchServer › should be able to visit ipv6 @msedge-dev-macos-latest
⚠️ [chromium-library] › library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-dev-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-dev-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work @msedge-dev-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-dev-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-dev-windows-latest
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-macos-latest
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @msedge-macos-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @tracing-webkit
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-page] › page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:560:7 › cli codegen › should check with keyboard @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:469:7 › cli codegen › should generate getByPlaceholder @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:541:7 › cli codegen › should check a radio button @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/trace-viewer.spec.ts:911:1 › should show action source @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:26:7 › cli codegen › should click locator.first @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:814:7 › cli codegen › should display inline svg icons on text assertion dialog inside iframe @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1114:1 › should open trace-1.31 @webkit-headed-windows-latest
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-headed-windows-latest
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-20.04
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @webkit-windows-latest

243337 passed, 9496 skipped
✔️✔️✔️

Merge workflow run.

@yury-s
Yury Semikhatsky (yury-s) merged commit 733f9a2 into microsoft:mainDec 6, 2024
This was referenced Dec 6, 2024
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@mxschmittMax Schmitt (mxschmitt)mxschmitt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s@mxschmitt
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore: pdf generation now works in headed mode too - #33879
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Dec 6, 2024
Merged
chore: pdf generation now works in headed mode too#33879
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
19292 passed, 452 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
4 failed

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-22.04-node18

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-22.04-node18
1 flaky⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20 
37196 passed, 646 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
69 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-windows-latest

❌ [chromium-library] › library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work Radoslav Kirilov (@smoke) @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-firefox

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-firefox

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-13-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-13-xlarge

❌ [webkit-library] › library/trace-viewer.spec.ts:1576:1 › should show a popover @webkit-macos-13-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › launchServer › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › run-server › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-14-xlarge

❌ [webkit-page] › page/page-set-input-files.spec.ts:767:3 › should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/capabilities.spec.ts:94:3 › should play audio Radoslav Kirilov (@smoke) @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-windows-latest
98 flaky⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chrome-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @chrome-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @chromium-macos-14-large 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-tip-of-tree-windows-latest--headed 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:305:3 › should emulate media in popup @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:198:5 › run-server › should be able to connect two browsers at the same time @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:53:3 › should respect CSP Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:828:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:752:1 › should preserve currentSrc @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:161:5 › launchServer › should be able to visit ipv6 @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:560:7 › cli codegen › should check with keyboard @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:469:7 › cli codegen › should generate getByPlaceholder @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:541:7 › cli codegen › should check a radio button @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:911:1 › should show action source @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:26:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:814:7 › cli codegen › should display inline svg icons on text assertion dialog inside iframe @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1114:1 › should open trace-1.31 @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-20.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @webkit-windows-latest 
243337 passed, 9496 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit 733f9a2
into
microsoft:mainDec 6, 2024

This was referenced Dec 6, 2024

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@mxschmittMax Schmitt (mxschmitt)mxschmitt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s@mxschmitt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: pdf generation now works in headed mode too - #33879
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Dec 6, 2024
Merged
chore: pdf generation now works in headed mode too#33879
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
19292 passed, 452 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
4 failed

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-22.04-node18

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-22.04-node18
1 flaky⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20 
37196 passed, 646 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
69 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-windows-latest

❌ [chromium-library] › library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work Radoslav Kirilov (@smoke) @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-firefox

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-firefox

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-13-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-13-xlarge

❌ [webkit-library] › library/trace-viewer.spec.ts:1576:1 › should show a popover @webkit-macos-13-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › launchServer › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › run-server › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-14-xlarge

❌ [webkit-page] › page/page-set-input-files.spec.ts:767:3 › should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/capabilities.spec.ts:94:3 › should play audio Radoslav Kirilov (@smoke) @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-windows-latest
98 flaky⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chrome-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @chrome-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @chromium-macos-14-large 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-tip-of-tree-windows-latest--headed 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:305:3 › should emulate media in popup @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:198:5 › run-server › should be able to connect two browsers at the same time @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:53:3 › should respect CSP Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:828:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:752:1 › should preserve currentSrc @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:161:5 › launchServer › should be able to visit ipv6 @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:560:7 › cli codegen › should check with keyboard @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:469:7 › cli codegen › should generate getByPlaceholder @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:541:7 › cli codegen › should check a radio button @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:911:1 › should show action source @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:26:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:814:7 › cli codegen › should display inline svg icons on text assertion dialog inside iframe @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1114:1 › should open trace-1.31 @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-20.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @webkit-windows-latest 
243337 passed, 9496 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit 733f9a2
into
microsoft:mainDec 6, 2024

This was referenced Dec 6, 2024

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@mxschmittMax Schmitt (mxschmitt)mxschmitt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s@mxschmitt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: pdf generation now works in headed mode too - #33879
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Dec 6, 2024
Merged
chore: pdf generation now works in headed mode too#33879
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
19292 passed, 452 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
4 failed

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-22.04-node18

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-22.04-node18
1 flaky⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20 
37196 passed, 646 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
69 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-windows-latest

❌ [chromium-library] › library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work Radoslav Kirilov (@smoke) @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-firefox

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-firefox

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-13-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-13-xlarge

❌ [webkit-library] › library/trace-viewer.spec.ts:1576:1 › should show a popover @webkit-macos-13-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › launchServer › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › run-server › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-14-xlarge

❌ [webkit-page] › page/page-set-input-files.spec.ts:767:3 › should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/capabilities.spec.ts:94:3 › should play audio Radoslav Kirilov (@smoke) @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-windows-latest
98 flaky⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chrome-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @chrome-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @chromium-macos-14-large 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-tip-of-tree-windows-latest--headed 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:305:3 › should emulate media in popup @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:198:5 › run-server › should be able to connect two browsers at the same time @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:53:3 › should respect CSP Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:828:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:752:1 › should preserve currentSrc @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:161:5 › launchServer › should be able to visit ipv6 @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:560:7 › cli codegen › should check with keyboard @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:469:7 › cli codegen › should generate getByPlaceholder @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:541:7 › cli codegen › should check a radio button @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:911:1 › should show action source @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:26:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:814:7 › cli codegen › should display inline svg icons on text assertion dialog inside iframe @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1114:1 › should open trace-1.31 @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-20.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @webkit-windows-latest 
243337 passed, 9496 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit 733f9a2
into
microsoft:mainDec 6, 2024

This was referenced Dec 6, 2024

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@mxschmittMax Schmitt (mxschmitt)mxschmitt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s@mxschmitt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore: pdf generation now works in headed mode too - #33879
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Dec 6, 2024
Merged
chore: pdf generation now works in headed mode too#33879
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
19292 passed, 452 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
4 failed

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-22.04-node18

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-22.04-node18
1 flaky⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20 
37196 passed, 646 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
69 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-windows-latest

❌ [chromium-library] › library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work Radoslav Kirilov (@smoke) @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-firefox

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-firefox

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-13-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-13-xlarge

❌ [webkit-library] › library/trace-viewer.spec.ts:1576:1 › should show a popover @webkit-macos-13-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › launchServer › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › run-server › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-14-xlarge

❌ [webkit-page] › page/page-set-input-files.spec.ts:767:3 › should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/capabilities.spec.ts:94:3 › should play audio Radoslav Kirilov (@smoke) @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-windows-latest
98 flaky⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chrome-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @chrome-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @chromium-macos-14-large 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-tip-of-tree-windows-latest--headed 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:305:3 › should emulate media in popup @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:198:5 › run-server › should be able to connect two browsers at the same time @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:53:3 › should respect CSP Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:828:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:752:1 › should preserve currentSrc @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:161:5 › launchServer › should be able to visit ipv6 @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:560:7 › cli codegen › should check with keyboard @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:469:7 › cli codegen › should generate getByPlaceholder @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:541:7 › cli codegen › should check a radio button @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:911:1 › should show action source @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:26:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:814:7 › cli codegen › should display inline svg icons on text assertion dialog inside iframe @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1114:1 › should open trace-1.31 @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-20.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @webkit-windows-latest 
243337 passed, 9496 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit 733f9a2
into
microsoft:mainDec 6, 2024

This was referenced Dec 6, 2024

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@mxschmittMax Schmitt (mxschmitt)mxschmitt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s@mxschmitt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: pdf generation now works in headed mode too - #33879
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Dec 6, 2024
Merged
chore: pdf generation now works in headed mode too#33879
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
19292 passed, 452 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
4 failed

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-22.04-node18

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-22.04-node18
1 flaky⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20 
37196 passed, 646 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
69 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-windows-latest

❌ [chromium-library] › library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work Radoslav Kirilov (@smoke) @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-firefox

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-firefox

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-13-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-13-xlarge

❌ [webkit-library] › library/trace-viewer.spec.ts:1576:1 › should show a popover @webkit-macos-13-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › launchServer › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › run-server › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-14-xlarge

❌ [webkit-page] › page/page-set-input-files.spec.ts:767:3 › should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/capabilities.spec.ts:94:3 › should play audio Radoslav Kirilov (@smoke) @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-windows-latest
98 flaky⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chrome-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @chrome-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @chromium-macos-14-large 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-tip-of-tree-windows-latest--headed 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:305:3 › should emulate media in popup @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:198:5 › run-server › should be able to connect two browsers at the same time @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:53:3 › should respect CSP Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:828:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:752:1 › should preserve currentSrc @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:161:5 › launchServer › should be able to visit ipv6 @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:560:7 › cli codegen › should check with keyboard @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:469:7 › cli codegen › should generate getByPlaceholder @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:541:7 › cli codegen › should check a radio button @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:911:1 › should show action source @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:26:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:814:7 › cli codegen › should display inline svg icons on text assertion dialog inside iframe @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1114:1 › should open trace-1.31 @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-20.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @webkit-windows-latest 
243337 passed, 9496 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit 733f9a2
into
microsoft:mainDec 6, 2024

This was referenced Dec 6, 2024

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@mxschmittMax Schmitt (mxschmitt)mxschmitt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s@mxschmitt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore: pdf generation now works in headed mode too - #33879
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Dec 6, 2024
Merged
chore: pdf generation now works in headed mode too#33879
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
19292 passed, 452 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
4 failed

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-22.04-node18

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-22.04-node18
1 flaky⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20 
37196 passed, 646 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
69 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-windows-latest

❌ [chromium-library] › library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work Radoslav Kirilov (@smoke) @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-firefox

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-firefox

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-13-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-13-xlarge

❌ [webkit-library] › library/trace-viewer.spec.ts:1576:1 › should show a popover @webkit-macos-13-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › launchServer › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › run-server › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-14-xlarge

❌ [webkit-page] › page/page-set-input-files.spec.ts:767:3 › should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/capabilities.spec.ts:94:3 › should play audio Radoslav Kirilov (@smoke) @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-windows-latest
98 flaky⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chrome-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @chrome-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @chromium-macos-14-large 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-tip-of-tree-windows-latest--headed 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:305:3 › should emulate media in popup @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:198:5 › run-server › should be able to connect two browsers at the same time @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:53:3 › should respect CSP Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:828:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:752:1 › should preserve currentSrc @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:161:5 › launchServer › should be able to visit ipv6 @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:560:7 › cli codegen › should check with keyboard @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:469:7 › cli codegen › should generate getByPlaceholder @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:541:7 › cli codegen › should check a radio button @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:911:1 › should show action source @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:26:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:814:7 › cli codegen › should display inline svg icons on text assertion dialog inside iframe @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1114:1 › should open trace-1.31 @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-20.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @webkit-windows-latest 
243337 passed, 9496 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit 733f9a2
into
microsoft:mainDec 6, 2024

This was referenced Dec 6, 2024

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@mxschmittMax Schmitt (mxschmitt)mxschmitt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s@mxschmitt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore: pdf generation now works in headed mode too - #33879
Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Dec 6, 2024
Merged
chore: pdf generation now works in headed mode too#33879
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom 
yury-s:pdf-headed
Conversation
@yury-s
@yury-sYury Semikhatsky (yury-s)
commented
Dec 5, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 fatal errors, not part of any test
19292 passed, 452 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
4 failed

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-22.04-node18

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-22.04-node18

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-22.04-node18
1 flaky⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20 
37196 passed, 646 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Dec 5, 2024

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
69 failed

❌ [chromium-library] › library/browsertype-connect.spec.ts:436:5 › run-server › should respect selectors @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest

❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @chrome-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-beta-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-headed-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-13-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-large

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-macos-14-xlarge

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-20.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-ubuntu-24.04

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @firefox-windows-latest

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @firefox-windows-latest

❌ [chromium-library] › library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest

❌ [chromium-library] › library/downloads-path.spec.ts:105:5 › downloads path › should delete downloads when persistent context closes @msedge-dev-macos-latest

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work Radoslav Kirilov (@smoke) @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:42:3 › context.addCookies() should work @msedge-dev-ubuntu-20.04

❌ [chromium-library] › library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @msedge-macos-latest

❌ [firefox-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-firefox

❌ [firefox-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-firefox

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @tracing-webkit

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-22.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-headed-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-13-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-13-xlarge

❌ [webkit-library] › library/trace-viewer.spec.ts:1576:1 › should show a popover @webkit-macos-13-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › launchServer › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/browsertype-connect.spec.ts:735:5 › run-server › setInputFiles should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-14-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-14-xlarge

❌ [webkit-page] › page/page-set-input-files.spec.ts:767:3 › should preserve lastModified timestamp @webkit-macos-14-xlarge

❌ [webkit-library] › library/capabilities.spec.ts:94:3 › should play audio Radoslav Kirilov (@smoke) @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-large

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-macos-15-xlarge

❌ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-20.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-ubuntu-24.04

❌ [webkit-library] › library/pdf.spec.ts:20:3 › should be able to save file @webkit-windows-latest

❌ [webkit-library] › library/pdf.spec.ts:28:3 › should be able to generate outline @webkit-windows-latest
98 flaky⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @channel-chromium-windows-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chrome-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:481:5 › run-server › should not throw on close after disconnect @chrome-macos-latest 
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @chrome-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-macos-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @chrome-windows-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-windows-latest 
⚠️ [chromium-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @chromium-macos-14-large 
⚠️ [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @chromium-tip-of-tree-windows-latest--headed 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-beta-macos-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-beta-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-page] › page/page-add-locator-handler.spec.ts:230:5 › should work when owner frame detaches @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:305:3 › should emulate media in popup @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:198:5 › run-server › should be able to connect two browsers at the same time @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/capabilities.spec.ts:53:3 › should respect CSP Radoslav Kirilov (@smoke) @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:828:7 › cli codegen › should record slider @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/trace-viewer.spec.ts:752:1 › should preserve currentSrc @firefox-headed-windows-latest 
⚠️ [firefox-library] › library/tracing.spec.ts:312:5 › should overwrite existing file @firefox-headed-windows-latest 
⚠️ [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-24.04 
⚠️ [firefox-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @firefox-windows-latest 
⚠️ [chromium-library] › library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-beta-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:161:5 › launchServer › should be able to visit ipv6 @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @msedge-dev-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:64:3 › context.clearCookies() should work @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-dev-windows-latest 
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work @msedge-macos-latest 
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-macos-latest 
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @msedge-macos-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @tracing-webkit 
⚠️ [webkit-library] › library/screenshot.spec.ts:219:14 › element screenshot › element screenshot should work with device scale factor @tracing-webkit 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-page] › page/wheel.spec.ts:70:3 › should dispatch wheel events after context menu was opened @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:560:7 › cli codegen › should check with keyboard @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:469:7 › cli codegen › should generate getByPlaceholder @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:541:7 › cli codegen › should check a radio button @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:911:1 › should show action source @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:26:7 › cli codegen › should click locator.first @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:814:7 › cli codegen › should display inline svg icons on text assertion dialog inside iframe @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1114:1 › should open trace-1.31 @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @webkit-headed-windows-latest 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames fit @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-page] › page/page-request-continue.spec.ts:185:5 › post data › should amend post data @webkit-macos-14-xlarge 
⚠️ [webkit-library] › library/browsercontext-fetch.spec.ts:772:3 › should support brotli compression @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › library/screenshot.spec.ts:206:14 › element screenshot › element screenshot should work with a mobile viewport @webkit-ubuntu-20.04 
⚠️ [webkit-library] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @webkit-windows-latest 
243337 passed, 9496 skipped

✔️✔️✔️
Merge workflow run.
@yury-s
Yury Semikhatsky (yury-s)
merged commit 733f9a2
into
microsoft:mainDec 6, 2024

This was referenced Dec 6, 2024

Closed


Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@mxschmittMax Schmitt (mxschmitt)mxschmitt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@yury-s@mxschmitt