feat: expect(locator).toHaveAccessibleErrorMessage by pengooseDev · Pull Request #33904 · microsoft/playwright

Pengoose (pengooseDev) · 2024-12-07T12:54:35Z

Closes#31249

Add new toHaveAccessibleErrorMessage matcher for expect(locator).

Looking forward to teams feedback. Thanks! :)

Dmitry Gozman (dgozman)

This looks very good! Just a few comments about aria spec/semantics, and this will be good to do.

Dmitry Gozman (dgozman)

Thank you for the PR, looks very good!

Dmitry Gozman (dgozman) · 2024-12-17T10:39:04Z

+export const kInputValidityAttributes = ['required', 'pattern', 'min', 'max', 'minlength', 'maxlength', 'step', 'type', 'value'];
+
+export function hasValidationAttributes(element: Element): boolean {
+ if (!(element instanceof HTMLInputElement))


validity is defined for a lot of elements, e.g. <select>, <textarea>, <object>, <button>, <fieldset>, probably more. I'd drop this check, and assume that element.validity?.valid === false means it is invalid.

Dmitry Gozman (dgozman) · 2024-12-17T10:39:30Z

+ const role = getAriaRole(element) || '';
+ if (!role || !kAriaInvalidRoles.includes(role))
+ return 'false';
+ if (element instanceof HTMLInputElement && hasValidationAttributes(element) && element.validity)


Perhaps check both aria-invalid and element.validity?.valid === false, and consider the element invalid when either of the indicators is present?

I understood it as being asked to remove hasValidationAttributes and evaluate only with element.validity?.valid === false without assessing the kAriaInvalidRoles attributes. Would that be correct? :)
According to the spec, it seems that the return values of the getAriaInvalid function should be 'false' | 'true' | 'grammar' | 'spelling'.
Rather than evaluating validity within this function, I think it would be better to separate it into a dedicated function, such as getValidityInvalid. I look forward to your feedback on this! :)

…essage references

…plementation

github-actions · 2024-12-22T14:21:41Z

Test results for "tests 1"

8 flaky

⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-har.spec.ts:529:3 › should ignore aborted requests @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/logger.spec.ts:34:3 › should log context-level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37461 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Dmitry Gozman (dgozman)

This looks great! Thank you for the PR! and following through the review process. Merging in.

Pengoose (pengooseDev) · 2024-12-07T12:54:35Z

Closes#31249

Add new toHaveAccessibleErrorMessage matcher for expect(locator).

Looking forward to teams feedback. Thanks! :)

Dmitry Gozman (dgozman)

This looks very good! Just a few comments about aria spec/semantics, and this will be good to do.

Dmitry Gozman (dgozman)

Thank you for the PR, looks very good!

Dmitry Gozman (dgozman) · 2024-12-17T10:39:04Z

+export const kInputValidityAttributes = ['required', 'pattern', 'min', 'max', 'minlength', 'maxlength', 'step', 'type', 'value'];
+
+export function hasValidationAttributes(element: Element): boolean {
+ if (!(element instanceof HTMLInputElement))


validity is defined for a lot of elements, e.g. <select>, <textarea>, <object>, <button>, <fieldset>, probably more. I'd drop this check, and assume that element.validity?.valid === false means it is invalid.

Dmitry Gozman (dgozman) · 2024-12-17T10:39:30Z

+ const role = getAriaRole(element) || '';
+ if (!role || !kAriaInvalidRoles.includes(role))
+ return 'false';
+ if (element instanceof HTMLInputElement && hasValidationAttributes(element) && element.validity)


Perhaps check both aria-invalid and element.validity?.valid === false, and consider the element invalid when either of the indicators is present?

I understood it as being asked to remove hasValidationAttributes and evaluate only with element.validity?.valid === false without assessing the kAriaInvalidRoles attributes. Would that be correct? :)
According to the spec, it seems that the return values of the getAriaInvalid function should be 'false' | 'true' | 'grammar' | 'spelling'.
Rather than evaluating validity within this function, I think it would be better to separate it into a dedicated function, such as getValidityInvalid. I look forward to your feedback on this! :)

…essage references

…plementation

github-actions · 2024-12-22T14:21:41Z

Test results for "tests 1"

8 flaky

⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-har.spec.ts:529:3 › should ignore aborted requests @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/logger.spec.ts:34:3 › should log context-level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37461 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Dmitry Gozman (dgozman)

This looks great! Thank you for the PR! and following through the review process. Merging in.

Pengoose (pengooseDev) · 2024-12-07T12:54:35Z

Closes#31249

Add new toHaveAccessibleErrorMessage matcher for expect(locator).

Looking forward to teams feedback. Thanks! :)

Dmitry Gozman (dgozman)

This looks very good! Just a few comments about aria spec/semantics, and this will be good to do.

Dmitry Gozman (dgozman)

Thank you for the PR, looks very good!

Dmitry Gozman (dgozman) · 2024-12-17T10:39:04Z

+export const kInputValidityAttributes = ['required', 'pattern', 'min', 'max', 'minlength', 'maxlength', 'step', 'type', 'value'];
+
+export function hasValidationAttributes(element: Element): boolean {
+ if (!(element instanceof HTMLInputElement))


validity is defined for a lot of elements, e.g. <select>, <textarea>, <object>, <button>, <fieldset>, probably more. I'd drop this check, and assume that element.validity?.valid === false means it is invalid.

Dmitry Gozman (dgozman) · 2024-12-17T10:39:30Z

+ const role = getAriaRole(element) || '';
+ if (!role || !kAriaInvalidRoles.includes(role))
+ return 'false';
+ if (element instanceof HTMLInputElement && hasValidationAttributes(element) && element.validity)


Perhaps check both aria-invalid and element.validity?.valid === false, and consider the element invalid when either of the indicators is present?

I understood it as being asked to remove hasValidationAttributes and evaluate only with element.validity?.valid === false without assessing the kAriaInvalidRoles attributes. Would that be correct? :)
According to the spec, it seems that the return values of the getAriaInvalid function should be 'false' | 'true' | 'grammar' | 'spelling'.
Rather than evaluating validity within this function, I think it would be better to separate it into a dedicated function, such as getValidityInvalid. I look forward to your feedback on this! :)

…essage references

…plementation

github-actions · 2024-12-22T14:21:41Z

Test results for "tests 1"

8 flaky

⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-har.spec.ts:529:3 › should ignore aborted requests @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/logger.spec.ts:34:3 › should log context-level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37461 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Dmitry Gozman (dgozman)

This looks great! Thank you for the PR! and following through the review process. Merging in.

Pengoose (pengooseDev) · 2024-12-07T12:54:35Z

Closes#31249

Add new toHaveAccessibleErrorMessage matcher for expect(locator).

Looking forward to teams feedback. Thanks! :)

Dmitry Gozman (dgozman)

This looks very good! Just a few comments about aria spec/semantics, and this will be good to do.

Dmitry Gozman (dgozman)

Thank you for the PR, looks very good!

Dmitry Gozman (dgozman) · 2024-12-17T10:39:04Z

+export const kInputValidityAttributes = ['required', 'pattern', 'min', 'max', 'minlength', 'maxlength', 'step', 'type', 'value'];
+
+export function hasValidationAttributes(element: Element): boolean {
+ if (!(element instanceof HTMLInputElement))


validity is defined for a lot of elements, e.g. <select>, <textarea>, <object>, <button>, <fieldset>, probably more. I'd drop this check, and assume that element.validity?.valid === false means it is invalid.

Dmitry Gozman (dgozman) · 2024-12-17T10:39:30Z

+ const role = getAriaRole(element) || '';
+ if (!role || !kAriaInvalidRoles.includes(role))
+ return 'false';
+ if (element instanceof HTMLInputElement && hasValidationAttributes(element) && element.validity)


Perhaps check both aria-invalid and element.validity?.valid === false, and consider the element invalid when either of the indicators is present?

I understood it as being asked to remove hasValidationAttributes and evaluate only with element.validity?.valid === false without assessing the kAriaInvalidRoles attributes. Would that be correct? :)
According to the spec, it seems that the return values of the getAriaInvalid function should be 'false' | 'true' | 'grammar' | 'spelling'.
Rather than evaluating validity within this function, I think it would be better to separate it into a dedicated function, such as getValidityInvalid. I look forward to your feedback on this! :)

…essage references

…plementation

github-actions · 2024-12-22T14:21:41Z

Test results for "tests 1"

8 flaky

⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-har.spec.ts:529:3 › should ignore aborted requests @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/logger.spec.ts:34:3 › should log context-level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37461 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Dmitry Gozman (dgozman)

This looks great! Thank you for the PR! and following through the review process. Merging in.

Pengoose (pengooseDev) · 2024-12-07T12:54:35Z

Closes#31249

Add new toHaveAccessibleErrorMessage matcher for expect(locator).

Looking forward to teams feedback. Thanks! :)

Dmitry Gozman (dgozman)

This looks very good! Just a few comments about aria spec/semantics, and this will be good to do.

Dmitry Gozman (dgozman)

Thank you for the PR, looks very good!

Dmitry Gozman (dgozman) · 2024-12-17T10:39:04Z

+export const kInputValidityAttributes = ['required', 'pattern', 'min', 'max', 'minlength', 'maxlength', 'step', 'type', 'value'];
+
+export function hasValidationAttributes(element: Element): boolean {
+ if (!(element instanceof HTMLInputElement))


validity is defined for a lot of elements, e.g. <select>, <textarea>, <object>, <button>, <fieldset>, probably more. I'd drop this check, and assume that element.validity?.valid === false means it is invalid.

Dmitry Gozman (dgozman) · 2024-12-17T10:39:30Z

+ const role = getAriaRole(element) || '';
+ if (!role || !kAriaInvalidRoles.includes(role))
+ return 'false';
+ if (element instanceof HTMLInputElement && hasValidationAttributes(element) && element.validity)


Perhaps check both aria-invalid and element.validity?.valid === false, and consider the element invalid when either of the indicators is present?

I understood it as being asked to remove hasValidationAttributes and evaluate only with element.validity?.valid === false without assessing the kAriaInvalidRoles attributes. Would that be correct? :)
According to the spec, it seems that the return values of the getAriaInvalid function should be 'false' | 'true' | 'grammar' | 'spelling'.
Rather than evaluating validity within this function, I think it would be better to separate it into a dedicated function, such as getValidityInvalid. I look forward to your feedback on this! :)

…essage references

…plementation

github-actions · 2024-12-22T14:21:41Z

Test results for "tests 1"

8 flaky

⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-har.spec.ts:529:3 › should ignore aborted requests @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/logger.spec.ts:34:3 › should log context-level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37461 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Dmitry Gozman (dgozman)

This looks great! Thank you for the PR! and following through the review process. Merging in.

Pengoose (pengooseDev) · 2024-12-07T12:54:35Z

Closes#31249

Add new toHaveAccessibleErrorMessage matcher for expect(locator).

Looking forward to teams feedback. Thanks! :)

Dmitry Gozman (dgozman)

This looks very good! Just a few comments about aria spec/semantics, and this will be good to do.

Dmitry Gozman (dgozman)

Thank you for the PR, looks very good!

Dmitry Gozman (dgozman) · 2024-12-17T10:39:04Z

+export const kInputValidityAttributes = ['required', 'pattern', 'min', 'max', 'minlength', 'maxlength', 'step', 'type', 'value'];
+
+export function hasValidationAttributes(element: Element): boolean {
+ if (!(element instanceof HTMLInputElement))


validity is defined for a lot of elements, e.g. <select>, <textarea>, <object>, <button>, <fieldset>, probably more. I'd drop this check, and assume that element.validity?.valid === false means it is invalid.

Dmitry Gozman (dgozman) · 2024-12-17T10:39:30Z

+ const role = getAriaRole(element) || '';
+ if (!role || !kAriaInvalidRoles.includes(role))
+ return 'false';
+ if (element instanceof HTMLInputElement && hasValidationAttributes(element) && element.validity)


Perhaps check both aria-invalid and element.validity?.valid === false, and consider the element invalid when either of the indicators is present?

I understood it as being asked to remove hasValidationAttributes and evaluate only with element.validity?.valid === false without assessing the kAriaInvalidRoles attributes. Would that be correct? :)
According to the spec, it seems that the return values of the getAriaInvalid function should be 'false' | 'true' | 'grammar' | 'spelling'.
Rather than evaluating validity within this function, I think it would be better to separate it into a dedicated function, such as getValidityInvalid. I look forward to your feedback on this! :)

…essage references

…plementation

github-actions · 2024-12-22T14:21:41Z

Test results for "tests 1"

8 flaky

⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-har.spec.ts:529:3 › should ignore aborted requests @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/logger.spec.ts:34:3 › should log context-level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37461 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Dmitry Gozman (dgozman)

This looks great! Thank you for the PR! and following through the review process. Merging in.

Pengoose (pengooseDev) · 2024-12-07T12:54:35Z

Closes#31249

Add new toHaveAccessibleErrorMessage matcher for expect(locator).

Looking forward to teams feedback. Thanks! :)

Dmitry Gozman (dgozman)

This looks very good! Just a few comments about aria spec/semantics, and this will be good to do.

Dmitry Gozman (dgozman)

Thank you for the PR, looks very good!

Dmitry Gozman (dgozman) · 2024-12-17T10:39:04Z

+export const kInputValidityAttributes = ['required', 'pattern', 'min', 'max', 'minlength', 'maxlength', 'step', 'type', 'value'];
+
+export function hasValidationAttributes(element: Element): boolean {
+ if (!(element instanceof HTMLInputElement))


validity is defined for a lot of elements, e.g. <select>, <textarea>, <object>, <button>, <fieldset>, probably more. I'd drop this check, and assume that element.validity?.valid === false means it is invalid.

Dmitry Gozman (dgozman) · 2024-12-17T10:39:30Z

+ const role = getAriaRole(element) || '';
+ if (!role || !kAriaInvalidRoles.includes(role))
+ return 'false';
+ if (element instanceof HTMLInputElement && hasValidationAttributes(element) && element.validity)


Perhaps check both aria-invalid and element.validity?.valid === false, and consider the element invalid when either of the indicators is present?

I understood it as being asked to remove hasValidationAttributes and evaluate only with element.validity?.valid === false without assessing the kAriaInvalidRoles attributes. Would that be correct? :)
According to the spec, it seems that the return values of the getAriaInvalid function should be 'false' | 'true' | 'grammar' | 'spelling'.
Rather than evaluating validity within this function, I think it would be better to separate it into a dedicated function, such as getValidityInvalid. I look forward to your feedback on this! :)

…essage references

…plementation

github-actions · 2024-12-22T14:21:41Z

Test results for "tests 1"

8 flaky

⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-har.spec.ts:529:3 › should ignore aborted requests @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/logger.spec.ts:34:3 › should log context-level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37461 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Dmitry Gozman (dgozman)

This looks great! Thank you for the PR! and following through the review process. Merging in.

Pengoose (pengooseDev) · 2024-12-07T12:54:35Z

Closes#31249

Add new toHaveAccessibleErrorMessage matcher for expect(locator).

Looking forward to teams feedback. Thanks! :)

Dmitry Gozman (dgozman)

This looks very good! Just a few comments about aria spec/semantics, and this will be good to do.

Dmitry Gozman (dgozman)

Thank you for the PR, looks very good!

Dmitry Gozman (dgozman) · 2024-12-17T10:39:04Z

+export const kInputValidityAttributes = ['required', 'pattern', 'min', 'max', 'minlength', 'maxlength', 'step', 'type', 'value'];
+
+export function hasValidationAttributes(element: Element): boolean {
+ if (!(element instanceof HTMLInputElement))


validity is defined for a lot of elements, e.g. <select>, <textarea>, <object>, <button>, <fieldset>, probably more. I'd drop this check, and assume that element.validity?.valid === false means it is invalid.

Dmitry Gozman (dgozman) · 2024-12-17T10:39:30Z

+ const role = getAriaRole(element) || '';
+ if (!role || !kAriaInvalidRoles.includes(role))
+ return 'false';
+ if (element instanceof HTMLInputElement && hasValidationAttributes(element) && element.validity)


Perhaps check both aria-invalid and element.validity?.valid === false, and consider the element invalid when either of the indicators is present?

I understood it as being asked to remove hasValidationAttributes and evaluate only with element.validity?.valid === false without assessing the kAriaInvalidRoles attributes. Would that be correct? :)
According to the spec, it seems that the return values of the getAriaInvalid function should be 'false' | 'true' | 'grammar' | 'spelling'.
Rather than evaluating validity within this function, I think it would be better to separate it into a dedicated function, such as getValidityInvalid. I look forward to your feedback on this! :)

…essage references

…plementation

github-actions · 2024-12-22T14:21:41Z

Test results for "tests 1"

8 flaky

⚠️ [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:184:5 › should watch new file @ubuntu-latest-node20-1
⚠️ [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-har.spec.ts:529:3 › should ignore aborted requests @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/logger.spec.ts:34:3 › should log context-level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:149:1 › should open simple trace viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37461 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Dmitry Gozman (dgozman)

This looks great! Thank you for the PR! and following through the review process. Merging in.

This comment has been minimized.
Sign in to view

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch 2 times, most recently from e68009a to cccdd97Compare December 7, 2024 16:10

This comment has been minimized.
Sign in to view

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch from cccdd97 to 6623a77Compare December 7, 2024 16:12

This comment has been minimized.
Sign in to view

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch from 95d0978 to 0a4ee89Compare December 8, 2024 03:28

This comment has been minimized.
Sign in to view

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch from 0a4ee89 to c963a6dCompare December 10, 2024 04:46

This comment has been minimized.
Sign in to view

Yury Semikhatsky (yury-s) reviewed Dec 10, 2024
View reviewed changes

Comment threadpackages/playwright-core/src/server/injected/roleUtils.ts
Comment threadpackages/playwright-core/src/server/injected/roleUtils.ts Outdated
Comment threadpackages/playwright-core/src/server/injected/roleUtils.ts Outdated

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch from c963a6d to 2195194Compare December 11, 2024 01:51

This comment has been minimized.
Sign in to view

Pengoose (pengooseDev) marked this pull request as draft December 11, 2024 03:56

Dmitry Gozman (dgozman) reviewed Dec 13, 2024
View reviewed changes

Comment threadpackages/playwright-core/src/server/injected/roleUtils.ts Outdated
Comment threadpackages/playwright-core/src/server/injected/roleUtils.ts Outdated

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch 2 times, most recently from f764780 to 139b5ddCompare December 14, 2024 16:11

This comment has been minimized.
Sign in to view

Pengoose (pengooseDev) marked this pull request as ready for review December 14, 2024 17:01

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Dec 16, 2024
View reviewed changes

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch 2 times, most recently from 3c01c81 to 41921edCompare December 16, 2024 20:40

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Dec 17, 2024
View reviewed changes

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch from 41921ed to 9378431Compare December 18, 2024 01:43

This comment has been minimized.
Sign in to view

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch from 9378431 to b28ad83Compare December 20, 2024 05:07

This comment has been minimized.
Sign in to view

Pengoose (pengooseDev) added 20 commits December 22, 2024 22:38

test: add regression tests
37e155a

feat: add toHaveAccessibleErrorMessage
b3e3545

docs: add toHaveAccessibleErrorMessage API
1106e34

test: restore deleted test cases
1c6abfe

docs: edit aria errormessage link ref link
3d512aa

chore: add caches in beginAriaCaches and endAriaCaches
57407b4

chore: align aria-invalid check with W3C specs
af391f3

test: add aria-invalid regressioin tests
1b6b126

chore: remove includeHidden props with getElementAccessibleErrorMessage
e49de50

test: add regression test(multiple aria-errormessage references)
b142f31

feat: toHaveAccessibleErrorMessage should handle multiple aria-errorm…
5a38627
…essage references

chore: support normalizeWhiteSpace in toHaveAccessibleErrorMessage
4a20769

chore: add spec link and TODO for getElementAccessibleErrorMessage im…
a2b8124
…plementation

chore: remove redundant check in getElementAccessibleErrorMessage
00b41eb

test: add regression tests(aria-invalid & input validity)
0eb406b

feat: add getAriaInvalid helper to handle aria-invalid and validity
bc03ba5

test: add regression tests(ignore InputElement.validity when irrelevant)
9342715

feat: ignore InputElement.validity when irrelevant
4298372

feat: adjust validity evaluation logic
6e7aebe

test: update regression tests to align with logic changes
cab504b

Pengoose (pengooseDev)force-pushed the feat-toHaveAccessibleErrorMessage branch from b28ad83 to cab504bCompare December 22, 2024 13:38

Dmitry Gozman (dgozman) approved these changes Dec 27, 2024
View reviewed changes

Dmitry Gozman (dgozman) merged commit 7f141b2 into microsoft:mainDec 27, 2024

This was referenced Dec 27, 2024
[Ports]: Backport client side changes for 1.50 microsoft/playwright-python#2653
Closed
[Ports]: Backport client side changes for 1.50 microsoft/playwright-java#1696
Closed
[Ports]: Backport client side changes for 1.50 microsoft/playwright-dotnet#3049
Closed