feat: Enable snapshots for most remaining public commands - #34072

Merged
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom
agg23:more-snapshot-commands
Jan 10, 2025
Merged

feat: Enable snapshots for most remaining public commands#34072
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom
agg23:more-snapshot-commands

Conversation

@agg23

@agg23Adam Gastineau (agg23) commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

Enable capturing snapshots on commands that have any visual component or interaction with the DOM. This is an interim solution to #33934. In the future we will display stale snapshots on trace entries that do not contain a snapshot.

@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman) approved these changes Dec 18, 2024
View reviewed changes

@pavelfeldmanPavel Feldman (pavelfeldman) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure you fix those tests before landing/

@pavelfeldman

Pavel Feldman (pavelfeldman) commented Dec 18, 2024

Copy link
Copy Markdown
Member

As this closes the issue for count(), having a test that checks that count() has gotten a snapshot would be nice as well.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests others"

1 flaky⚠️ [electron-api] › tests/electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself @electron-macos-latest

21465 passed, 503 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

github-actionsBot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

9 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:487:3 › should update extracted har.zip for page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:98:3 › should restore state from userDataDir @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:199:1 › should render console @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1385:1 › should show similar actions from library-only trace @webkit-ubuntu-22.04-node18

37548 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

8 failed
❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:424:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest
❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest
❌ [chromium-library] › tests/library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @msedge-beta-macos-latest
❌ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest
❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-large
❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-xlarge

110 flaky⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @channel-chromium-windows-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-beta-macos-latest
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chrome-macos-latest
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1017:1 › should open two trace files of the same test @chrome-windows-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:536:5 › selector generator › should generate relative selector @chromium-headed-windows-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chromium-tip-of-tree-ubuntu-20.04
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @chromium-tip-of-tree-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-request-continue.spec.ts:291:3 › should work with Cross-Origin-Opener-Policy @firefox-beta-ubuntu-20.04
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @firefox-beta-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:324:3 › should be able to send third party cookies via an iframe @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/browsercontext-har.spec.ts:244:3 › should round-trip har.zip @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest
⚠️ [firefox-library] › tests/library/video.spec.ts:287:5 › screencast › should delete video @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @firefox-macos-13-xlarge
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-14-xlarge
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:79:5 › launchServer › should connect over wss @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:48:5 › downloads path › should delete downloads when context closes @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:215:3 › should throw for socks5 authentication @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-beta-windows-latest
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @msedge-macos-latest
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-macos-latest
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-macos-latest
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-macos-latest
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @msedge-windows-latest
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-headed-macos-14-xlarge
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-headed-ubuntu-20.04
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-headed-ubuntu-20.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-ubuntu-22.04
⚠️ [webkit-page] › tests/page/elementhandle-misc.spec.ts:20:3 › should hover @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @webkit-macos-13-large
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge
⚠️ [webkit-page] › tests/page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1534:1 › canvas clipping @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:241:5 › post data › should amend longer post data @webkit-macos-15-xlarge
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-20.04

265331 passed, 10082 skipped
✔️✔️✔️

Merge workflow run.

@agg23
Adam Gastineau (agg23) merged commit a2e2dfd into microsoft:mainJan 10, 2025
This was referenced Jan 10, 2025
Closed
Closed
Closed
@agg23Adam Gastineau (agg23) mentioned this pull request Jan 10, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees

No one assigned

Labels

CQ1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agg23@pavelfeldman
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: Enable snapshots for most remaining public commands - #34072
Merged
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Jan 10, 2025
Merged
feat: Enable snapshots for most remaining public commands#34072
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Conversation
@agg23
@agg23Adam Gastineau (agg23)
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
Enable capturing snapshots on commands that have any visual component or interaction with the DOM. This is an interim solution to #33934. In the future we will display stale snapshots on trace entries that do not contain a snapshot.
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
approved these changes
Dec 18, 2024
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure you fix those tests before landing/
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
Dec 18, 2024

Copy link


Copy Markdown

Member
As this closes the issue for count(), having a test that checks that count() has gotten a snapshot would be nice as well.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 flaky⚠️ [electron-api] › tests/electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself @electron-macos-latest 
21465 passed, 503 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
9 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:487:3 › should update extracted har.zip for page @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:98:3 › should restore state from userDataDir @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:199:1 › should render console @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1385:1 › should show similar actions from library-only trace @webkit-ubuntu-22.04-node18 
37548 passed, 648 skipped

✔️✔️✔️
Merge workflow run.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
8 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:424:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-large

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-xlarge
110 flaky⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @channel-chromium-windows-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1017:1 › should open two trace files of the same test @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:536:5 › selector generator › should generate relative selector @chromium-headed-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chromium-tip-of-tree-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @chromium-tip-of-tree-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-request-continue.spec.ts:291:3 › should work with Cross-Origin-Opener-Policy @firefox-beta-ubuntu-20.04 
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @firefox-beta-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:324:3 › should be able to send third party cookies via an iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-har.spec.ts:244:3 › should round-trip har.zip @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:287:5 › screencast › should delete video @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @firefox-macos-13-xlarge 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:79:5 › launchServer › should connect over wss @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:48:5 › downloads path › should delete downloads when context closes @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:215:3 › should throw for socks5 authentication @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › tests/page/elementhandle-misc.spec.ts:20:3 › should hover @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @webkit-macos-13-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › tests/page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1534:1 › canvas clipping @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:241:5 › post data › should amend longer post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-20.04 
265331 passed, 10082 skipped

✔️✔️✔️
Merge workflow run.
@agg23
Adam Gastineau (agg23)
merged commit a2e2dfd
into
microsoft:mainJan 10, 2025

This was referenced Jan 10, 2025

Closed


Closed


Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jan 10, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@agg23@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Enable snapshots for most remaining public commands - #34072
Merged
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Jan 10, 2025
Merged
feat: Enable snapshots for most remaining public commands#34072
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Conversation
@agg23
@agg23Adam Gastineau (agg23)
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
Enable capturing snapshots on commands that have any visual component or interaction with the DOM. This is an interim solution to #33934. In the future we will display stale snapshots on trace entries that do not contain a snapshot.
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
approved these changes
Dec 18, 2024
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure you fix those tests before landing/
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
Dec 18, 2024

Copy link


Copy Markdown

Member
As this closes the issue for count(), having a test that checks that count() has gotten a snapshot would be nice as well.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 flaky⚠️ [electron-api] › tests/electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself @electron-macos-latest 
21465 passed, 503 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
9 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:487:3 › should update extracted har.zip for page @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:98:3 › should restore state from userDataDir @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:199:1 › should render console @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1385:1 › should show similar actions from library-only trace @webkit-ubuntu-22.04-node18 
37548 passed, 648 skipped

✔️✔️✔️
Merge workflow run.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
8 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:424:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-large

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-xlarge
110 flaky⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @channel-chromium-windows-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1017:1 › should open two trace files of the same test @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:536:5 › selector generator › should generate relative selector @chromium-headed-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chromium-tip-of-tree-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @chromium-tip-of-tree-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-request-continue.spec.ts:291:3 › should work with Cross-Origin-Opener-Policy @firefox-beta-ubuntu-20.04 
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @firefox-beta-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:324:3 › should be able to send third party cookies via an iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-har.spec.ts:244:3 › should round-trip har.zip @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:287:5 › screencast › should delete video @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @firefox-macos-13-xlarge 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:79:5 › launchServer › should connect over wss @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:48:5 › downloads path › should delete downloads when context closes @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:215:3 › should throw for socks5 authentication @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › tests/page/elementhandle-misc.spec.ts:20:3 › should hover @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @webkit-macos-13-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › tests/page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1534:1 › canvas clipping @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:241:5 › post data › should amend longer post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-20.04 
265331 passed, 10082 skipped

✔️✔️✔️
Merge workflow run.
@agg23
Adam Gastineau (agg23)
merged commit a2e2dfd
into
microsoft:mainJan 10, 2025

This was referenced Jan 10, 2025

Closed


Closed


Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jan 10, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@agg23@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Enable snapshots for most remaining public commands - #34072
Merged
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Jan 10, 2025
Merged
feat: Enable snapshots for most remaining public commands#34072
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Conversation
@agg23
@agg23Adam Gastineau (agg23)
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
Enable capturing snapshots on commands that have any visual component or interaction with the DOM. This is an interim solution to #33934. In the future we will display stale snapshots on trace entries that do not contain a snapshot.
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
approved these changes
Dec 18, 2024
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure you fix those tests before landing/
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
Dec 18, 2024

Copy link


Copy Markdown

Member
As this closes the issue for count(), having a test that checks that count() has gotten a snapshot would be nice as well.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 flaky⚠️ [electron-api] › tests/electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself @electron-macos-latest 
21465 passed, 503 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
9 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:487:3 › should update extracted har.zip for page @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:98:3 › should restore state from userDataDir @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:199:1 › should render console @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1385:1 › should show similar actions from library-only trace @webkit-ubuntu-22.04-node18 
37548 passed, 648 skipped

✔️✔️✔️
Merge workflow run.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
8 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:424:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-large

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-xlarge
110 flaky⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @channel-chromium-windows-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1017:1 › should open two trace files of the same test @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:536:5 › selector generator › should generate relative selector @chromium-headed-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chromium-tip-of-tree-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @chromium-tip-of-tree-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-request-continue.spec.ts:291:3 › should work with Cross-Origin-Opener-Policy @firefox-beta-ubuntu-20.04 
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @firefox-beta-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:324:3 › should be able to send third party cookies via an iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-har.spec.ts:244:3 › should round-trip har.zip @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:287:5 › screencast › should delete video @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @firefox-macos-13-xlarge 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:79:5 › launchServer › should connect over wss @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:48:5 › downloads path › should delete downloads when context closes @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:215:3 › should throw for socks5 authentication @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › tests/page/elementhandle-misc.spec.ts:20:3 › should hover @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @webkit-macos-13-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › tests/page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1534:1 › canvas clipping @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:241:5 › post data › should amend longer post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-20.04 
265331 passed, 10082 skipped

✔️✔️✔️
Merge workflow run.
@agg23
Adam Gastineau (agg23)
merged commit a2e2dfd
into
microsoft:mainJan 10, 2025

This was referenced Jan 10, 2025

Closed


Closed


Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jan 10, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@agg23@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: Enable snapshots for most remaining public commands - #34072
Merged
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Jan 10, 2025
Merged
feat: Enable snapshots for most remaining public commands#34072
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Conversation
@agg23
@agg23Adam Gastineau (agg23)
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
Enable capturing snapshots on commands that have any visual component or interaction with the DOM. This is an interim solution to #33934. In the future we will display stale snapshots on trace entries that do not contain a snapshot.
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
approved these changes
Dec 18, 2024
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure you fix those tests before landing/
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
Dec 18, 2024

Copy link


Copy Markdown

Member
As this closes the issue for count(), having a test that checks that count() has gotten a snapshot would be nice as well.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 flaky⚠️ [electron-api] › tests/electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself @electron-macos-latest 
21465 passed, 503 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
9 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:487:3 › should update extracted har.zip for page @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:98:3 › should restore state from userDataDir @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:199:1 › should render console @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1385:1 › should show similar actions from library-only trace @webkit-ubuntu-22.04-node18 
37548 passed, 648 skipped

✔️✔️✔️
Merge workflow run.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
8 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:424:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-large

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-xlarge
110 flaky⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @channel-chromium-windows-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1017:1 › should open two trace files of the same test @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:536:5 › selector generator › should generate relative selector @chromium-headed-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chromium-tip-of-tree-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @chromium-tip-of-tree-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-request-continue.spec.ts:291:3 › should work with Cross-Origin-Opener-Policy @firefox-beta-ubuntu-20.04 
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @firefox-beta-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:324:3 › should be able to send third party cookies via an iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-har.spec.ts:244:3 › should round-trip har.zip @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:287:5 › screencast › should delete video @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @firefox-macos-13-xlarge 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:79:5 › launchServer › should connect over wss @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:48:5 › downloads path › should delete downloads when context closes @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:215:3 › should throw for socks5 authentication @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › tests/page/elementhandle-misc.spec.ts:20:3 › should hover @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @webkit-macos-13-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › tests/page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1534:1 › canvas clipping @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:241:5 › post data › should amend longer post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-20.04 
265331 passed, 10082 skipped

✔️✔️✔️
Merge workflow run.
@agg23
Adam Gastineau (agg23)
merged commit a2e2dfd
into
microsoft:mainJan 10, 2025

This was referenced Jan 10, 2025

Closed


Closed


Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jan 10, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@agg23@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Enable snapshots for most remaining public commands - #34072
Merged
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Jan 10, 2025
Merged
feat: Enable snapshots for most remaining public commands#34072
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Conversation
@agg23
@agg23Adam Gastineau (agg23)
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
Enable capturing snapshots on commands that have any visual component or interaction with the DOM. This is an interim solution to #33934. In the future we will display stale snapshots on trace entries that do not contain a snapshot.
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
approved these changes
Dec 18, 2024
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure you fix those tests before landing/
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
Dec 18, 2024

Copy link


Copy Markdown

Member
As this closes the issue for count(), having a test that checks that count() has gotten a snapshot would be nice as well.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 flaky⚠️ [electron-api] › tests/electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself @electron-macos-latest 
21465 passed, 503 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
9 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:487:3 › should update extracted har.zip for page @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:98:3 › should restore state from userDataDir @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:199:1 › should render console @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1385:1 › should show similar actions from library-only trace @webkit-ubuntu-22.04-node18 
37548 passed, 648 skipped

✔️✔️✔️
Merge workflow run.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
8 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:424:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-large

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-xlarge
110 flaky⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @channel-chromium-windows-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1017:1 › should open two trace files of the same test @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:536:5 › selector generator › should generate relative selector @chromium-headed-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chromium-tip-of-tree-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @chromium-tip-of-tree-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-request-continue.spec.ts:291:3 › should work with Cross-Origin-Opener-Policy @firefox-beta-ubuntu-20.04 
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @firefox-beta-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:324:3 › should be able to send third party cookies via an iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-har.spec.ts:244:3 › should round-trip har.zip @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:287:5 › screencast › should delete video @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @firefox-macos-13-xlarge 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:79:5 › launchServer › should connect over wss @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:48:5 › downloads path › should delete downloads when context closes @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:215:3 › should throw for socks5 authentication @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › tests/page/elementhandle-misc.spec.ts:20:3 › should hover @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @webkit-macos-13-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › tests/page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1534:1 › canvas clipping @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:241:5 › post data › should amend longer post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-20.04 
265331 passed, 10082 skipped

✔️✔️✔️
Merge workflow run.
@agg23
Adam Gastineau (agg23)
merged commit a2e2dfd
into
microsoft:mainJan 10, 2025

This was referenced Jan 10, 2025

Closed


Closed


Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jan 10, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@agg23@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Enable snapshots for most remaining public commands - #34072
Merged
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Jan 10, 2025
Merged
feat: Enable snapshots for most remaining public commands#34072
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Conversation
@agg23
@agg23Adam Gastineau (agg23)
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
Enable capturing snapshots on commands that have any visual component or interaction with the DOM. This is an interim solution to #33934. In the future we will display stale snapshots on trace entries that do not contain a snapshot.
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
approved these changes
Dec 18, 2024
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure you fix those tests before landing/
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
Dec 18, 2024

Copy link


Copy Markdown

Member
As this closes the issue for count(), having a test that checks that count() has gotten a snapshot would be nice as well.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 flaky⚠️ [electron-api] › tests/electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself @electron-macos-latest 
21465 passed, 503 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
9 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:487:3 › should update extracted har.zip for page @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:98:3 › should restore state from userDataDir @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:199:1 › should render console @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1385:1 › should show similar actions from library-only trace @webkit-ubuntu-22.04-node18 
37548 passed, 648 skipped

✔️✔️✔️
Merge workflow run.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
8 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:424:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-large

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-xlarge
110 flaky⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @channel-chromium-windows-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1017:1 › should open two trace files of the same test @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:536:5 › selector generator › should generate relative selector @chromium-headed-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chromium-tip-of-tree-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @chromium-tip-of-tree-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-request-continue.spec.ts:291:3 › should work with Cross-Origin-Opener-Policy @firefox-beta-ubuntu-20.04 
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @firefox-beta-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:324:3 › should be able to send third party cookies via an iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-har.spec.ts:244:3 › should round-trip har.zip @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:287:5 › screencast › should delete video @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @firefox-macos-13-xlarge 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:79:5 › launchServer › should connect over wss @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:48:5 › downloads path › should delete downloads when context closes @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:215:3 › should throw for socks5 authentication @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › tests/page/elementhandle-misc.spec.ts:20:3 › should hover @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @webkit-macos-13-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › tests/page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1534:1 › canvas clipping @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:241:5 › post data › should amend longer post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-20.04 
265331 passed, 10082 skipped

✔️✔️✔️
Merge workflow run.
@agg23
Adam Gastineau (agg23)
merged commit a2e2dfd
into
microsoft:mainJan 10, 2025

This was referenced Jan 10, 2025

Closed


Closed


Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jan 10, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@agg23@pavelfeldman

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: Enable snapshots for most remaining public commands - #34072
Merged
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Jan 10, 2025
Merged
feat: Enable snapshots for most remaining public commands#34072
Adam Gastineau (agg23) merged 4 commits into
microsoft:mainfrom 
agg23:more-snapshot-commands
Conversation
@agg23
@agg23Adam Gastineau (agg23)
commented
Dec 18, 2024

Copy link


Copy Markdown

Contributor
Enable capturing snapshots on commands that have any visual component or interaction with the DOM. This is an interim solution to #33934. In the future we will display stale snapshots on trace entries that do not contain a snapshot.
@github-actions

This comment has been minimized.

Sign in to view
pavelfeldman
Pavel Feldman (pavelfeldman)
approved these changes
Dec 18, 2024
View reviewed changes
@pavelfeldmanPavel Feldman (pavelfeldman)
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but make sure you fix those tests before landing/
@pavelfeldman
Pavel Feldman (pavelfeldman)
commented
Dec 18, 2024

Copy link


Copy Markdown

Member
As this closes the issue for count(), having a test that checks that count() has gotten a snapshot would be nice as well.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests others"
1 flaky⚠️ [electron-api] › tests/electron/electron-app.spec.ts:55:5 › should fire close event when the app quits itself @electron-macos-latest 
21465 passed, 503 skipped

✔️✔️✔️
Merge workflow run.
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 1"
9 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18 
⚠️ [installation tests] › tests/playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest 
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:487:3 › should update extracted har.zip for page @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/defaultbrowsercontext-2.spec.ts:98:3 › should restore state from userDataDir @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:199:1 › should render console @webkit-ubuntu-22.04-node18 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1385:1 › should show similar actions from library-only trace @webkit-ubuntu-22.04-node18 
37548 passed, 648 skipped

✔️✔️✔️
Merge workflow run.
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
github-actionsBot
commented
Jan 9, 2025

Copy link


Copy Markdown

Contributor
Test results for "tests 2"
8 failed

❌ [chromium-library] › tests/library/browsertype-connect.spec.ts:424:5 › run-server › should reject waitForEvent before browser.onDisconnect fires @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:84:5 › should work with --save-har and --save-har-glob @chrome-macos-latest

❌ [chromium-library] › tests/library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified @chrome-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder @msedge-beta-macos-latest

❌ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-beta-macos-latest

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-large

❌ [webkit-library] › tests/library/trace-viewer.spec.ts:1598:1 › should show a popover @webkit-macos-13-xlarge
110 flaky⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @channel-chromium-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @channel-chromium-windows-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:667:5 › run-server › should fulfill with global fetch result @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:88:5 › should not generate recordHAR with --save-har @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-test.spec.ts:112:5 › should generate routeFromHAR with --save-har and --save-har-glob @chrome-macos-latest 
⚠️ [chromium-page] › tests/page/page-screenshot.spec.ts:650:5 › page screenshot animations › should stop animations that happen right before screenshot @chrome-macos-latest 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1017:1 › should open two trace files of the same test @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:581:5 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) @chrome-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/pause.spec.ts:529:5 › pause › should record from debugger @chromium-headed-ubuntu-24.04 
⚠️ [chromium-library] › tests/library/selector-generator.spec.ts:536:5 › selector generator › should generate relative selector @chromium-headed-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chromium-tip-of-tree-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @chromium-tip-of-tree-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-beta-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-request-continue.spec.ts:291:3 › should work with Cross-Origin-Opener-Policy @firefox-beta-ubuntu-20.04 
⚠️ [firefox-library] › tests/library/trace-viewer.spec.ts:1551:1 › canvas clipping in iframe @firefox-beta-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-beta-windows-latest 
⚠️ [firefox-library] › tests/library/capabilities.spec.ts:252:3 › requestFullscreen @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/browsercontext-basic.spec.ts:34:3 › should be able to click across browser contexts @firefox-headed-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-ubuntu-24.04 
⚠️ [firefox-library] › tests/library/browsercontext-cookies.spec.ts:324:3 › should be able to send third party cookies via an iframe @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/browsercontext-har.spec.ts:244:3 › should round-trip har.zip @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:263:5 › should not include trace resources from the previous chunks @firefox-headed-windows-latest 
⚠️ [firefox-library] › tests/library/video.spec.ts:287:5 › screencast › should delete video @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-headed-windows-latest 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-13-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @firefox-macos-13-xlarge 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-macos-14-large 
⚠️ [firefox-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames fit @firefox-macos-14-xlarge 
⚠️ [firefox-library] › tests/library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-20.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-24.04 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:79:5 › launchServer › should connect over wss @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:48:5 › downloads path › should delete downloads when context closes @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har @msedge-beta-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:215:3 › should throw for socks5 authentication @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:264:3 › should isolate proxy credentials between contexts @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page @msedge-beta-windows-latest 
⚠️ [chromium-library] › tests/library/beforeunload.spec.ts:20:3 › should close browser with beforeunload page @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:91:5 › downloads path › should accept downloads in persistent context @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:466:7 › cli codegen › should save assets via SIGINT @msedge-dev-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-dev-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-fetch.spec.ts:1229:3 › should work with connectOverCDP @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-connect.spec.ts:343:5 › launchServer › should throw when calling waitForNavigation after disconnect @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsertype-launch.spec.ts:115:3 › should fire close event for all contexts @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/chromium/connect-over-cdp.spec.ts:43:5 › should use logger in default context @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/downloads-path.spec.ts:77:5 › downloads path › should report downloads in downloadsPath folder with a relative path @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-2.spec.ts:456:7 › cli codegen › should --save-trace @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @msedge-macos-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-ubuntu-20.04 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:247:3 › should authenticate with empty password @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/browsercontext-reuse.spec.ts:30:1 › should re-add binding after reset @msedge-windows-latest 
⚠️ [chromium-library] › tests/library/video.spec.ts:381:5 › screencast › should capture navigation @tracing-chromium-tip-of-tree 
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @tracing-firefox 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-headed-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-headed-ubuntu-20.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select @webkit-headed-ubuntu-22.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-ubuntu-22.04 
⚠️ [webkit-page] › tests/page/elementhandle-misc.spec.ts:20:3 › should hover @webkit-headed-ubuntu-24.04 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:61:7 › cli codegen › should click locator.nth @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-3.spec.ts:779:7 › cli codegen › should assert visibility @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/inspector/cli-codegen-pick-locator.spec.ts:36:7 › should update locator highlight @webkit-headed-windows-latest 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1221:1 › should pick locator in iframe @webkit-macos-13-large 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-13-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-13-xlarge 
⚠️ [webkit-page] › tests/page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-14-large 
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1534:1 › canvas clipping @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-14-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames crop @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/tracing.spec.ts:432:14 › should produce screencast frames scale @webkit-macos-15-xlarge 
⚠️ [webkit-page] › tests/page/page-request-continue.spec.ts:241:5 › post data › should amend longer post data @webkit-macos-15-xlarge 
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-20.04 
265331 passed, 10082 skipped

✔️✔️✔️
Merge workflow run.
@agg23
Adam Gastineau (agg23)
merged commit a2e2dfd
into
microsoft:mainJan 10, 2025

This was referenced Jan 10, 2025

Closed


Closed


Closed

@agg23Adam Gastineau (agg23)
mentioned this pull request
Jan 10, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pavelfeldmanPavel Feldman (pavelfeldman)pavelfeldman approved these changes

Assignees


No one assigned


Labels

CQ1

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@agg23@pavelfeldman