feat: recreate IndexedDB in storagestate

[Simon Knott (Skn0tt)]

Closes#11164

[Copilot]

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

docs/src/api/params.md:268

• The documentation for the indexedDB field is incomplete. The 'TODO: document more' comment should be replaced with a proper description.

indexedDB ?<[Array]<[Object]>>

tests/library/browsercontext-storage-state.spec.ts:320

• The test case should also cover scenarios where the 'indexedDB' array is empty or null.

it('should support IndexedDB', async ({ page, contextFactory }) => {

[Dmitry Gozman (dgozman)]

Let's make sure any error clearly states that it was not able to serialize IndexedDB. Probably a big try/catch around IndexedDB code would be the best.

[Simon Knott (Skn0tt)]

i've added .catch to the two big promises.

[Dmitry Gozman (dgozman)]

WDYT about including keys/values verbatim, as long as they are serializable as JSON? And if not, we can have additional keyEncoded/valueEncoded properties that will hold the serialized value in any format. This way, the format is usually readable, except for when encoding is actually required.

[Simon Knott (Skn0tt)]

makes sense to me 👍 doing this in a follow-up

[Dmitry Gozman (dgozman)]

I guess we can make this one optional as well.

[Simon Knott (Skn0tt)]

gonna do that in a follow-up.

[github-actions]

Test results for "tests 1"

10 flaky

⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-trace.spec.ts:341:5 › should work behind reverse proxy @ubuntu-latest-node22-1
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/debug-controller.spec.ts:142:1 › should reset for reuse @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:452:5 › selector generator › should not accept invalid role for candidate consideration @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:247:1 › should render network bars @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18

37781 passed, 655 skipped
✔️✔️✔️

Merge workflow run.