chore(docs): fix docs API handling duped methods with different langs by agg23 · Pull Request #34596 · microsoft/playwright

Adam Gastineau (agg23) · 2025-02-03T15:48:27Z

This allows docs to specify multiple instances of the same top level method for different languages, allowing for differing docs or arguments.

This docs construction fails on the ports:

## async method: BrowserType.connect* since: v1.8
* langs: js
- returns: <[Browser]>
String A
## async method: BrowserType.connect* since: v1.8
* langs: python, csharp, java
- returns: <[Browser]>
String B
### param: BrowserType.connect.wsEndpoint* since: v1.10
-`wsEndpoint` <[string]>

The only difference here is we want to have different docs for JS and the other languages. Parts of the API parsing code handle overloads correctly, some parts do not. This PR fixes one of them to make this use casefunctional.

Additionally, existing docs (Video.saveAs) contained a method definition with no provided languages, and an override with certain languages specified. This didn't resolve properly, only showing the "all language" definition.

## async method: Video.saveAs* since: v1.11
String A
## method: Video.saveAs* langs: java
* since: v1.11
String B
## async method: Video.saveAs* langs: python
* since: v1.11
String C

This situation now throws an error. The correct solution is to list each language under the corresponding docs entry.

…soft#34596

Dmitry Gozman (dgozman) · 2025-02-04T07:54:45Z

+ throw new Error(`Duplicate member ${clazz.name}.${name} for at least one language: ${member.langs.only}`);
+ } else {
+ // This member exists alongside the current one
+ clazz.membersArray.push(member);


IIUC, this will make two members with the same name, but different langs? Seems to differ from other places where we put lang-specific fields into the same member under .langs.

This is already how the docs generation works (see https://github.com/microsoft/playwright/blob/main/docs/src/api/class-page.md?plain=1#L1270-L1284, which generates two entries in api.json even before this change). I originally tested putting the member override into langs.overrides, but it didn't work as expected, and I didn't look into it further. It seems like langs.overrides is only used in very particular cases and probably doesn't like me doing things generally.

Dmitry Gozman (dgozman) · 2025-02-04T08:02:07Z

- existingMember.langs.types[lang] = returnType;
+ if (existingMember) {
+ if (isTypeOverride(existingMember, member) && (member.spec === undefined || member.spec.length === 0)) {
+ // Can only override return types if the overriding entry (`member`) has no spec content


Love comments!

github-actions · 2025-02-04T14:03:32Z

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

15 flaky

⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node18-1
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:125:3 › should authenticate @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37764 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Adam Gastineau (agg23) · 2025-02-04T17:52:46Z

We have decided that the complexity of modifying the docs code is too high, and thus this change is not worthwhile.

Adam Gastineau (agg23) · 2025-02-03T15:48:27Z

This allows docs to specify multiple instances of the same top level method for different languages, allowing for differing docs or arguments.

This docs construction fails on the ports:

## async method: BrowserType.connect* since: v1.8
* langs: js
- returns: <[Browser]>
String A
## async method: BrowserType.connect* since: v1.8
* langs: python, csharp, java
- returns: <[Browser]>
String B
### param: BrowserType.connect.wsEndpoint* since: v1.10
-`wsEndpoint` <[string]>

The only difference here is we want to have different docs for JS and the other languages. Parts of the API parsing code handle overloads correctly, some parts do not. This PR fixes one of them to make this use casefunctional.

Additionally, existing docs (Video.saveAs) contained a method definition with no provided languages, and an override with certain languages specified. This didn't resolve properly, only showing the "all language" definition.

## async method: Video.saveAs* since: v1.11
String A
## method: Video.saveAs* langs: java
* since: v1.11
String B
## async method: Video.saveAs* langs: python
* since: v1.11
String C

This situation now throws an error. The correct solution is to list each language under the corresponding docs entry.

…soft#34596

Dmitry Gozman (dgozman) · 2025-02-04T07:54:45Z

+ throw new Error(`Duplicate member ${clazz.name}.${name} for at least one language: ${member.langs.only}`);
+ } else {
+ // This member exists alongside the current one
+ clazz.membersArray.push(member);


IIUC, this will make two members with the same name, but different langs? Seems to differ from other places where we put lang-specific fields into the same member under .langs.

This is already how the docs generation works (see https://github.com/microsoft/playwright/blob/main/docs/src/api/class-page.md?plain=1#L1270-L1284, which generates two entries in api.json even before this change). I originally tested putting the member override into langs.overrides, but it didn't work as expected, and I didn't look into it further. It seems like langs.overrides is only used in very particular cases and probably doesn't like me doing things generally.

Dmitry Gozman (dgozman) · 2025-02-04T08:02:07Z

- existingMember.langs.types[lang] = returnType;
+ if (existingMember) {
+ if (isTypeOverride(existingMember, member) && (member.spec === undefined || member.spec.length === 0)) {
+ // Can only override return types if the overriding entry (`member`) has no spec content


Love comments!

github-actions · 2025-02-04T14:03:32Z

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

15 flaky

⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node18-1
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:125:3 › should authenticate @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37764 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Adam Gastineau (agg23) · 2025-02-04T17:52:46Z

We have decided that the complexity of modifying the docs code is too high, and thus this change is not worthwhile.

Adam Gastineau (agg23) · 2025-02-03T15:48:27Z

This allows docs to specify multiple instances of the same top level method for different languages, allowing for differing docs or arguments.

This docs construction fails on the ports:

## async method: BrowserType.connect* since: v1.8
* langs: js
- returns: <[Browser]>
String A
## async method: BrowserType.connect* since: v1.8
* langs: python, csharp, java
- returns: <[Browser]>
String B
### param: BrowserType.connect.wsEndpoint* since: v1.10
-`wsEndpoint` <[string]>

The only difference here is we want to have different docs for JS and the other languages. Parts of the API parsing code handle overloads correctly, some parts do not. This PR fixes one of them to make this use casefunctional.

Additionally, existing docs (Video.saveAs) contained a method definition with no provided languages, and an override with certain languages specified. This didn't resolve properly, only showing the "all language" definition.

## async method: Video.saveAs* since: v1.11
String A
## method: Video.saveAs* langs: java
* since: v1.11
String B
## async method: Video.saveAs* langs: python
* since: v1.11
String C

This situation now throws an error. The correct solution is to list each language under the corresponding docs entry.

…soft#34596

Dmitry Gozman (dgozman) · 2025-02-04T07:54:45Z

+ throw new Error(`Duplicate member ${clazz.name}.${name} for at least one language: ${member.langs.only}`);
+ } else {
+ // This member exists alongside the current one
+ clazz.membersArray.push(member);


IIUC, this will make two members with the same name, but different langs? Seems to differ from other places where we put lang-specific fields into the same member under .langs.

This is already how the docs generation works (see https://github.com/microsoft/playwright/blob/main/docs/src/api/class-page.md?plain=1#L1270-L1284, which generates two entries in api.json even before this change). I originally tested putting the member override into langs.overrides, but it didn't work as expected, and I didn't look into it further. It seems like langs.overrides is only used in very particular cases and probably doesn't like me doing things generally.

Dmitry Gozman (dgozman) · 2025-02-04T08:02:07Z

- existingMember.langs.types[lang] = returnType;
+ if (existingMember) {
+ if (isTypeOverride(existingMember, member) && (member.spec === undefined || member.spec.length === 0)) {
+ // Can only override return types if the overriding entry (`member`) has no spec content


Love comments!

github-actions · 2025-02-04T14:03:32Z

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

15 flaky

⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node18-1
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:125:3 › should authenticate @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37764 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Adam Gastineau (agg23) · 2025-02-04T17:52:46Z

We have decided that the complexity of modifying the docs code is too high, and thus this change is not worthwhile.

Adam Gastineau (agg23) · 2025-02-03T15:48:27Z

This allows docs to specify multiple instances of the same top level method for different languages, allowing for differing docs or arguments.

This docs construction fails on the ports:

## async method: BrowserType.connect* since: v1.8
* langs: js
- returns: <[Browser]>
String A
## async method: BrowserType.connect* since: v1.8
* langs: python, csharp, java
- returns: <[Browser]>
String B
### param: BrowserType.connect.wsEndpoint* since: v1.10
-`wsEndpoint` <[string]>

The only difference here is we want to have different docs for JS and the other languages. Parts of the API parsing code handle overloads correctly, some parts do not. This PR fixes one of them to make this use casefunctional.

Additionally, existing docs (Video.saveAs) contained a method definition with no provided languages, and an override with certain languages specified. This didn't resolve properly, only showing the "all language" definition.

## async method: Video.saveAs* since: v1.11
String A
## method: Video.saveAs* langs: java
* since: v1.11
String B
## async method: Video.saveAs* langs: python
* since: v1.11
String C

This situation now throws an error. The correct solution is to list each language under the corresponding docs entry.

…soft#34596

Dmitry Gozman (dgozman) · 2025-02-04T07:54:45Z

+ throw new Error(`Duplicate member ${clazz.name}.${name} for at least one language: ${member.langs.only}`);
+ } else {
+ // This member exists alongside the current one
+ clazz.membersArray.push(member);


IIUC, this will make two members with the same name, but different langs? Seems to differ from other places where we put lang-specific fields into the same member under .langs.

This is already how the docs generation works (see https://github.com/microsoft/playwright/blob/main/docs/src/api/class-page.md?plain=1#L1270-L1284, which generates two entries in api.json even before this change). I originally tested putting the member override into langs.overrides, but it didn't work as expected, and I didn't look into it further. It seems like langs.overrides is only used in very particular cases and probably doesn't like me doing things generally.

Dmitry Gozman (dgozman) · 2025-02-04T08:02:07Z

- existingMember.langs.types[lang] = returnType;
+ if (existingMember) {
+ if (isTypeOverride(existingMember, member) && (member.spec === undefined || member.spec.length === 0)) {
+ // Can only override return types if the overriding entry (`member`) has no spec content


Love comments!

github-actions · 2025-02-04T14:03:32Z

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

15 flaky

⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node18-1
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:125:3 › should authenticate @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37764 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Adam Gastineau (agg23) · 2025-02-04T17:52:46Z

We have decided that the complexity of modifying the docs code is too high, and thus this change is not worthwhile.

Adam Gastineau (agg23) · 2025-02-03T15:48:27Z

This allows docs to specify multiple instances of the same top level method for different languages, allowing for differing docs or arguments.

This docs construction fails on the ports:

## async method: BrowserType.connect* since: v1.8
* langs: js
- returns: <[Browser]>
String A
## async method: BrowserType.connect* since: v1.8
* langs: python, csharp, java
- returns: <[Browser]>
String B
### param: BrowserType.connect.wsEndpoint* since: v1.10
-`wsEndpoint` <[string]>

The only difference here is we want to have different docs for JS and the other languages. Parts of the API parsing code handle overloads correctly, some parts do not. This PR fixes one of them to make this use casefunctional.

Additionally, existing docs (Video.saveAs) contained a method definition with no provided languages, and an override with certain languages specified. This didn't resolve properly, only showing the "all language" definition.

## async method: Video.saveAs* since: v1.11
String A
## method: Video.saveAs* langs: java
* since: v1.11
String B
## async method: Video.saveAs* langs: python
* since: v1.11
String C

This situation now throws an error. The correct solution is to list each language under the corresponding docs entry.

…soft#34596

Dmitry Gozman (dgozman) · 2025-02-04T07:54:45Z

+ throw new Error(`Duplicate member ${clazz.name}.${name} for at least one language: ${member.langs.only}`);
+ } else {
+ // This member exists alongside the current one
+ clazz.membersArray.push(member);


IIUC, this will make two members with the same name, but different langs? Seems to differ from other places where we put lang-specific fields into the same member under .langs.

This is already how the docs generation works (see https://github.com/microsoft/playwright/blob/main/docs/src/api/class-page.md?plain=1#L1270-L1284, which generates two entries in api.json even before this change). I originally tested putting the member override into langs.overrides, but it didn't work as expected, and I didn't look into it further. It seems like langs.overrides is only used in very particular cases and probably doesn't like me doing things generally.

Dmitry Gozman (dgozman) · 2025-02-04T08:02:07Z

- existingMember.langs.types[lang] = returnType;
+ if (existingMember) {
+ if (isTypeOverride(existingMember, member) && (member.spec === undefined || member.spec.length === 0)) {
+ // Can only override return types if the overriding entry (`member`) has no spec content


Love comments!

github-actions · 2025-02-04T14:03:32Z

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

15 flaky

⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node18-1
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:125:3 › should authenticate @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37764 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Adam Gastineau (agg23) · 2025-02-04T17:52:46Z

We have decided that the complexity of modifying the docs code is too high, and thus this change is not worthwhile.

Adam Gastineau (agg23) · 2025-02-03T15:48:27Z

This allows docs to specify multiple instances of the same top level method for different languages, allowing for differing docs or arguments.

This docs construction fails on the ports:

## async method: BrowserType.connect* since: v1.8
* langs: js
- returns: <[Browser]>
String A
## async method: BrowserType.connect* since: v1.8
* langs: python, csharp, java
- returns: <[Browser]>
String B
### param: BrowserType.connect.wsEndpoint* since: v1.10
-`wsEndpoint` <[string]>

The only difference here is we want to have different docs for JS and the other languages. Parts of the API parsing code handle overloads correctly, some parts do not. This PR fixes one of them to make this use casefunctional.

Additionally, existing docs (Video.saveAs) contained a method definition with no provided languages, and an override with certain languages specified. This didn't resolve properly, only showing the "all language" definition.

## async method: Video.saveAs* since: v1.11
String A
## method: Video.saveAs* langs: java
* since: v1.11
String B
## async method: Video.saveAs* langs: python
* since: v1.11
String C

This situation now throws an error. The correct solution is to list each language under the corresponding docs entry.

…soft#34596

Dmitry Gozman (dgozman) · 2025-02-04T07:54:45Z

+ throw new Error(`Duplicate member ${clazz.name}.${name} for at least one language: ${member.langs.only}`);
+ } else {
+ // This member exists alongside the current one
+ clazz.membersArray.push(member);


IIUC, this will make two members with the same name, but different langs? Seems to differ from other places where we put lang-specific fields into the same member under .langs.

This is already how the docs generation works (see https://github.com/microsoft/playwright/blob/main/docs/src/api/class-page.md?plain=1#L1270-L1284, which generates two entries in api.json even before this change). I originally tested putting the member override into langs.overrides, but it didn't work as expected, and I didn't look into it further. It seems like langs.overrides is only used in very particular cases and probably doesn't like me doing things generally.

Dmitry Gozman (dgozman) · 2025-02-04T08:02:07Z

- existingMember.langs.types[lang] = returnType;
+ if (existingMember) {
+ if (isTypeOverride(existingMember, member) && (member.spec === undefined || member.spec.length === 0)) {
+ // Can only override return types if the overriding entry (`member`) has no spec content


Love comments!

github-actions · 2025-02-04T14:03:32Z

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

15 flaky

⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node18-1
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:125:3 › should authenticate @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37764 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Adam Gastineau (agg23) · 2025-02-04T17:52:46Z

We have decided that the complexity of modifying the docs code is too high, and thus this change is not worthwhile.

Adam Gastineau (agg23) · 2025-02-03T15:48:27Z

This allows docs to specify multiple instances of the same top level method for different languages, allowing for differing docs or arguments.

This docs construction fails on the ports:

## async method: BrowserType.connect* since: v1.8
* langs: js
- returns: <[Browser]>
String A
## async method: BrowserType.connect* since: v1.8
* langs: python, csharp, java
- returns: <[Browser]>
String B
### param: BrowserType.connect.wsEndpoint* since: v1.10
-`wsEndpoint` <[string]>

The only difference here is we want to have different docs for JS and the other languages. Parts of the API parsing code handle overloads correctly, some parts do not. This PR fixes one of them to make this use casefunctional.

Additionally, existing docs (Video.saveAs) contained a method definition with no provided languages, and an override with certain languages specified. This didn't resolve properly, only showing the "all language" definition.

## async method: Video.saveAs* since: v1.11
String A
## method: Video.saveAs* langs: java
* since: v1.11
String B
## async method: Video.saveAs* langs: python
* since: v1.11
String C

This situation now throws an error. The correct solution is to list each language under the corresponding docs entry.

…soft#34596

Dmitry Gozman (dgozman) · 2025-02-04T07:54:45Z

+ throw new Error(`Duplicate member ${clazz.name}.${name} for at least one language: ${member.langs.only}`);
+ } else {
+ // This member exists alongside the current one
+ clazz.membersArray.push(member);


IIUC, this will make two members with the same name, but different langs? Seems to differ from other places where we put lang-specific fields into the same member under .langs.

This is already how the docs generation works (see https://github.com/microsoft/playwright/blob/main/docs/src/api/class-page.md?plain=1#L1270-L1284, which generates two entries in api.json even before this change). I originally tested putting the member override into langs.overrides, but it didn't work as expected, and I didn't look into it further. It seems like langs.overrides is only used in very particular cases and probably doesn't like me doing things generally.

Dmitry Gozman (dgozman) · 2025-02-04T08:02:07Z

- existingMember.langs.types[lang] = returnType;
+ if (existingMember) {
+ if (isTypeOverride(existingMember, member) && (member.spec === undefined || member.spec.length === 0)) {
+ // Can only override return types if the overriding entry (`member`) has no spec content


Love comments!

github-actions · 2025-02-04T14:03:32Z

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

15 flaky

⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node18-1
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:125:3 › should authenticate @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37764 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Adam Gastineau (agg23) · 2025-02-04T17:52:46Z

We have decided that the complexity of modifying the docs code is too high, and thus this change is not worthwhile.

Adam Gastineau (agg23) · 2025-02-03T15:48:27Z

This allows docs to specify multiple instances of the same top level method for different languages, allowing for differing docs or arguments.

This docs construction fails on the ports:

## async method: BrowserType.connect* since: v1.8
* langs: js
- returns: <[Browser]>
String A
## async method: BrowserType.connect* since: v1.8
* langs: python, csharp, java
- returns: <[Browser]>
String B
### param: BrowserType.connect.wsEndpoint* since: v1.10
-`wsEndpoint` <[string]>

The only difference here is we want to have different docs for JS and the other languages. Parts of the API parsing code handle overloads correctly, some parts do not. This PR fixes one of them to make this use casefunctional.

Additionally, existing docs (Video.saveAs) contained a method definition with no provided languages, and an override with certain languages specified. This didn't resolve properly, only showing the "all language" definition.

## async method: Video.saveAs* since: v1.11
String A
## method: Video.saveAs* langs: java
* since: v1.11
String B
## async method: Video.saveAs* langs: python
* since: v1.11
String C

This situation now throws an error. The correct solution is to list each language under the corresponding docs entry.

…soft#34596

Dmitry Gozman (dgozman) · 2025-02-04T07:54:45Z

+ throw new Error(`Duplicate member ${clazz.name}.${name} for at least one language: ${member.langs.only}`);
+ } else {
+ // This member exists alongside the current one
+ clazz.membersArray.push(member);


IIUC, this will make two members with the same name, but different langs? Seems to differ from other places where we put lang-specific fields into the same member under .langs.

This is already how the docs generation works (see https://github.com/microsoft/playwright/blob/main/docs/src/api/class-page.md?plain=1#L1270-L1284, which generates two entries in api.json even before this change). I originally tested putting the member override into langs.overrides, but it didn't work as expected, and I didn't look into it further. It seems like langs.overrides is only used in very particular cases and probably doesn't like me doing things generally.

Dmitry Gozman (dgozman) · 2025-02-04T08:02:07Z

- existingMember.langs.types[lang] = returnType;
+ if (existingMember) {
+ if (isTypeOverride(existingMember, member) && (member.spec === undefined || member.spec.length === 0)) {
+ // Can only override return types if the overriding entry (`member`) has no spec content


Love comments!

github-actions · 2025-02-04T14:03:32Z

Test results for "tests 1"

1 failed
❌ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

15 flaky

⚠️ [chromium-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @chromium-ubuntu-22.04-node18
⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-ct.spec.ts:59:5 › should run component tests after editing test @ubuntu-latest-node18-1
⚠️ [webkit-library] › tests/library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:87:5 › mobile viewport › should support window.orientation emulation @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:31:3 › should use proxy Radoslav Kirilov (@smoke) @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:125:3 › should authenticate @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:44:14 › page screenshot › should work with a mobile viewport @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:868:5 › page screenshot animations › should wait for fonts to load @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37764 passed, 655 skipped
✔️✔️✔️

Merge workflow run.

Adam Gastineau (agg23) · 2025-02-04T17:52:46Z

We have decided that the complexity of modifying the docs code is too high, and thus this change is not worthwhile.

chore(docs): fix docs API handling duped methods with different langs
6d8cfa6

Adam Gastineau (agg23) requested a review from Max Schmitt (mxschmitt)February 3, 2025 15:48

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
209930a
…soft#34596

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
cde8078
…soft#34596

Adam Gastineau (agg23) mentioned this pull request Feb 3, 2025
chore(docs): Restore links removed in #34594, fixed in #34596 #34597
Closed

Adam Gastineau (agg23) requested a review from Dmitry Gozman (dgozman)February 3, 2025 15:55

This comment has been minimized.
Sign in to view

Fix Video.saveAs and properly error in unsupported cases
d2cfd4a

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Feb 4, 2025
View reviewed changes

Prevent insertion of duplicate instances
b1a7c15

Adam Gastineau (agg23) closed this Feb 4, 2025

chore(docs): fix docs API handling duped methods with different langs
6d8cfa6

Adam Gastineau (agg23) requested a review from Max Schmitt (mxschmitt)February 3, 2025 15:48

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
209930a
…soft#34596

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
cde8078
…soft#34596

Adam Gastineau (agg23) mentioned this pull request Feb 3, 2025
chore(docs): Restore links removed in #34594, fixed in #34596 #34597
Closed

Adam Gastineau (agg23) requested a review from Dmitry Gozman (dgozman)February 3, 2025 15:55

This comment has been minimized.
Sign in to view

Fix Video.saveAs and properly error in unsupported cases
d2cfd4a

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Feb 4, 2025
View reviewed changes

Prevent insertion of duplicate instances
b1a7c15

Adam Gastineau (agg23) closed this Feb 4, 2025

chore(docs): fix docs API handling duped methods with different langs
6d8cfa6

Adam Gastineau (agg23) requested a review from Max Schmitt (mxschmitt)February 3, 2025 15:48

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
209930a
…soft#34596

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
cde8078
…soft#34596

Adam Gastineau (agg23) mentioned this pull request Feb 3, 2025
chore(docs): Restore links removed in #34594, fixed in #34596 #34597
Closed

Adam Gastineau (agg23) requested a review from Dmitry Gozman (dgozman)February 3, 2025 15:55

This comment has been minimized.
Sign in to view

Fix Video.saveAs and properly error in unsupported cases
d2cfd4a

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Feb 4, 2025
View reviewed changes

Prevent insertion of duplicate instances
b1a7c15

Adam Gastineau (agg23) closed this Feb 4, 2025

chore(docs): fix docs API handling duped methods with different langs
6d8cfa6

Adam Gastineau (agg23) requested a review from Max Schmitt (mxschmitt)February 3, 2025 15:48

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
209930a
…soft#34596

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
cde8078
…soft#34596

Adam Gastineau (agg23) mentioned this pull request Feb 3, 2025
chore(docs): Restore links removed in #34594, fixed in #34596 #34597
Closed

Adam Gastineau (agg23) requested a review from Dmitry Gozman (dgozman)February 3, 2025 15:55

This comment has been minimized.
Sign in to view

Fix Video.saveAs and properly error in unsupported cases
d2cfd4a

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Feb 4, 2025
View reviewed changes

Prevent insertion of duplicate instances
b1a7c15

Adam Gastineau (agg23) closed this Feb 4, 2025

chore(docs): fix docs API handling duped methods with different langs
6d8cfa6

Adam Gastineau (agg23) requested a review from Max Schmitt (mxschmitt)February 3, 2025 15:48

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
209930a
…soft#34596

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
cde8078
…soft#34596

Adam Gastineau (agg23) mentioned this pull request Feb 3, 2025
chore(docs): Restore links removed in #34594, fixed in #34596 #34597
Closed

Adam Gastineau (agg23) requested a review from Dmitry Gozman (dgozman)February 3, 2025 15:55

This comment has been minimized.
Sign in to view

Fix Video.saveAs and properly error in unsupported cases
d2cfd4a

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Feb 4, 2025
View reviewed changes

Prevent insertion of duplicate instances
b1a7c15

Adam Gastineau (agg23) closed this Feb 4, 2025

chore(docs): fix docs API handling duped methods with different langs
6d8cfa6

Adam Gastineau (agg23) requested a review from Max Schmitt (mxschmitt)February 3, 2025 15:48

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
209930a
…soft#34596

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
cde8078
…soft#34596

Adam Gastineau (agg23) mentioned this pull request Feb 3, 2025
chore(docs): Restore links removed in #34594, fixed in #34596 #34597
Closed

Adam Gastineau (agg23) requested a review from Dmitry Gozman (dgozman)February 3, 2025 15:55

This comment has been minimized.
Sign in to view

Fix Video.saveAs and properly error in unsupported cases
d2cfd4a

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Feb 4, 2025
View reviewed changes

Prevent insertion of duplicate instances
b1a7c15

Adam Gastineau (agg23) closed this Feb 4, 2025

chore(docs): fix docs API handling duped methods with different langs
6d8cfa6

Adam Gastineau (agg23) requested a review from Max Schmitt (mxschmitt)February 3, 2025 15:48

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
209930a
…soft#34596

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
cde8078
…soft#34596

Adam Gastineau (agg23) mentioned this pull request Feb 3, 2025
chore(docs): Restore links removed in #34594, fixed in #34596 #34597
Closed

Adam Gastineau (agg23) requested a review from Dmitry Gozman (dgozman)February 3, 2025 15:55

This comment has been minimized.
Sign in to view

Fix Video.saveAs and properly error in unsupported cases
d2cfd4a

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Feb 4, 2025
View reviewed changes

Prevent insertion of duplicate instances
b1a7c15

Adam Gastineau (agg23) closed this Feb 4, 2025

chore(docs): fix docs API handling duped methods with different langs
6d8cfa6

Adam Gastineau (agg23) requested a review from Max Schmitt (mxschmitt)February 3, 2025 15:48

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
209930a
…soft#34596

Adam Gastineau (agg23) added a commit to agg23/playwright that referenced this pull request Feb 3, 2025
chore(docs): Restore links removed inmicrosoft#34594, fixed inmicro…
cde8078
…soft#34596

Adam Gastineau (agg23) mentioned this pull request Feb 3, 2025
chore(docs): Restore links removed in #34594, fixed in #34596 #34597
Closed

Adam Gastineau (agg23) requested a review from Dmitry Gozman (dgozman)February 3, 2025 15:55

This comment has been minimized.
Sign in to view

Fix Video.saveAs and properly error in unsupported cases
d2cfd4a

This comment has been minimized.
Sign in to view

Dmitry Gozman (dgozman) reviewed Feb 4, 2025
View reviewed changes

Prevent insertion of duplicate instances
b1a7c15

Adam Gastineau (agg23) closed this Feb 4, 2025

Uh oh!

Conversation

Adam Gastineau (agg23) commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Feb 4, 2025

Test results for "tests 1"

Uh oh!

Adam Gastineau (agg23) commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Adam Gastineau (agg23) commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Feb 4, 2025

Test results for "tests 1"

Uh oh!

Adam Gastineau (agg23) commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Adam Gastineau (agg23) commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Feb 4, 2025

Test results for "tests 1"

Uh oh!

Adam Gastineau (agg23) commented Feb 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

Adam Gastineau (agg23) commented Feb 3, 2025•
edited
Loading

Adam Gastineau (agg23) commented Feb 3, 2025•
edited
Loading

Adam Gastineau (agg23) commented Feb 3, 2025•
edited
Loading

Adam Gastineau (agg23) commented Feb 3, 2025•
edited
Loading

Adam Gastineau (agg23) commented Feb 3, 2025•
edited
Loading