Uh oh!
There was an error while loading. Please reload this page.
fix: allow opt out from IndexedDB in storagestate - #34650
Merged
Simon Knott (Skn0tt) merged 6 commits intoFeb 6, 2025
Conversation
This comment has been minimized.
This comment has been minimized.
Max Schmitt (mxschmitt)
left a comment
Contributor
There was a problem hiding this comment.
Isn't it skipping IndexedDb only? Maybe adjust title?
storageStateIndexedDB in storagestateSimon Knott (Skn0tt)
commented
Feb 6, 2025
ContributorAuthor
Good catch. I haven't had coffee this morning, time to change that. |
| const originsToSave = new Set(this._origins); | ||
| const collectScript = `(${storageScript.collect})((${utilityScriptSerializers.source})(), ${this._browser.options.name === 'firefox'})`; | ||
| const collectScript = `(${storageScript.collect})((${utilityScriptSerializers.source})(), ${this._browser.options.name === 'firefox'}, ${Boolean(process.env.PLAYWRIGHT_SKIP_INDEXEDDB)})`; |
Collaborator
There was a problem hiding this comment.
Let's make it a proper API option.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Max Schmitt (mxschmitt)
commented
Feb 6, 2025
Contributor
Whats the motivation behind this flag? The potential risk that it contains unwanted data? |
This comment has been minimized.
This comment has been minimized.
Simon Knott (Skn0tt)
commented
Feb 6, 2025
ContributorAuthor
IndexedDB might be very large, e.g. because it's used as a local cache. |
Dmitry Gozman (dgozman)
approved these changes
Feb 6, 2025
Contributor
Test results for "tests 1"1 failed 12 flaky37798 passed, 655 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows opting out from
storageStateviaenv varoption.