') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix: allow relative userDataDir by mxschmitt · Pull Request #34710 · microsoft/playwright · GitHub
Skip to content

fix: allow relative userDataDir - #34710

Merged
Max Schmitt (mxschmitt) merged 4 commits into
microsoft:mainfrom
mxschmitt:relative/user-data-dir
Feb 11, 2025
Merged

fix: allow relative userDataDir#34710
Max Schmitt (mxschmitt) merged 4 commits into
microsoft:mainfrom
mxschmitt:relative/user-data-dir

Conversation

@mxschmitt

@mxschmittMax Schmitt (mxschmitt) commented Feb 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

A relative directory in Chromium's user-data-dir argument ends up getting resolved against the directory of chrome.exe rather than the CWD on Windows.

Relates https://chromium-review.googlesource.com/c/chromium/src/+/2717314

Fixes#34700

@github-actions

This comment has been minimized.

Sign in to view
yury-s
Yury Semikhatsky (yury-s) reviewed Feb 10, 2025
View reviewed changes

@yury-sYury Semikhatsky (yury-s) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we need to resolve it in the other two browsers?

Comment threadpackages/playwright-core/src/server/chromium/chromium.ts Outdated
@mxschmitt

Max Schmitt (mxschmitt) commented Feb 11, 2025

Copy link
Copy Markdown
ContributorAuthor

Why don't we need to resolve it in the other two browsers?

Only Chromium on Windows behaved weirdly - moved it a layer up to normalise it everywhere!

dgozman
Dmitry Gozman (dgozman) reviewed Feb 11, 2025
View reviewed changes
Comment threadpackages/playwright-core/src/server/browserType.ts Outdated
Comment threadtests/library/defaultbrowsercontext-2.spec.ts Outdated
@github-actions

This comment has been minimized.

Sign in to view
dgozman
Dmitry Gozman (dgozman) approved these changes Feb 11, 2025
View reviewed changes
Comment threadtests/library/defaultbrowsercontext-2.spec.ts Outdated
Comment threadtests/library/defaultbrowsercontext-2.spec.ts Outdated
Comment threadpackages/playwright-core/src/client/browserType.ts
* limitations under the License.
*/

import path from 'path';

@dgozmanDmitry Gozman (dgozman)Feb 11, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the happy linting days!

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actionsBot commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

15 flaky⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-har.spec.ts:455:3 › should update har.zip for page @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsertype-connect.spec.ts:576:5 › launchServer › should properly disconnect when connection closes from the client side @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › localhost @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:224:1 › should complain about newer version of trace in old viewer @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1133:1 › should display language-specific locators @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1336:1 › should highlight locator in iframe while typing @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:1551:1 › should not leak recorders @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-event-popup.spec.ts:28:3 › should work with window features @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-leaks.spec.ts:161:5 › waitFor should not leak @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37841 passed, 654 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt
Max Schmitt (mxschmitt) merged commit 416c9b3 into microsoft:mainFeb 11, 2025
@mxschmitt
Max Schmitt (mxschmitt) deleted the relative/user-data-dir branch February 11, 2025 16:40
This was referenced Feb 11, 2025
Closed
Closed
Closed
@mxschmittMax Schmitt (mxschmitt) mentioned this pull request Feb 11, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yury-sYury Semikhatsky (yury-s)yury-s left review comments
@dgozmanDmitry Gozman (dgozman)dgozman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: user_data_dir in launch_persistent_context() resolves relative paths relative to browser executable instead of current working directory

3 participants

@mxschmitt@yury-s@dgozman